From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D07A1C2BA4C for ; Wed, 26 Jan 2022 09:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xkSFL20wSDlNOaj+C+IfwTLUy48/WGCYHTr1hOMfNu8=; b=n1LICD8/vOD9sf wF6IUJpvOnjA6gYt1ty7MCDieo6xmO3u+NohLqGNnJuW9sQEiSk5edEGhc396lT4Jhwi7h4aVPny4 XOscLwjleltPZII5bN1JjCG/SRNfNbcggcXL1ktNxGHRegouV1gi1GeAdm0Fy3mXCULNBqjFqBLg9 Fhg73zIWfhEJJ7LrtRR8NI6oMbJlXZRzkUTQNhdVVr5yo4IyFUIl897iTAx12lpYbvCvqa3DEdSXy rmTdn013+GncWXWiconk5TxtLet6Pb6GlNa9q4al10FCj5wb0YuAlscLRJQrbLgVen3iv8oxT/aC7 b0azPSE1cdgc7wJFy6Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCf3d-00B6gp-0g; Wed, 26 Jan 2022 09:57:41 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCf3X-00B6DV-EP for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 09:57:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V8Uqobix5AjhwcCsMkdZlxgySGKpMgvXrCqwp7f4jIE=; b=OFQ2r9Rv9k1+6yjKTg5rruRSU/ FaiXH+keA6pqHDBj4Uk7/VvJuUiM1BpBr7dqrUA523EXe4ZWSbhBk+cgPjww7neZZPz6jydgs5njF 4i8CR9EsRnZ2irZeeH49CM+Ryhr2U1TmrFBweqjX8oA2XvIlj0WMMdORTx43s8dfP+xX/7hTp7m7H x3+ny3q+Xb4/GNHUTIlH/JFOY8ApXpwdfF8R0I/FKtcbEoRxdQXR/H098BLqPRcw6dzU4VE/QbyVm BGw3cdgjqaRSwIGWiI/i2TrfxMkIVcWnmKgC02CCUa2Cd1cwcAcvSLsaDAuupu265gJNz68F4KOg6 DjPO6WNQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56872) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nCf1L-00035P-6b; Wed, 26 Jan 2022 09:55:19 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nCf17-0004Mp-RT; Wed, 26 Jan 2022 09:55:05 +0000 Date: Wed, 26 Jan 2022 09:55:05 +0000 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Coquelin , Andrew Lunn , "David S. Miller" , Heiner Kallweit , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 4/7] net: stmmac/xpcs: convert to pcs_validate() Message-ID: References: <20220125105303.2025dfae@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220125105303.2025dfae@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_015735_509335_F8642495 X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 25, 2022 at 10:53:03AM -0800, Jakub Kicinski wrote: > On Tue, 25 Jan 2022 16:40:40 +0000 Russell King (Oracle) wrote: > > stmmac explicitly calls the xpcs driver to validate the ethtool > > linkmodes. This is no longer necessary as phylink now supports > > validation through a PCS method. Convert both drivers to use this > > new mechanism. > > > > Tested-by: Wong Vee Khee # Intel EHL Signed-off-by: Russell King (Oracle) > > Sign-offs got scrambled. Grumble. Never used to happen when I used MicroEMACS, but seems to be a regular occurence when using vim - because it's pretty much impossible to see wrapped lines in vim, especially when they have the perfect amount of white space at the end of the previous line. > Transient warning from here to patch 6: > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:943:22: warning: unused variable 'priv' [-Wunused-variable] > struct stmmac_priv *priv = netdev_priv(to_net_dev(config->dev)); > ^ Thanks, v2 will be on its way with both of the above fixed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel