From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC463C28CF5 for ; Wed, 26 Jan 2022 13:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=osuCmgpxC7Hm0nkU/b/HEpIt0xOtXGtGjQyLmlWY8bw=; b=TPrzK+v7lIoTAx 9OyUVVKEVGDcwE7Whd5HZxuU6HeEW3FSnf6O5AwHivOyJWNumPPpXNFN6+uMQRfWQnUUjbeRMO5pY 2ogfJF94cCzDpaK73tMfUdfjJJXeVcoWd6hBOBUueC9UsIP0DGBcNvR+TorvzXOQ+DqmiNncf8djw rGO2mMRMrV7F6xRLqHzYkhNid8tY85+2rm6yRIFy3Lc12tsJHbX9rPWOtvec9cW+01o4gg8fLecjk XOVKzi7C0+4HvAr2n7bnkO97an3wOZV1ENdTXX2i+c7Erbd9lK5l2KryhATBTgQvdthvvpX77s10A RvsHtmNxhVcWz7Y2NoBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCiLC-00BryL-23; Wed, 26 Jan 2022 13:28:02 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCiL8-00Brwr-HS for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 13:28:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZAq7lphUj4ZBbT0ttD3I4ZX17HecYYp/WQ0M7GbtbZg=; b=eFfUhCblrGf2E9eacHO/gPRV0+ zygiBNn0vwQXKqFymnCr9Q4qqkJ2UnBpzzmuIBdkSUViGWPMdfgBXbVWpq6hZELCjDLLtL5t8G17w /ZV8q0145pveahnMnBUbWiEUItdiWmGN7BuNEYfFqvMbF4wuWdvGPJaTrnGbLD3jblCcEj6q/ooH9 9+lkEKoXdzlvBjgZzs3Enc591b7BaAKvn/woO0JrL2OLOrV0zzmFRTtZTNzaU+f4sYOD5rLEKD/Im DZzdEClcdv/5wAZHjt36yv8j8tu4rHShQ5D+avIeu9MkMsoOZENA2n8ypE1TMEU7KLbfJK7s2kuXK GQrBBiIA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56888) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nCiKu-0003K2-6Q; Wed, 26 Jan 2022 13:27:44 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nCiKk-0004VA-3N; Wed, 26 Jan 2022 13:27:34 +0000 Date: Wed, 26 Jan 2022 13:27:34 +0000 From: "Russell King (Oracle)" To: Jisheng Zhang Cc: Andrew Lunn , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: don't stop RXC during LPI Message-ID: References: <20220123141245.1060-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_052758_604567_D3BFC96B X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 26, 2022 at 08:55:22PM +0800, Jisheng Zhang wrote: > On Sun, Jan 23, 2022 at 06:39:26PM +0100, Andrew Lunn wrote: > > > I think this is a common issue because the MAC needs phy's RXC for RX > > > logic. But it's better to let other stmmac users verify. The issue > > > can easily be reproduced on platforms with PHY_POLL external phy. > > > > What is the relevance of PHY polling here? Are you saying if the PHY > > is using interrupts you do not see this issue? > > I tried these two days, if the PHY is using interrupts, I can't > reproduce the issue. It looks a bit more complex. Any suggestions? I suppose it could be that there is a delay between the PHY reporting the link loss, raising an interrupt, which is then processed to disable the receive side, and the PHY going into LPI. The problem with polling is, well, it's polling, and at a one second rate - which probably is too long between the PHY noticing the loss of link and going into LPI. What this also probably means is that if interrupt latency is high enough, the same problem will occur. So maybe the EEE support to be a little more clever - so we only enable clock stop after the MAC driver has disabled the receive side. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel