From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70B97C433EF for ; Thu, 27 Jan 2022 06:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xX8ODkN+5kA+0Tz781i4FBWHQBg3CFU3TtizEaLMzts=; b=03WqV3q2JBStQ4 eSAWtYzFXhcZcvlYO6Qn1bebiwu5xQCZk/r0qCu+qt4348+G9AUfdJtyTe/u5LEsnE4oOSxXQnhrh M8YJIVWdz+4nqRl1KMfBDv5bFeiThVyyq7IKBGZpv0aKy5LoGDeCbAxr8VkCIIA0b22hb+nNdl0yS jgUvn/luG7nBqBoApLBsxW8CSvAtXN1FcH5fDsYwI+iRxmrkT7xLKDalfBJYIw4+YXI93I/Jtr8sR /tSkNSeVESCrSHkjbvQcjFoe5j4GsHCZGzIR215j44FGIMlfZyXu+e6DVp1mtc+5B46d4relfHJKI ciA1Ji8Y+xT7/pokw/Ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCyTQ-00EZ1c-RP; Thu, 27 Jan 2022 06:41:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCyTO-00EZ19-1I for linux-arm-kernel@lists.infradead.org; Thu, 27 Jan 2022 06:41:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 916236191D; Thu, 27 Jan 2022 06:41:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4D04C340E4; Thu, 27 Jan 2022 06:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643265693; bh=lzDQMFtkVMDafmie07laIN0lN6oP7zl0X8fnYkvNQFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U6QNH45/yC6nbNc8SibffGI61BMM8w/QOXzTGQEi3QmSBHDted7mupgwtgVH60A/+ b9eh21zctwW4cpE7G4XIaNtY0W6IuvDzBHiYublj5I3UvO6LFPZI0irImcZ22rLKiM 9ArZfYKMJPsg/cV4x8PRmLm2JXRxcZqwx9VThVBGDcG0C5c64yxMPeUi5zrGPTfdpO pUeEWZ1TiCajf8E+O1O0RLP2AwjQrwstN/1D3Nht67wNtF/v/8P03M6JZ8VUWyH+iZ hMNuq4NL4EGZab9n7oTHgds94vYhpYJox3ns+o0ZjTMJ/8R6J8d38L87YOoh9P5ELf f3cjTOQjSpJ0Q== Date: Wed, 26 Jan 2022 22:41:31 -0800 From: Eric Biggers To: Herbert Xu Cc: Nathan Huckleberry , linux-crypto@vger.kernel.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org, Paul Crowley , Sami Tolvanen Subject: Re: [RFC PATCH 3/7] crypto: hctr2 - Add HCTR2 support Message-ID: References: <20220125014422.80552-1-nhuck@google.com> <20220125014422.80552-4-nhuck@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_224134_145256_FE434283 X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 27, 2022 at 04:44:48PM +1100, Herbert Xu wrote: > On Thu, Jan 27, 2022 at 04:40:16PM +1100, Herbert Xu wrote: > > > > The question is is it performance-critical? Including it as a > > parameter would be worthwhile if it is. But if its cost is dwarfed > > by that of the accompanying operations then it might not be worth > > the complexity. > > It looks like this is similar to the situation in XTS where I chose > not to make it a full parameter during the skcipher conversion: > > commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 > Author: Herbert Xu > Date: Tue Nov 22 20:08:19 2016 +0800 > > crypto: xts - Convert to skcipher > > Cheers, Sure, that makes sense. Note that if the meaning of the first parameter to the template will differ (blockcipher_name vs. xctr_name), the full syntax probably should be supported by a separate template called "hctr2_base" rather than by "hctr2", to avoid having the meaning of the first parameter be context-dependent. This would be like gcm and gcm_base. So we'd have e.g.: hctr2(aes) hctr2_base(xctr-aes-aesni,polyval-pclmulqdqni) cra_name would be set to the former, while cra_driver_name would be set to the latter. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel