Re: [RFC PATCH 3/7] crypto: hctr2 - Add HCTR2 support

Herbert Xu
2022-01-27T06:31:19Z

On Wed, Jan 26, 2022 at 09:36:09PM -0800, Eric Biggers wrote:
>
> Well, the single block cipher isn't used just in ->setkey(), but also in
> ->encrypt() and ->decrypt() (not for the bulk of the data, but for 1 block).
> So allowing its implementation to be specified might make sense.

The question is is it performance-critical? Including it as a
parameter would be worthwhile if it is. But if its cost is dwarfed
by that of the accompanying operations then it might not be worth
the complexity.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt