From: Mark Rutland <mark.rutland@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, broonie@kernel.org,
jaxson.han@arm.com, robin.murphy@arm.com,
vladimir.murzin@arm.com, wei.chen@arm.com
Subject: Re: [bootwrapper PATCH v3 04/15] Add bit-field macros
Date: Thu, 27 Jan 2022 16:11:52 +0000 [thread overview]
Message-ID: <YfLESMj9DV7cnESq@FVFF77S0Q05N> (raw)
In-Reply-To: <20220126150312.56b6f536@donnerap.cambridge.arm.com>
On Wed, Jan 26, 2022 at 03:03:12PM +0000, Andre Przywara wrote:
> On Tue, 25 Jan 2022 15:00:46 +0000
> Mark Rutland <mark.rutland@arm.com> wrote:
>
> > Arm architectural documentation typically defines bit-fields as
> > `[msb,lsb]` and single-bit fields as `[bit]`. For clarity it would be
> > helpful if we could define fields in the same way.
> >
> > Add helpers so that we can do so, along with helper to extract/insert
> > bit-field values.
> >
> > There should be no functional change as a result of this patch.
> >
> > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
>
> I extracted the code and checked the examples, see below.
> > +/*
> > + * Define a contiguous mask of bits with `msb` as the most significant bit and
> > + * `lsb` as the least significant bit. The `msb` value must be greater than or
> > + * equal to `lsb`.
> > + *
> > + * For example:
> > + * - BITS(63, 63) is 0x8000000000000000
> > + * - BITS(63, 0) is 0xFFFFFFFFFFFFFFFF
> > + * - BITS(0, 0) is 0x0000000000000001
> > + * - BITS(49, 17) is 0x0001FFFFFFFE0000
>
> This should be 0x0003fffffffe0000, in real life and with the below
> implementation. So just a comment fix.
Good spot; I'll fix that up.
> The rest of the examples checked out, so with that fixed:
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Thanks!
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-27 16:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 15:00 [bootwrapper PATCH v3 00/15] Cleanups and improvements Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 01/15] aarch64: correct ZCR_EL3.LEN initialization Mark Rutland
2022-01-25 15:59 ` Mark Brown
2022-01-25 16:33 ` Mark Rutland
2022-01-25 17:44 ` Mark Brown
2022-01-27 16:08 ` Mark Rutland
2022-01-27 18:55 ` Mark Brown
2022-01-28 10:03 ` Mark Rutland
2022-01-28 12:41 ` Mark Brown
2022-01-26 15:02 ` Andre Przywara
2022-01-25 15:00 ` [bootwrapper PATCH v3 02/15] aarch64: correct SCTLR_EL1_KERNEL for AA32 kernels Mark Rutland
2022-01-26 15:03 ` Andre Przywara
2022-01-27 15:52 ` Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 03/15] Document entry requirements Mark Rutland
2022-01-26 15:03 ` Andre Przywara
2022-01-25 15:00 ` [bootwrapper PATCH v3 04/15] Add bit-field macros Mark Rutland
2022-01-26 15:03 ` Andre Przywara
2022-01-27 16:11 ` Mark Rutland [this message]
2022-01-25 15:00 ` [bootwrapper PATCH v3 05/15] aarch64: add system register accessors Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 06/15] aarch32: add coprocessor accessors Mark Rutland
2022-01-26 16:35 ` Andre Przywara
2022-01-25 15:00 ` [bootwrapper PATCH v3 07/15] aarch64: add mov_64 macro Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 08/15] aarch64: initialize SCTLR_ELx for the boot-wrapper Mark Rutland
2022-01-26 16:35 ` Andre Przywara
2022-01-25 15:00 ` [bootwrapper PATCH v3 09/15] Rework common init C code Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 10/15] Announce boot-wrapper mode / exception level Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 11/15] aarch64: move the bulk of EL3 initialization to C Mark Rutland
2022-01-26 16:36 ` Andre Przywara
2022-01-25 15:00 ` [bootwrapper PATCH v3 12/15] aarch32: move the bulk of Secure PL1 " Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 13/15] Announce locations of memory objects Mark Rutland
2022-01-25 15:00 ` [bootwrapper PATCH v3 14/15] Rework bootmethod initialization Mark Rutland
2022-01-26 16:36 ` Andre Przywara
2022-01-25 15:00 ` [bootwrapper PATCH v3 15/15] Unify start_el3 & start_no_el3 Mark Rutland
2022-01-28 15:50 ` [bootwrapper PATCH v3 00/15] Cleanups and improvements Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfLESMj9DV7cnESq@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=jaxson.han@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=vladimir.murzin@arm.com \
--cc=wei.chen@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox