From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D8ECC433F5 for ; Sat, 29 Jan 2022 06:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rKiq5FEMKI1AKy5CSLrryLuf596RVGDRmdF8/IPHItA=; b=goTWnW3yVhyPHpjUaEbP9FSir2 cOUd0yXC0KGrzPU3vaB/gtXp5scwdb1gP6SFqB3jQ/ZomOLkaijo84ImIBdBCDAZ1EtqjMR1OWqBz EYUlwgBvUX5MUotooeTWUuz3lgEgHgAIs7Wg/3fMgMyL3Ra9npvnPwAJaFG2c0OGaiacDYInRZBjW VNUn27RGAfQQuOcX3UESHHdb3EF6W9T4N2SVD5WQANxXZ/szU9iVRni7kyRnTGcAs9r2jJfhful3U HwInjCeNy90hBLZ2j4JLHxnczF84rGEiCNnD4JTFCXHC4fuCVd9yRXwTbCBUdxJKHVgue6JjBitSm ZOgdHHVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDhOA-0049pI-My; Sat, 29 Jan 2022 06:39:10 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDhO6-0049oI-Bu for linux-arm-kernel@lists.infradead.org; Sat, 29 Jan 2022 06:39:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=Dja6htFOHSLuxcH15iAURADMtQRz t7/bYoOfVYKbpvQ=; b=rSplA0hs6qX8Pvq2Bqyz4RIroxiIZfaJ9G+2DxyGcsQG 5s43dcMIZD7Zw9obz/YImxdMqMMZZf2yNhX01LY1+YEcFM5nyzy3NZ1eYUDAVHq3 +/MpAgOzIj/xpHhQ9UBmEK8PL8fHOe+swJ1wrJEpmSWzCtnLWFGe9WHQwnJZ8fA= Received: (qmail 511667 invoked from network); 29 Jan 2022 07:39:00 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 29 Jan 2022 07:39:00 +0100 X-UD-Smtp-Session: l3s3148p1@sh9MzrLWDLO8ahEL Date: Sat, 29 Jan 2022 07:38:56 +0100 From: Wolfram Sang To: Krzysztof Adamski Cc: Catalin Marinas , Will Deacon , Mark Rutland , Peter Collingbourne , Guenter Roeck , Alexander Sverdlin , Matija Glavinic-Pecotic , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: move efi_reboot to restart handler Message-ID: Mail-Followup-To: Wolfram Sang , Krzysztof Adamski , Catalin Marinas , Will Deacon , Mark Rutland , Peter Collingbourne , Guenter Roeck , Alexander Sverdlin , Matija Glavinic-Pecotic , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_223907_042400_9558AEF9 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9180463844219301024==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9180463844219301024== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GKPNAMI1pCuG617p" Content-Disposition: inline --GKPNAMI1pCuG617p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Krzysztof, > I would use something like 250, or even 254, just to indicate that we > know that most certainly nothing should be run before efi_reboot(), but > still allow those silly people like me, to do what they want in their > system, without the need to run the custom kernel. I think we could even > add a proper comment, so it woudld become something like: >=20 > /** > * If you are running UEFI based system, you most certainly should let > * efi_reboot() do a reset for you. If you think you know better, we > * leave you a window of opportunity here by not using maximal priorty > * here. > */ > .priority =3D 250, For your patchset, this seems good enough for me because it is decoupled =66rom PSCI now. I still think a set of defines should be collected in linux/reboot.h so they can be used in reboot handlers. This is a different patch series, though. > What is the downside of doing that? That we will run through atomic > notfier chain instead of calling efi_reboot directly? Sure this is > slightly more complicated but it works on all our platforms and is > battle proven and we don't worry about that there. And the upside is > that we give people possibility to use their beloved mechanism if they > really like to. Because flexibility is a good thing. I agree with the upside having more value than the downside. Happy hacking, Wolfram --GKPNAMI1pCuG617p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmH04PwACgkQFA3kzBSg KbbUiw/+MH+ukDJlxKm1Hgf2mziYmP4CxKyEoAv+6iDgOr/7USa/rOtBKIjFlLpw JHHCSkbtLI8HQdxRy45T44wP5CZ6eMFnF2bAN2/pvSDVViz3DUqeAMQZ3C1GxUys WJ4Gx+Xxyyk9ZXApkN+X42NtbIJWxs2wyGmDTq6lGkOjZ5VpdjGdHVv1i8YUMaTN B7dS2o7c3Y5IlK/7BCPqrpwqdoNDVJCaaFy1xczFBa9iU3PYRDNczfOR+CItscE2 JaRzIbQF10a5eM+j84OWYNK6K4qOBsad64yz+6xEpmVGh+XU9E5hVdPTbSY9lGc9 HjtvIVmeSyz59JSgrga6iItzTPHIZOcNOeD8foe6YRgVZaCzE/jWM3bh4fkKj6+I 5YrOuYFdg1QH3B6a6WljP+x85mfnVCbJ52mzYEyrJ4HGg/GIbWu81ySVMM7TX9zo Dw652+S9iAw8C4U7LH+2diE4wh/9qQgqPqEaQ8mDlyJgqBxgzTyy0tO2GJcBYcPJ IHbsc1pWCFlNN6bFtbfcJUU0ZgCBB9sWO+wsDg2Dt2akQbHOFg7OFwdqhPgKmMGy nOl3Jaa683bdY1v+zzUHq3mJMNhVnEqEM5N1AlSF5dMiowRyV4/02dthJxPCENX7 tXTqqFTFH1RDbBXtHGdrJINMhiu4Pz+B9r2cY2fFQEzOZmTe1uY= =fL8U -----END PGP SIGNATURE----- --GKPNAMI1pCuG617p-- --===============9180463844219301024== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9180463844219301024==--