From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B02BC433F5 for ; Tue, 1 Feb 2022 18:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LdDsRvNFI4GXq3rro69OP5Chx+jG/VS3vM46LSae8+k=; b=qF7A4Tzu71OC18ZOCvkh5ghzis kdrQmqAg6ku4y9AH7Wzx0Zidt34nCQVrmUt9cOpP7rjvBTd2xKYaeO4lZxRmPnZcUHq4WWJoSNFR7 aS250X+Sm8MTXLwBrPwOO4xXdrPgnlnVYV8R/v2u2l4ldwrQJoVfSUnVZPdQhzNnoYg5VsBoN6M5b Vbaj4bgcpZWZeswVbMNJxK/a7yvmytwlTZAbT4TPhRW6b4HHqFEyDqUNSDvBnDA3sdJQURYco4gN+ zdHgHW+hhvM0mZBCfozs8QDaKhZgDdVDSWiumq8F/bBqEE1oL0zOg5VHGbo2k85L4aaAhiA1ZyImo kC26hbgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nExo3-00DKWD-KO; Tue, 01 Feb 2022 18:23:07 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nExo0-00DKVi-E7 for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 18:23:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF04561422; Tue, 1 Feb 2022 18:23:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6BDDC340EB; Tue, 1 Feb 2022 18:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643739783; bh=zdY/NDZZdeUf633r08w22HnDs7HFxxzE01fiKsuLD6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IuAiDnBpNJA8jayOzivCAmV3ziBGyH3atBmUkZiKRbGtNocD/xsUJsLE9pDJYsib9 mh3HoDmjP69I9gEu+3Ksp+5NDO1yNJ2kMD8IkrNA07Jm8nUalAl8omDv2ZOSZRcqM4 7V7qBQVM+2vILdBqY09JdVY8uh7qSJBgD1K1Wh7e3gUmDp9ey+uGtXDF46O726kOs2 bUAIh1eS3ljjRZDAPUybVCNwLT8ZMkG0/JhmbBcirKO1A6S5oICET0pq+0UY65y4AC 4VUA8TwZPO6jrELeWXPXxj/Q70yVzsaEY5ZvZIiqHYrb70hpvwB/AgTMfWdQAsg5os oNQbm1MAmR6pw== Date: Tue, 1 Feb 2022 18:22:59 +0000 From: Mark Brown To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org Subject: Re: [boot-wrapper PATCH 2/2] aarch64: Enable use of SME by EL2 and below Message-ID: References: <20220201172132.2399026-1-broonie@kernel.org> <20220201172132.2399026-2-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Cookie: All's well that ends. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_102304_538708_01531E10 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2250040515917112046==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2250040515917112046== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HRXEkWMZ3hLyJeFc" Content-Disposition: inline --HRXEkWMZ3hLyJeFc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 01, 2022 at 06:16:58PM +0000, Mark Rutland wrote: > On Tue, Feb 01, 2022 at 05:21:32PM +0000, broonie@kernel.org wrote: > > +#define ID_AA64SMFR0_EL1 s3_0_c0_c4_5 > > +#define ID_AA64SMFR0_EL1_FA64 (1UL << 63) > For consistency with the other ID fields, I'm going to make this: > #define ID_AA64SMFR0_EL1_FA64 BIT(63) > In future I'd like to split the remaining definitions using shifted bits into > separate _ and __ definitions (or > something of that rought shape) so that field boundaries are always explicit, > but those can stay as-is for now. Sure. I was quite confused about the idioms for the use of BIT() in this header since it's used for for example both ID registers and SCR but things like the various SPSR and CPTR defines use shifts, it'd probably be good to just use BIT() throughout. --HRXEkWMZ3hLyJeFc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmH5eoIACgkQJNaLcl1U h9CbaAf7BZ+bb6W3I/jl91DswmxJ7Dx4qpFwsuPBDcN91Cx6pHkhSGX8iuxs9FGQ 3NARPjovqQgiFxWBTTj0zQVP8r1VBFmTm1muF8VqhrOdhRSLro/47D4eWD0Nm8Rg jsiXIp8ohxSPsERSQ5FafdK5XfmyKqhiyqAkbyyHwMeMHaMMeVh/QbegYnhLf22q oqjvFNy+1tEaRR5W2yLC0Xxeo5LS3PpnVuDkQfiRUiKhwuLQFvcvDaLRDlDHdnNM dfKLKZG0Pd7I5xGa9Nz/gKRv+EPKZcinfPwGeHn7y2c+2kelvALAddbtqqXtOY2g GlNOFh5UhW6/pPstbcITSTCmcrhaAQ== =XxTo -----END PGP SIGNATURE----- --HRXEkWMZ3hLyJeFc-- --===============2250040515917112046== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2250040515917112046==--