* [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
@ 2022-01-29 17:53 ` Krzysztof Kozlowski
2022-01-30 7:34 ` Alim Akhtar
2022-01-31 9:02 ` (subset) " Krzysztof Kozlowski
2022-01-29 17:53 ` [PATCH 3/5] mfd: exynos-lpass: Drop unneeded syscon.h include Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 2 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-29 17:53 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Greg Kroah-Hartman, Sylwester Nawrocki, Marek Szyprowski,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
Exynos5433 LPASS audio node does not use syscon phandle since commit
addebf1588ab ("mfd: exynos-lpass: Remove pad retention control"). It
was also dropped from bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index b4cde77e02d3..661567d2dd7a 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1885,7 +1885,6 @@ audio-subsystem@11400000 {
reg = <0x11400000 0x100>, <0x11500000 0x08>;
clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
clock-names = "sfr0_ctrl";
- samsung,pmu-syscon = <&pmu_system_controller>;
power-domains = <&pd_aud>;
#address-cells = <1>;
#size-cells = <1>;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* RE: [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS
2022-01-29 17:53 ` [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS Krzysztof Kozlowski
@ 2022-01-30 7:34 ` Alim Akhtar
2022-01-31 9:02 ` (subset) " Krzysztof Kozlowski
1 sibling, 0 replies; 16+ messages in thread
From: Alim Akhtar @ 2022-01-30 7:34 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Greg Kroah-Hartman',
'Sylwester Nawrocki', 'Marek Szyprowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Saturday, January 29, 2022 11:23 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Sylwester Nawrocki
><s.nawrocki@samsung.com>; Marek Szyprowski
><m.szyprowski@samsung.com>; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org
>Subject: [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in
>Exynos5433 LPASS
>
>Exynos5433 LPASS audio node does not use syscon phandle since commit
>addebf1588ab ("mfd: exynos-lpass: Remove pad retention control"). It was
>also dropped from bindings.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index b4cde77e02d3..661567d2dd7a 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1885,7 +1885,6 @@ audio-subsystem@11400000 {
> reg = <0x11400000 0x100>, <0x11500000 0x08>;
> clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> clock-names = "sfr0_ctrl";
>- samsung,pmu-syscon = <&pmu_system_controller>;
> power-domains = <&pd_aud>;
> #address-cells = <1>;
> #size-cells = <1>;
>--
>2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: (subset) [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS
2022-01-29 17:53 ` [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS Krzysztof Kozlowski
2022-01-30 7:34 ` Alim Akhtar
@ 2022-01-31 9:02 ` Krzysztof Kozlowski
1 sibling, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-31 9:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-kernel, linux-arm-kernel,
Marek Szyprowski, Greg Kroah-Hartman, Alim Akhtar,
Sylwester Nawrocki, linux-samsung-soc, Rob Herring, devicetree,
linux-serial, Lee Jones
On Sat, 29 Jan 2022 18:53:29 +0100, Krzysztof Kozlowski wrote:
> Exynos5433 LPASS audio node does not use syscon phandle since commit
> addebf1588ab ("mfd: exynos-lpass: Remove pad retention control"). It
> was also dropped from bindings.
>
>
Applied, thanks!
[2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS
commit: f1afd24c3f532defa77c2d6e069b82dc7d6a9129
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 3/5] mfd: exynos-lpass: Drop unneeded syscon.h include
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
2022-01-29 17:53 ` [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS Krzysztof Kozlowski
@ 2022-01-29 17:53 ` Krzysztof Kozlowski
2022-01-30 7:36 ` Alim Akhtar
2022-01-29 17:53 ` [PATCH 4/5] dt-bindings: mfd: samsung, exynos5433-lpass: Convert to dtschema Krzysztof Kozlowski
` (4 subsequent siblings)
6 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-29 17:53 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Greg Kroah-Hartman, Sylwester Nawrocki, Marek Szyprowski,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
syscon regmap is not used since commit addebf1588ab ("mfd: exynos-lpass:
Remove pad retention control").
Fixes: addebf1588ab ("mfd: exynos-lpass: Remove pad retention control")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/mfd/exynos-lpass.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
index 99bd0e73c19c..166cd21088cd 100644
--- a/drivers/mfd/exynos-lpass.c
+++ b/drivers/mfd/exynos-lpass.c
@@ -15,7 +15,6 @@
#include <linux/delay.h>
#include <linux/io.h>
#include <linux/module.h>
-#include <linux/mfd/syscon.h>
#include <linux/of.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* RE: [PATCH 3/5] mfd: exynos-lpass: Drop unneeded syscon.h include
2022-01-29 17:53 ` [PATCH 3/5] mfd: exynos-lpass: Drop unneeded syscon.h include Krzysztof Kozlowski
@ 2022-01-30 7:36 ` Alim Akhtar
0 siblings, 0 replies; 16+ messages in thread
From: Alim Akhtar @ 2022-01-30 7:36 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Greg Kroah-Hartman',
'Sylwester Nawrocki', 'Marek Szyprowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Saturday, January 29, 2022 11:24 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Sylwester Nawrocki
><s.nawrocki@samsung.com>; Marek Szyprowski
><m.szyprowski@samsung.com>; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org
>Subject: [PATCH 3/5] mfd: exynos-lpass: Drop unneeded syscon.h include
>
>syscon regmap is not used since commit addebf1588ab ("mfd: exynos-lpass:
>Remove pad retention control").
>
>Fixes: addebf1588ab ("mfd: exynos-lpass: Remove pad retention control")
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/mfd/exynos-lpass.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c index
>99bd0e73c19c..166cd21088cd 100644
>--- a/drivers/mfd/exynos-lpass.c
>+++ b/drivers/mfd/exynos-lpass.c
>@@ -15,7 +15,6 @@
> #include <linux/delay.h>
> #include <linux/io.h>
> #include <linux/module.h>
>-#include <linux/mfd/syscon.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
>--
>2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 4/5] dt-bindings: mfd: samsung, exynos5433-lpass: Convert to dtschema
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
2022-01-29 17:53 ` [PATCH 2/5] arm64: dts: exynos: drop unneeded syscon phandle in Exynos5433 LPASS Krzysztof Kozlowski
2022-01-29 17:53 ` [PATCH 3/5] mfd: exynos-lpass: Drop unneeded syscon.h include Krzysztof Kozlowski
@ 2022-01-29 17:53 ` Krzysztof Kozlowski
2022-01-30 0:22 ` Rob Herring
2022-02-01 17:38 ` Rob Herring
2022-01-29 17:53 ` [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible Krzysztof Kozlowski
` (3 subsequent siblings)
6 siblings, 2 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-29 17:53 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Greg Kroah-Hartman, Sylwester Nawrocki, Marek Szyprowski,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
Convert the Exynos5433 LPASS bindings to DT schema format.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
.../bindings/mfd/samsung,exynos5433-lpass.txt | 72 -----------
.../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++
2 files changed, 119 insertions(+), 72 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
deleted file mode 100644
index 30ea27c3936d..000000000000
--- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
+++ /dev/null
@@ -1,72 +0,0 @@
-Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
-
-Required properties:
-
- - compatible : "samsung,exynos5433-lpass"
- - reg : should contain the LPASS top SFR region location
- and size
- - clock-names : should contain following required clocks: "sfr0_ctrl"
- - clocks : should contain clock specifiers of all clocks, which
- input names have been specified in clock-names
- property, in same order.
- - #address-cells : should be 1
- - #size-cells : should be 1
- - ranges : must be present
-
-Each IP block of the Low Power Audio Subsystem should be specified as
-an optional sub-node. For "samsung,exynos5433-lpass" compatible this includes:
-UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, VIC, WDT 0...1 devices.
-
-Bindings of the sub-nodes are described in:
- ../serial/samsung_uart.yaml
- ../sound/samsung-i2s.txt
- ../dma/arm-pl330.txt
-
-
-Example:
-
-audio-subsystem {
- compatible = "samsung,exynos5433-lpass";
- reg = <0x11400000 0x100>, <0x11500000 0x08>;
- clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
- clock-names = "sfr0_ctrl";
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- adma: adma@11420000 {
- compatible = "arm,pl330", "arm,primecell";
- reg = <0x11420000 0x1000>;
- interrupts = <0 73 0>;
- clocks = <&cmu_aud CLK_ACLK_DMAC>;
- clock-names = "apb_pclk";
- #dma-cells = <1>;
- #dma-channels = <8>;
- #dma-requests = <32>;
- };
-
- i2s0: i2s0@11440000 {
- compatible = "samsung,exynos7-i2s";
- reg = <0x11440000 0x100>;
- dmas = <&adma 0 &adma 2>;
- dma-names = "tx", "rx";
- interrupts = <0 70 0>;
- clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
- <&cmu_aud CLK_SCLK_AUD_I2S>,
- <&cmu_aud CLK_SCLK_I2S_BCLK>;
- clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
- pinctrl-names = "default";
- pinctrl-0 = <&i2s0_bus>;
- };
-
- serial_3: serial@11460000 {
- compatible = "samsung,exynos5433-uart";
- reg = <0x11460000 0x100>;
- interrupts = <0 67 0>;
- clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
- <&cmu_aud CLK_SCLK_AUD_UART>;
- clock-names = "uart", "clk_uart_baud0";
- pinctrl-names = "default";
- pinctrl-0 = <&uart_aud_bus>;
- };
- };
diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
new file mode 100644
index 000000000000..96ef6113c8bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/samsung,exynos5433-lpass.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
+
+maintainers:
+ - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+ - Sylwester Nawrocki <s.nawrocki@samsung.com>
+
+properties:
+ compatible:
+ const: samsung,exynos5433-lpass
+
+ '#address-cells':
+ const: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: sfr0_ctrl
+
+ power-domains:
+ maxItems: 1
+
+ ranges: true
+
+ reg:
+ minItems: 2
+ maxItems: 2
+
+ '#size-cells':
+ const: 1
+
+patternProperties:
+ "^dma-controller@[0-9a-f]+$":
+ $ref: /schemas/dma/arm,pl330.yaml
+
+ "^i2s@[0-9a-f]+$":
+ $ref: /schemas/sound/samsung-i2s.yaml
+
+ "^serial@[0-9a-f]+$":
+ $ref: /schemas/serial/samsung_uart.yaml
+
+required:
+ - compatible
+ - '#address-cells'
+ - clocks
+ - clock-names
+ - ranges
+ - reg
+ - '#size-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/exynos5433.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ audio-subsystem@11400000 {
+ compatible = "samsung,exynos5433-lpass";
+ reg = <0x11400000 0x100>, <0x11500000 0x08>;
+ clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
+ clock-names = "sfr0_ctrl";
+ power-domains = <&pd_aud>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ dma-controller@11420000 {
+ compatible = "arm,pl330", "arm,primecell";
+ reg = <0x11420000 0x1000>;
+ interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cmu_aud CLK_ACLK_DMAC>;
+ clock-names = "apb_pclk";
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
+ power-domains = <&pd_aud>;
+ };
+
+ i2s@11440000 {
+ compatible = "samsung,exynos7-i2s";
+ reg = <0x11440000 0x100>;
+ dmas = <&adma 0>, <&adma 2>;
+ dma-names = "tx", "rx";
+ interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
+ <&cmu_aud CLK_SCLK_AUD_I2S>,
+ <&cmu_aud CLK_SCLK_I2S_BCLK>;
+ clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
+ #clock-cells = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2s0_bus>;
+ power-domains = <&pd_aud>;
+ #sound-dai-cells = <1>;
+ status = "disabled";
+ };
+
+ serial@11460000 {
+ compatible = "samsung,exynos5433-uart";
+ reg = <0x11460000 0x100>;
+ interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
+ <&cmu_aud CLK_SCLK_AUD_UART>;
+ clock-names = "uart", "clk_uart_baud0";
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart_aud_bus>;
+ power-domains = <&pd_aud>;
+ status = "disabled";
+ };
+ };
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 4/5] dt-bindings: mfd: samsung, exynos5433-lpass: Convert to dtschema
2022-01-29 17:53 ` [PATCH 4/5] dt-bindings: mfd: samsung, exynos5433-lpass: Convert to dtschema Krzysztof Kozlowski
@ 2022-01-30 0:22 ` Rob Herring
2022-01-31 8:49 ` [PATCH 4/5] dt-bindings: mfd: samsung,exynos5433-lpass: " Krzysztof Kozlowski
2022-02-01 17:38 ` Rob Herring
1 sibling, 1 reply; 16+ messages in thread
From: Rob Herring @ 2022-01-30 0:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-samsung-soc, Rob Herring, Marek Szyprowski, devicetree,
linux-kernel, linux-arm-kernel, Sylwester Nawrocki,
Greg Kroah-Hartman, linux-serial, Alim Akhtar, Lee Jones
On Sat, 29 Jan 2022 18:53:31 +0100, Krzysztof Kozlowski wrote:
> Convert the Exynos5433 LPASS bindings to DT schema format.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 -----------
> .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++
> 2 files changed, 119 insertions(+), 72 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml: audio-subsystem@11400000: serial@11460000:compatible:0: 'samsung,exynos5433-uart' is not one of ['apple,s5l-uart', 'samsung,s3c2410-uart', 'samsung,s3c2412-uart', 'samsung,s3c2440-uart', 'samsung,s3c6400-uart', 'samsung,s5pv210-uart', 'samsung,exynos4210-uart', 'samsung,exynos850-uart']
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml:0:0: /example-0/audio-subsystem@11400000/serial@11460000: failed to match any schema with compatible: ['samsung,exynos5433-uart']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1586234
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/5] dt-bindings: mfd: samsung,exynos5433-lpass: Convert to dtschema
2022-01-30 0:22 ` Rob Herring
@ 2022-01-31 8:49 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-31 8:49 UTC (permalink / raw)
To: Rob Herring
Cc: linux-samsung-soc, Rob Herring, Marek Szyprowski, devicetree,
linux-kernel, linux-arm-kernel, Sylwester Nawrocki,
Greg Kroah-Hartman, linux-serial, Alim Akhtar, Lee Jones
On 30/01/2022 01:22, Rob Herring wrote:
> On Sat, 29 Jan 2022 18:53:31 +0100, Krzysztof Kozlowski wrote:
>> Convert the Exynos5433 LPASS bindings to DT schema format.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>> .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 -----------
>> .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++
>> 2 files changed, 119 insertions(+), 72 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
>> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml: audio-subsystem@11400000: serial@11460000:compatible:0: 'samsung,exynos5433-uart' is not one of ['apple,s5l-uart', 'samsung,s3c2410-uart', 'samsung,s3c2412-uart', 'samsung,s3c2440-uart', 'samsung,s3c6400-uart', 'samsung,s5pv210-uart', 'samsung,exynos4210-uart', 'samsung,exynos850-uart']
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
> Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.example.dt.yaml:0:0: /example-0/audio-subsystem@11400000/serial@11460000: failed to match any schema with compatible: ['samsung,exynos5433-uart']
>
This is false positive or rather my patch-ordering issue. I fixed it up
in patch 5/5 of this series.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/5] dt-bindings: mfd: samsung,exynos5433-lpass: Convert to dtschema
2022-01-29 17:53 ` [PATCH 4/5] dt-bindings: mfd: samsung, exynos5433-lpass: Convert to dtschema Krzysztof Kozlowski
2022-01-30 0:22 ` Rob Herring
@ 2022-02-01 17:38 ` Rob Herring
1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring @ 2022-02-01 17:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Alim Akhtar, Greg Kroah-Hartman, Sylwester Nawrocki,
Marek Szyprowski, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel, linux-serial
On Sat, Jan 29, 2022 at 06:53:31PM +0100, Krzysztof Kozlowski wrote:
> Convert the Exynos5433 LPASS bindings to DT schema format.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 -----------
> .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++
> 2 files changed, 119 insertions(+), 72 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> deleted file mode 100644
> index 30ea27c3936d..000000000000
> --- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> +++ /dev/null
> @@ -1,72 +0,0 @@
> -Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
> -
> -Required properties:
> -
> - - compatible : "samsung,exynos5433-lpass"
> - - reg : should contain the LPASS top SFR region location
> - and size
> - - clock-names : should contain following required clocks: "sfr0_ctrl"
> - - clocks : should contain clock specifiers of all clocks, which
> - input names have been specified in clock-names
> - property, in same order.
> - - #address-cells : should be 1
> - - #size-cells : should be 1
> - - ranges : must be present
> -
> -Each IP block of the Low Power Audio Subsystem should be specified as
> -an optional sub-node. For "samsung,exynos5433-lpass" compatible this includes:
> -UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, VIC, WDT 0...1 devices.
> -
> -Bindings of the sub-nodes are described in:
> - ../serial/samsung_uart.yaml
> - ../sound/samsung-i2s.txt
> - ../dma/arm-pl330.txt
> -
> -
> -Example:
> -
> -audio-subsystem {
> - compatible = "samsung,exynos5433-lpass";
> - reg = <0x11400000 0x100>, <0x11500000 0x08>;
> - clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> - clock-names = "sfr0_ctrl";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges;
> -
> - adma: adma@11420000 {
> - compatible = "arm,pl330", "arm,primecell";
> - reg = <0x11420000 0x1000>;
> - interrupts = <0 73 0>;
> - clocks = <&cmu_aud CLK_ACLK_DMAC>;
> - clock-names = "apb_pclk";
> - #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> - };
> -
> - i2s0: i2s0@11440000 {
> - compatible = "samsung,exynos7-i2s";
> - reg = <0x11440000 0x100>;
> - dmas = <&adma 0 &adma 2>;
> - dma-names = "tx", "rx";
> - interrupts = <0 70 0>;
> - clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
> - <&cmu_aud CLK_SCLK_AUD_I2S>,
> - <&cmu_aud CLK_SCLK_I2S_BCLK>;
> - clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> - pinctrl-names = "default";
> - pinctrl-0 = <&i2s0_bus>;
> - };
> -
> - serial_3: serial@11460000 {
> - compatible = "samsung,exynos5433-uart";
> - reg = <0x11460000 0x100>;
> - interrupts = <0 67 0>;
> - clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
> - <&cmu_aud CLK_SCLK_AUD_UART>;
> - clock-names = "uart", "clk_uart_baud0";
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart_aud_bus>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
> new file mode 100644
> index 000000000000..96ef6113c8bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/samsung,exynos5433-lpass.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> + - Sylwester Nawrocki <s.nawrocki@samsung.com>
> +
> +properties:
> + compatible:
> + const: samsung,exynos5433-lpass
> +
> + '#address-cells':
> + const: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: sfr0_ctrl
> +
> + power-domains:
> + maxItems: 1
> +
> + ranges: true
> +
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + '#size-cells':
> + const: 1
> +
> +patternProperties:
> + "^dma-controller@[0-9a-f]+$":
> + $ref: /schemas/dma/arm,pl330.yaml
> +
> + "^i2s@[0-9a-f]+$":
> + $ref: /schemas/sound/samsung-i2s.yaml
> +
> + "^serial@[0-9a-f]+$":
> + $ref: /schemas/serial/samsung_uart.yaml
> +
> +required:
> + - compatible
> + - '#address-cells'
> + - clocks
> + - clock-names
> + - ranges
> + - reg
> + - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/exynos5433.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + audio-subsystem@11400000 {
> + compatible = "samsung,exynos5433-lpass";
> + reg = <0x11400000 0x100>, <0x11500000 0x08>;
> + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> + clock-names = "sfr0_ctrl";
> + power-domains = <&pd_aud>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + dma-controller@11420000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x11420000 0x1000>;
> + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu_aud CLK_ACLK_DMAC>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + #dma-channels = <8>;
> + #dma-requests = <32>;
> + power-domains = <&pd_aud>;
> + };
> +
> + i2s@11440000 {
> + compatible = "samsung,exynos7-i2s";
> + reg = <0x11440000 0x100>;
> + dmas = <&adma 0>, <&adma 2>;
> + dma-names = "tx", "rx";
> + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
> + <&cmu_aud CLK_SCLK_AUD_I2S>,
> + <&cmu_aud CLK_SCLK_I2S_BCLK>;
> + clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> + #clock-cells = <1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s0_bus>;
> + power-domains = <&pd_aud>;
> + #sound-dai-cells = <1>;
> + status = "disabled";
Drop 'status'.
> + };
> +
> + serial@11460000 {
> + compatible = "samsung,exynos5433-uart";
> + reg = <0x11460000 0x100>;
> + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
> + <&cmu_aud CLK_SCLK_AUD_UART>;
> + clock-names = "uart", "clk_uart_baud0";
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart_aud_bus>;
> + power-domains = <&pd_aud>;
> + status = "disabled";
Ditto.
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-01-29 17:53 ` [PATCH 4/5] dt-bindings: mfd: samsung, exynos5433-lpass: Convert to dtschema Krzysztof Kozlowski
@ 2022-01-29 17:53 ` Krzysztof Kozlowski
2022-01-30 7:39 ` Alim Akhtar
2022-02-01 17:36 ` Rob Herring
2022-01-30 7:17 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Alim Akhtar
` (2 subsequent siblings)
6 siblings, 2 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-29 17:53 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Greg Kroah-Hartman, Sylwester Nawrocki, Marek Szyprowski,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
Document the Exynos5433 UART compatible, supported since commit
31ec77aca72e ("serial: samsung: Add the support for Exynos5433 SoC").
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 2940afb874b3..6aceba4a5f79 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -26,6 +26,7 @@ properties:
- samsung,s3c6400-uart
- samsung,s5pv210-uart
- samsung,exynos4210-uart
+ - samsung,exynos5433-uart
- samsung,exynos850-uart
reg:
@@ -111,6 +112,7 @@ allOf:
enum:
- apple,s5l-uart
- samsung,exynos4210-uart
+ - samsung,exynos5433-uart
then:
properties:
clocks:
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* RE: [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible
2022-01-29 17:53 ` [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible Krzysztof Kozlowski
@ 2022-01-30 7:39 ` Alim Akhtar
2022-02-01 17:36 ` Rob Herring
1 sibling, 0 replies; 16+ messages in thread
From: Alim Akhtar @ 2022-01-30 7:39 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Greg Kroah-Hartman',
'Sylwester Nawrocki', 'Marek Szyprowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Saturday, January 29, 2022 11:24 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Sylwester Nawrocki
><s.nawrocki@samsung.com>; Marek Szyprowski
><m.szyprowski@samsung.com>; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org
>Subject: [PATCH 5/5] dt-bindings: serial: samsung_uart: Document
>Exynos5433 compatible
>
>Document the Exynos5433 UART compatible, supported since commit
>31ec77aca72e ("serial: samsung: Add the support for Exynos5433 SoC").
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Thanks
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>index 2940afb874b3..6aceba4a5f79 100644
>--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>@@ -26,6 +26,7 @@ properties:
> - samsung,s3c6400-uart
> - samsung,s5pv210-uart
> - samsung,exynos4210-uart
>+ - samsung,exynos5433-uart
> - samsung,exynos850-uart
>
> reg:
>@@ -111,6 +112,7 @@ allOf:
> enum:
> - apple,s5l-uart
> - samsung,exynos4210-uart
>+ - samsung,exynos5433-uart
> then:
> properties:
> clocks:
>--
>2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible
2022-01-29 17:53 ` [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible Krzysztof Kozlowski
2022-01-30 7:39 ` Alim Akhtar
@ 2022-02-01 17:36 ` Rob Herring
1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring @ 2022-02-01 17:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Alim Akhtar, Greg Kroah-Hartman, Sylwester Nawrocki,
Marek Szyprowski, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel, linux-serial
On Sat, Jan 29, 2022 at 06:53:32PM +0100, Krzysztof Kozlowski wrote:
> Document the Exynos5433 UART compatible, supported since commit
> 31ec77aca72e ("serial: samsung: Add the support for Exynos5433 SoC").
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-01-29 17:53 ` [PATCH 5/5] dt-bindings: serial: samsung_uart: Document Exynos5433 compatible Krzysztof Kozlowski
@ 2022-01-30 7:17 ` Alim Akhtar
2022-01-30 7:20 ` Alim Akhtar
2022-01-31 9:02 ` (subset) " Krzysztof Kozlowski
6 siblings, 0 replies; 16+ messages in thread
From: Alim Akhtar @ 2022-01-30 7:17 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Greg Kroah-Hartman',
'Sylwester Nawrocki', 'Marek Szyprowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
Hi Krzysztof
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Saturday, January 29, 2022 11:23 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Sylwester Nawrocki
><s.nawrocki@samsung.com>; Marek Szyprowski
><m.szyprowski@samsung.com>; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org
>Subject: [PATCH 1/5] arm64: dts: exynos: align pl330 node name with
>dtschema
>
>Fixes dtbs_check warnings like:
>
> pdma@15610000: $nodename:0: 'pdma@15610000' does not match '^dma-
>controller(@.*)?$'
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@smasung.com>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index bfe4ed8a23d6..b4cde77e02d3 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1858,7 +1858,7 @@ mshc_2: mshc@15560000 {
> status = "disabled";
> };
>
>- pdma0: pdma@15610000 {
>+ pdma0: dma-controller@15610000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x15610000 0x1000>;
> interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
>@@ -1869,7 +1869,7 @@ pdma0: pdma@15610000 {
> #dma-requests = <32>;
> };
>
>- pdma1: pdma@15600000 {
>+ pdma1: dma-controller@15600000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x15600000 0x1000>;
> interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
>@@ -1891,7 +1891,7 @@ audio-subsystem@11400000 {
> #size-cells = <1>;
> ranges;
>
>- adma: adma@11420000 {
>+ adma: dma-controller@11420000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x11420000 0x1000>;
> interrupts = <GIC_SPI 73
>IRQ_TYPE_LEVEL_HIGH>; diff --git
>a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>index 960823b8247a..3364b09c3158 100644
>--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>@@ -142,7 +142,7 @@ gic: interrupt-controller@11001000 {
> <0x11006000 0x2000>;
> };
>
>- pdma0: pdma@10e10000 {
>+ pdma0: dma-controller@10e10000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x10E10000 0x1000>;
> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
>@@ -153,7 +153,7 @@ pdma0: pdma@10e10000 {
> #dma-requests = <32>;
> };
>
>- pdma1: pdma@10eb0000 {
>+ pdma1: dma-controller@10eb0000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x10EB0000 0x1000>;
> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
>--
>2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* RE: [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
` (4 preceding siblings ...)
2022-01-30 7:17 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Alim Akhtar
@ 2022-01-30 7:20 ` Alim Akhtar
2022-01-31 9:02 ` (subset) " Krzysztof Kozlowski
6 siblings, 0 replies; 16+ messages in thread
From: Alim Akhtar @ 2022-01-30 7:20 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Lee Jones',
'Rob Herring', 'Greg Kroah-Hartman',
'Sylwester Nawrocki', 'Marek Szyprowski',
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
linux-serial
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Saturday, January 29, 2022 11:23 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Sylwester Nawrocki
><s.nawrocki@samsung.com>; Marek Szyprowski
><m.szyprowski@samsung.com>; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-serial@vger.kernel.org
>Subject: [PATCH 1/5] arm64: dts: exynos: align pl330 node name with
>dtschema
>
>Fixes dtbs_check warnings like:
>
> pdma@15610000: $nodename:0: 'pdma@15610000' does not match '^dma-
>controller(@.*)?$'
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Thanks
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index bfe4ed8a23d6..b4cde77e02d3 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -1858,7 +1858,7 @@ mshc_2: mshc@15560000 {
> status = "disabled";
> };
>
>- pdma0: pdma@15610000 {
>+ pdma0: dma-controller@15610000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x15610000 0x1000>;
> interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
>@@ -1869,7 +1869,7 @@ pdma0: pdma@15610000 {
> #dma-requests = <32>;
> };
>
>- pdma1: pdma@15600000 {
>+ pdma1: dma-controller@15600000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x15600000 0x1000>;
> interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
>@@ -1891,7 +1891,7 @@ audio-subsystem@11400000 {
> #size-cells = <1>;
> ranges;
>
>- adma: adma@11420000 {
>+ adma: dma-controller@11420000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x11420000 0x1000>;
> interrupts = <GIC_SPI 73
>IRQ_TYPE_LEVEL_HIGH>; diff --git
>a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>index 960823b8247a..3364b09c3158 100644
>--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>@@ -142,7 +142,7 @@ gic: interrupt-controller@11001000 {
> <0x11006000 0x2000>;
> };
>
>- pdma0: pdma@10e10000 {
>+ pdma0: dma-controller@10e10000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x10E10000 0x1000>;
> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
>@@ -153,7 +153,7 @@ pdma0: pdma@10e10000 {
> #dma-requests = <32>;
> };
>
>- pdma1: pdma@10eb0000 {
>+ pdma1: dma-controller@10eb0000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x10EB0000 0x1000>;
> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
>--
>2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: (subset) [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema
2022-01-29 17:53 ` [PATCH 1/5] arm64: dts: exynos: align pl330 node name with dtschema Krzysztof Kozlowski
` (5 preceding siblings ...)
2022-01-30 7:20 ` Alim Akhtar
@ 2022-01-31 9:02 ` Krzysztof Kozlowski
6 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2022-01-31 9:02 UTC (permalink / raw)
To: Lee Jones, Krzysztof Kozlowski, linux-kernel, linux-arm-kernel,
Marek Szyprowski, Alim Akhtar, Sylwester Nawrocki,
linux-samsung-soc, Rob Herring, devicetree, linux-serial,
Greg Kroah-Hartman
On Sat, 29 Jan 2022 18:53:28 +0100, Krzysztof Kozlowski wrote:
> Fixes dtbs_check warnings like:
>
> pdma@15610000: $nodename:0: 'pdma@15610000' does not match '^dma-controller(@.*)?$'
>
>
Applied, thanks!
[1/5] arm64: dts: exynos: align pl330 node name with dtschema
commit: 706d8df83c8ec9cbe948ff8c8bd082b7819f4196
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread