From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F41BC433EF for ; Wed, 2 Feb 2022 18:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BzOV8wGpoqIiuSTRu3iaRD3BvE2qkyo1FJmgnhtHMck=; b=tY8cCJ2g9lCctl NeKBpup3tLQVqwOsY17Qdcuac50gLsZmnvNrL0R1RgRu8veuiQFncgAor+yz1zWMcPpsTLDVdqkGE t79a71wd5SxEJrbJba6WeAIB0tNwh8YgD/MyT1zdDtTC1KLRsb5IKuuwVVtkTxV2HGWjTcsEmu7r7 AyDTZKxDr0/odqegsHI6c1uqi/jMuibh4TWWDBzp17qzzHmxQpgSNBKln0o8SC723sAB2LFE1nX6P ye9CvIOa0wA/ktRE7KZCyntz8PQFgz6/o1Nc6URKAzDRMKbv2WrJUbSFw9VguBIrVHq6w/C7vmdgZ wS74E11kt+3SAqLuTEVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFKbS-00GcVW-34; Wed, 02 Feb 2022 18:43:38 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFKbL-00GcTr-Tg for linux-arm-kernel@lists.infradead.org; Wed, 02 Feb 2022 18:43:36 +0000 Received: by mail-pg1-x533.google.com with SMTP id h125so264020pgc.3 for ; Wed, 02 Feb 2022 10:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SDBZmOfzCxzCugk5jd7ddO5i086r0OhAAAxVBt9bcn4=; b=oCI/z/rsP2tCXkQEN/+3HjveKSrAnKOcocJwYaxxXbEW1w/eYlt67jmoJECImLXl6Y m+naw7bWdoJmdRnn10lDq1HpA2C5Az22TBA6yOAyuycAtgvmvSp/UQeky9h/lq03T2xw lFjkXkSHdF4LLPF0HB4gynXj3rNLfI65rrGnjcnuUumbMu6jj8AaMwam+iUKe7nJpgCo iYbJCIHr1SG2YFaExtqHyGZ7n/VHGIJmWCAeqACFxUBHAO5mxQNGVKviHVdOY7eknFJ4 iKjM6a0XZmYtrfGna/2nc/lbsI0MgMcoJPezmgMWAFHDODU9wJXJBWHksMfgYyj917xU GB0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SDBZmOfzCxzCugk5jd7ddO5i086r0OhAAAxVBt9bcn4=; b=Qar7Z3furb33eGaXDH6bhHkwoNQJbZcf9rjRdw/P+9lxKon0981A8Zssky+KejNxM5 zmjgKajuO58EDOmQHMTlXe6oaSjsICDj+oeA9Fgb5/9mvGGLS66sJkj1bFF482w67LXq 5HsiuYGHymibWPhsi14FAuPHHppb7cf7EOm9xUWGvIKym/Cv6ri8rkfAR2hdbBGC736X xXy8sbII+FR6oaLyhVTeAp50PuOV0bBWJ+FFs4tGpm2ajyIAlPz6qavt8ySs6DbvZl5d LdM0VxXL8n4Bv2l7RqZUdTthtJbKYjazb01CVq80GQYW/PFiUcsX8r7E/Cc+EYSLr9gc i47w== X-Gm-Message-State: AOAM533LV58R8U7cPPmQMMLR3tshddH7w4ftYpv7HVdYWwuRlsturlUF W3HFeiSLfv5eXQIGGCtsnezo3w== X-Google-Smtp-Source: ABdhPJyKY2bmBpNsgwyDJ0PlfhIstJxwGXU5jBuEN8xCwoW4q9qfWAOqxr1alAqmED6qNrXosDZfnA== X-Received: by 2002:aa7:9682:: with SMTP id f2mr31230350pfk.56.1643827410811; Wed, 02 Feb 2022 10:43:30 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id p22sm26858049pfo.163.2022.02.02.10.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 10:43:30 -0800 (PST) Date: Wed, 2 Feb 2022 18:43:26 +0000 From: Sean Christopherson To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Will McVicker , Sami Tolvanen Subject: Re: [PATCH v4 09/17] perf/core: Use static_call to optimize perf_guest_info_callbacks Message-ID: References: <20211111020738.2512932-1-seanjc@google.com> <20211111020738.2512932-10-seanjc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211111020738.2512932-10-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220202_104331_996961_FCB34453 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Will and Sami, -most everyone else On Thu, Nov 11, 2021, Sean Christopherson wrote: > Use static_call to optimize perf's guest callbacks on arm64 and x86, > which are now the only architectures that define the callbacks. Use > DEFINE_STATIC_CALL_RET0 as the default/NULL for all guest callbacks, as > the callback semantics are that a return value '0' means "not in guest". > > static_call obviously avoids the overhead of CONFIG_RETPOLINE=y, but is > also advantageous versus other solutions, e.g. per-cpu callbacks, in that > a per-cpu memory load is not needed to detect the !guest case. > > Based on code from Peter and Like. > > Suggested-by: Peter Zijlstra (Intel) > Cc: Like Xu > Reviewed-by: Paolo Bonzini > Signed-off-by: Sean Christopherson > --- ... > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 1c8d341ecc77..b4fd928e4ff8 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -6524,12 +6524,23 @@ static void perf_pending_event(struct irq_work *entry) > #ifdef CONFIG_GUEST_PERF_EVENTS > struct perf_guest_info_callbacks __rcu *perf_guest_cbs; > > +DEFINE_STATIC_CALL_RET0(__perf_guest_state, *perf_guest_cbs->state); > +DEFINE_STATIC_CALL_RET0(__perf_guest_get_ip, *perf_guest_cbs->get_ip); > +DEFINE_STATIC_CALL_RET0(__perf_guest_handle_intel_pt_intr, *perf_guest_cbs->handle_intel_pt_intr); Using __static_call_return0() makes clang's CFI sad on arm64 due to the resulting function prototype mistmatch, which IIUC, is verified by clang's __cfi_check() for indirect calls, i.e. architectures without CONFIG_HAVE_STATIC_CALL. We could fudge around the issue by using stubs, massaging prototypes, etc..., but that means doing that for every arch-agnostic user of __static_call_return0(). Any clever ideas? Can we do something like generate a unique function for every DEFINE_STATIC_CALL_RET0 for CONFIG_HAVE_STATIC_CALL=n, e.g. using typeof() to get the prototype? Kernel panic - not syncing: CFI failure (target: __static_call_return0+0x0/0x8) CPU: 0 PID: 1625 Comm: batterystats-wo Tainted: G W OE 5.16.0-mainline #1$ Hardware name: Raven EVT 1.1 (DT)$ Call trace:$ dump_backtrace+0xf0/0x130$ show_stack+0x1c/0x2c$ dump_stack_lvl+0x68/0x98$ panic+0x168/0x420$ __cfi_check_fail+0x58/0x5c$ __cfi_slowpath_diag+0x150/0x1a4$ perf_misc_flags+0x74/0xa4$ perf_prepare_sample+0x50/0x44c$ perf_event_output_forward+0x5c/0xcc$ __perf_event_overflow+0xc8/0x188$ perf_swevent_event+0x7c/0x10c$ perf_tp_event+0x168/0x298$ perf_trace_run_bpf_submit+0x8c/0xdc$ perf_trace_sched_switch+0x180/0x1cc$ __schedule+0x850/0x924$ schedule+0x98/0xe0$ binder_wait_for_work+0x158/0x368$ binder_thread_read+0x278/0x243c$ binder_ioctl_write_read+0x120/0x45c$ binder_ioctl+0x1ac/0xc34$ __arm64_sys_ioctl+0xa8/0x118$ invoke_syscall+0x64/0x178$ el0_svc_common+0x8c/0x100$ do_el0_svc+0x28/0xa0$ el0_svc+0x24/0x84$ el0t_64_sync_handler+0x88/0xec$ el0t_64_sync+0x1b4/0x1b8$ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel