From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42591C433F5 for ; Thu, 3 Feb 2022 06:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=li5MkREtuogs12bxgwgCX2YrSfxP80EFNn0iKf+G+sA=; b=dUnq2vHqi/nGqo gYrT8yphjxkEmh2xTKW+t1nbZkLZPCk/rc75ZZ0MUhFluRoBKCxBTKSdM250EtlYy373rtlKja3Zh QZQMg/Qtfd/hsXLQScyF9so5E0k8KfgDPypCOa4xtbOMHH7H2AvVKZTNhBhPaDNj9ZJDVmKxNNUJs lWmfdb7t3hn+mmON/VTE8/aKkBDGIQFdO3BpF+X0zA0MGou6Z6WL/OZd3Eb72acX7qhumh4qfPZG/ VYcwj3kj1Ji8s2W8QEjKCPSSrI+IesQbWjNyhH+NCH46v7Ealk0eitvqCRWZb9t0CfXP3q9QSl+YF bdvDZgjNCJjF/uxlBQmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFVzh-0006k5-2R; Thu, 03 Feb 2022 06:53:25 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFVze-0006ib-FF for linux-arm-kernel@lists.infradead.org; Thu, 03 Feb 2022 06:53:23 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E02E480EE; Thu, 3 Feb 2022 06:53:02 +0000 (UTC) Date: Thu, 3 Feb 2022 08:53:15 +0200 From: Tony Lindgren To: Drew Fustini Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix Message-ID: References: <20220202212554.1316032-1-dfustini@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220202212554.1316032-1-dfustini@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220202_225322_591873_FDE4A42E X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , Keerthy , Daniel Lezcano , linux-kernel@vger.kernel.org, khilman@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Drew Fustini [220202 23:26]: > I modified the errata fix to use timer 15 and 16 instead which resolves > the timer conflict. Makes sens to me, just one nit below. > Note: I am keeping the device tree and driver change together in one > patch as that is how the original errata fix commit was structured. Yes.. The old dtb handling for the timer driver causes this dependency unfortunately. > --- a/drivers/clocksource/timer-ti-dm-systimer.c > +++ b/drivers/clocksource/timer-ti-dm-systimer.c > @@ -695,9 +695,9 @@ static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa) > return 0; > } > > - if (pa == 0x48034000) /* dra7 dmtimer3 */ > + if (pa == 0x4882C000) /* dra7 dmtimer15 */ > return dmtimer_percpu_timer_init(np, 0); > - else if (pa == 0x48036000) /* dra7 dmtimer4 */ > + else if (pa == 0x4882E000) /* dra7 dmtimer16 */ > return dmtimer_percpu_timer_init(np, 1); > > return 0; Linux use lower case hex number typically :) With that, please feel free to add: Reviewed-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel