From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, clement.leger@bootlin.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: remove mandatory interrupts property
Date: Fri, 4 Feb 2022 10:46:14 +0100 [thread overview]
Message-ID: <Yfz15ta50G5WC158@piout.net> (raw)
In-Reply-To: <20220204081446.474991-1-eugen.hristev@microchip.com>
On 04/02/2022 10:14:46+0200, Eugen Hristev wrote:
> The timer block can be used only to be read and to measure time in a polling
> fashion. This can be used by Linux like this for example, or it can be used
> by different projects which do not have interrupt controllers, or do not
> wish to enable them (e.g. U-boot).
> As DT is ABI, the binding should relate to all possible use cases and describe
> the hardware and the requirements.
> The interrupt is not a hard requirement for the timer to function in a
> specific way.
> Thus, choose to remove the interrupts property from the mandatory list of
> properties.
>
The correct hardware description is that the interrupt is present on the
IP. Having software behave differently depending on the presence of that
property is configuration, not hardware description.
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> .../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> index 597d67fba92f..27f78459b892 100644
> --- a/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> +++ b/Documentation/devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml
> @@ -134,7 +134,6 @@ allOf:
> required:
> - compatible
> - reg
> - - interrupts
> - clocks
> - clock-names
> - '#address-cells'
> --
> 2.25.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-04 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 8:14 [PATCH] dt-bindings: microchip: atmel, at91rm9200-tcb: remove mandatory interrupts property Eugen Hristev
2022-02-04 9:46 ` Alexandre Belloni [this message]
2022-02-04 10:28 ` [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: " Eugen.Hristev
2022-02-04 10:36 ` Alexandre Belloni
2022-02-11 14:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfz15ta50G5WC158@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox