From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDEAFC433EF for ; Wed, 16 Feb 2022 14:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqFkmfRxIeR8UEnh8zoY+hORS599Ml49lKhJUFaS5Oo=; b=KCrY8udhfgQomP SD9cvBDrGlweqt3bPQyeSQps7XqS7s4TjQpG4QUEHNiAvAw1gnGJVou9x8zrmqCs+8lzVk1jap5Mz RdlBppy5DwvkGu4pXYB/r0j5ljDMxpG5xSH1tuaTI2f+cygA1qJ8mkQgmL32EZSNUblMuHyq69KNs /O95acIF2NbpolQw0jAGjMtdfvurbbym92kQ59zU3w1RhtnfegirWZN+IhI0XDBj0UIoIy0SUExl/ u3PJW1YO/Ygrzr8FoZWJka2G3/J5LFHa5HBTLAoCOYk5pP5o8MZMGzFtCG/8Kp6QpEUWJnm30wToY L7EmKYBWdykJpSW/CBRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKL5o-007Jke-3B; Wed, 16 Feb 2022 14:15:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKL5j-007JjW-MF for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 14:15:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B73B9106F; Wed, 16 Feb 2022 06:15:33 -0800 (PST) Received: from lakrids (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBB7D3F718; Wed, 16 Feb 2022 06:15:31 -0800 (PST) Date: Wed, 16 Feb 2022 14:15:26 +0000 From: Mark Rutland To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, acme@redhat.com, ardb@kernel.org, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, mingo@redhat.com, ndesaulniers@google.com, peterz@infradead.org, tglx@linutronix.de, will@kernel.org Subject: Re: [PATCH v3 5/5] tools: update x86 string routines Message-ID: References: <20220211151445.2027553-1-mark.rutland@arm.com> <20220211151445.2027553-6-mark.rutland@arm.com> <20220216055952.ovrswb22lm53x5ns@treble> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220216055952.ovrswb22lm53x5ns@treble> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_061535_818154_5DA513C5 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 15, 2022 at 09:59:52PM -0800, Josh Poimboeuf wrote: > On Fri, Feb 11, 2022 at 03:14:45PM +0000, Mark Rutland wrote: > > When building the perf tool the build system complains that the x86 > > string routines are out-of-date: > > > > | Warning: Kernel ABI header at 'tools/arch/x86/lib/memcpy_64.S' differs from latest version at 'arch/x86/lib/memcpy_64.S' > > | diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S > > | Warning: Kernel ABI header at 'tools/arch/x86/lib/memset_64.S' differs from latest version at 'arch/x86/lib/memset_64.S' > > | diff -u tools/arch/x86/lib/memset_64.S arch/x86/lib/memset_64.S > > > > This is due to the way the asm-annotations for symbol aliasing were > > reworked, which should have no functional/performance impact. > > > > Import the latest versions, adding the new style SYM_FUNC_ALIAS(), > > SYM_FUNC_ALIAS_LOAD(), SYM_FUNC_ALIAS_WEAK() macros into the perf > > header. The old style SYM_FUNC_START_ALIAS() and > > SYM_FUNC_END_ALIAS() macros are removed. > > > > Other than removing the build-time warning, there should be no > > functional change as a result of this patch. > > These changes should probably be squashed with their corresponding > original kernel changes to avoid breaking bisection for the warnings. > And it helps to keep the interdependent changes together. Sure; done for v4. Doing that highlighted a couple of fixups I failed to make to the tools/perf/ copy; I've fixed those up. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel