From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BEE6C433EF for ; Wed, 16 Feb 2022 16:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vZNcyBbUf4bulhVnQWcQRxMY3H5ZcblyCM5iGYpCZt4=; b=ittaqOWOqy9vfx ZwdxonpQzPW8mmKZJu0l6YzbSyXki2S6sx4lvH0/ZMR6VqWYUOZyOv93v+A8JaE+zUnOEM6WfUM7T aRdTtHuGPBlX02gCOrTwdVsTpAijGm533HI0+QVYdNxpO3BD/tGKspDmEXpGs8A0FrFo1/GKwJQ0m gJfoySvu6NX45M7PMiIZGvaY6nPFqf/IVShMSJ2Ev77OQgY9gntYUAUIrdnsvrkEE+HtpPAjrZrGF k7AwOswHDfBREPe8kDwhzF/HBsxf5V795Vtesx27xT1sOFbBJtINu+HxDOwrV9pximOfUhffZjcZG zmQVHhnyNs69qHvGUOMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKNCP-007iOZ-Jt; Wed, 16 Feb 2022 16:30:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKNCK-007iNB-LG for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 16:30:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E5D79D6E; Wed, 16 Feb 2022 08:30:31 -0800 (PST) Received: from lakrids (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1730F3F70D; Wed, 16 Feb 2022 08:30:30 -0800 (PST) Date: Wed, 16 Feb 2022 16:30:26 +0000 From: Mark Rutland To: Joey Gouly Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com, catalin.marinas@arm.com, robin.murphy@arm.com, will@kernel.org Subject: Re: [PATCH v1 0/3] Import Arm Optimized Routines str{n}cmp functions Message-ID: References: <20220215170723.21266-1-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220215170723.21266-1-joey.gouly@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_083032_776594_63220D2C X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 15, 2022 at 05:07:20PM +0000, Joey Gouly wrote: > Hi all, Hi, > The previous str{n}cmp routines were not MTE safe, so were disabled in: > 59a68d413808 ("arm64: Mitigate MTE issues with str{n}cmp()") > > The Arm Optimized Routines repository recently merged [1] their strcmp.S and > strcmp-mte.S files into a single file that is MTE safe. > > Therefore we can import these new MTE safe functions and remove the workaround. > > I did some light boot tests using QEMU. Nice! As as minor thing, on the two import patches, I think we should be more explicit about what's going on with licensing, so that it's clear the license change relative to upstream is intended and legitimate. For example, in commit: 758602c04409d8c5 ("arm64: Import latest version of Cortex Strings' strcmp") We had a note in the commit message: | Note that for simplicity Arm have chosen to contribute this code | to Linux under GPLv2 rather than the original MIT license. ... and I reckon it's worth being slightly more explicit, e.g. | Note that for simplicity Arm have chosen to contribute this code | to Linux under GPLv2 rather than the original MIT license. Arm is the | sole copyright holder for this code. That was previously confirmed at: https://lore.kernel.org/linux-arm-kernel/20210526101723.GA3806@C02TD0UTHF1T.local/ So with that latter wording added to the import patches: Acked-by: Mark Rutland As a heads-up, I believe this will conflict with changes I'm making to the way symbol aliasing works: https://lore.kernel.org/lkml/20220216162229.1076788-1-mark.rutland@arm.com/ ... and I reckon we need to fix that conflict in the arm64 tree, either as a merge resolution or rebasing this atop my series. Thanks, Mark. > > Thanks, > Joey > > [1] https://github.com/ARM-software/optimized-routines/commit/7b91c3cdb12b023004cb4dda30a1aa3424329ce6 > > Joey Gouly (3): > arm64: lib: Import latest version of Arm Optimized Routines' strcmp > arm64: lib: Import latest version of Arm Optimized Routines' strncmp > Revert "arm64: Mitigate MTE issues with str{n}cmp()" > > arch/arm64/include/asm/assembler.h | 5 - > arch/arm64/include/asm/string.h | 2 - > arch/arm64/lib/strcmp.S | 240 +++++++++++++++-------------- > arch/arm64/lib/strncmp.S | 236 +++++++++++++++++----------- > 4 files changed, 269 insertions(+), 214 deletions(-) > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel