From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF878C433F5 for ; Wed, 16 Feb 2022 16:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uDbVCCp3P5tBDxlAm1wIuQWrESAHao6DXqIa50e5tls=; b=RPoyDkoX11Ex5s vOWNEn7nNXZcDdXdC8GvYCtiRdnXDmOKt/ouk89oy4gkJepFxHCnvM7dyWSrUqMkosodiZSFB0aNT TYNIxdhyeygawi1MArfi4o+C2hBq4gnFkJAnffZ87ah26AWQHOKrbuDGd2Yd1bNSdOiIZYpCksHY+ 6bd8pC+qg53lUkNdvPjtlTD0i+RIlc0z2yhA6VI+vo3Tye5scqL0McXTP97uSVRKTo6+yV6GmT2E9 51+MACUz+vkWWe6u/lrNZrclHFtsaaQyRlKoYANWc6HcSlj1trExaR682hQDnUrcldDnHxXmtJ10H pROYReXljuFnB8D6RAVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKNXd-007nGS-0G; Wed, 16 Feb 2022 16:52:33 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKNXW-007nEp-SB for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 16:52:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4hTFif6kjO1qiokpR6YCTUYgnh9uq/4qSSbvi3+JHL0=; b=P0CQRQeOrWwSb//1/Iv37Y4Gob Up5GpOjQRyDkAomW51Q68dKZQ0SV6l3criV2EPUpKjTwwgYTOfli3awYUks7mzmU8vunOvFaAhsle qZV3IcpbpW0pr1noWmcBpTD8mqelinfHDaP5y5axAm8L1LeQHLDlkVcUsaMmes5yQ3iLsg5XXBp4C NbL3WR3gT3ZkysA9pmaKsSNs4gYV8kXN0n54ht536ReBOua+Y1I/gnIoe/0itB5mvLQvyuf+GxNAE NT0R64Or6VjbfSOHncC1jFGV61/R5geIeLilUHtsCtlKbxChFSYPKej+1N+Rv30NdBoYnWrFUhbGs 4kqlQpqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57292) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nKNXV-00045f-5b; Wed, 16 Feb 2022 16:52:25 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nKNXT-0000Eo-Hm; Wed, 16 Feb 2022 16:52:23 +0000 Date: Wed, 16 Feb 2022 16:52:23 +0000 From: "Russell King (Oracle)" To: Mark Rutland Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, nd@arm.com, catalin.marinas@arm.com, robin.murphy@arm.com, will@kernel.org Subject: Re: [PATCH v1 0/3] Import Arm Optimized Routines str{n}cmp functions Message-ID: References: <20220215170723.21266-1-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_085226_960224_4E9B3A12 X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 16, 2022 at 04:30:26PM +0000, Mark Rutland wrote: > On Tue, Feb 15, 2022 at 05:07:20PM +0000, Joey Gouly wrote: > > Hi all, > > Hi, > > > The previous str{n}cmp routines were not MTE safe, so were disabled in: > > 59a68d413808 ("arm64: Mitigate MTE issues with str{n}cmp()") > > > > The Arm Optimized Routines repository recently merged [1] their strcmp.S and > > strcmp-mte.S files into a single file that is MTE safe. > > > > Therefore we can import these new MTE safe functions and remove the workaround. > > > > I did some light boot tests using QEMU. > > Nice! > > As as minor thing, on the two import patches, I think we should be more > explicit about what's going on with licensing, so that it's clear the > license change relative to upstream is intended and legitimate. > > For example, in commit: > > 758602c04409d8c5 ("arm64: Import latest version of Cortex Strings' strcmp") > > We had a note in the commit message: > > | Note that for simplicity Arm have chosen to contribute this code > | to Linux under GPLv2 rather than the original MIT license. > > ... and I reckon it's worth being slightly more explicit, e.g. > > | Note that for simplicity Arm have chosen to contribute this code > | to Linux under GPLv2 rather than the original MIT license. Arm is the > | sole copyright holder for this code. > > That was previously confirmed at: > > https://lore.kernel.org/linux-arm-kernel/20210526101723.GA3806@C02TD0UTHF1T.local/ > > So with that latter wording added to the import patches: > > Acked-by: Mark Rutland As MIT is regarded as compatible with GPL v2 (MIT code can be integrated into GPL v2 projects) it seems rather strange. In any case, it's confusing to see the SPDX license identifiers saying it's GPLv2 only code, but when you look at the LICENSE file in the source repository, it's quite different. This probably needs some explanation in the files, or the SPDX saying that it's GPLv2 only or MIT or ... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel