From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42F2DC433EF for ; Wed, 16 Feb 2022 20:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DlAzAB3ZEUXLlOeG3Ox73KyVMIpTJ55+Lcgwy6Jlibg=; b=AlHK9zBQf4UltL Y3P4fkJ0dOs/SoKFzFu2VJJytcYcyF8wDH4ZeG1Tkx+oG+qmxXtuH51BvhjH6sY+PE18F6/3x1UnP AD/QICA+bvVvE7LfL5em6pOW8jZPEIvktIbCOhcdYqYceZFrEKn8J0YKwvyfpaE1XidYIIUprcbys RlCCZMPhwjkLI5Lw/qkz/TltamnkRLjkK3+GJZ6C1Li+rIgnTUhU+Y+WzrJxD3oU3hY/CISwlR1HZ lKvHeOirxhyH/hBV+xdHJhwoF0tRaVh4qwhEAxuS330vh0slK5c7oEGEWGvdJ6tcFIXG1eWYWJlFn mOzTLhjZx3YprpShEjdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKQXf-008I9s-Hw; Wed, 16 Feb 2022 20:04:47 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKQXb-008I8m-Qd for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 20:04:45 +0000 Received: by mail-oi1-x231.google.com with SMTP id x193so3703694oix.0 for ; Wed, 16 Feb 2022 12:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p2YTwFNc3ICXWv/s85vDqxZ1xSdkq0Hufu5d0bc0A8Y=; b=ShDIiG7IqOeZlZJd+lOTHVz4sQnn4UTTgLdoXPvdbfFg4sB5Jx184dwnyM7TXIyDAC WXTyRl2Xxk2ILmfzsohfmL/pHi3wV2l2fa4wIkrSe6j0+miNDN9LO5lwzt3HnFRi0P30 MHHVgwAHu6lpcWSmvOLlRsK2k3JhNNH7x3M2exo7YeoPGuGGQOONu3qlOrJosNgyfI9N Tt6ZG9qwubzj9RSqE6JVmuK9p2DFwuGpHOLov4d3x6EfffdpiiQAlAQzbxrk64XPQCXd Yx5ds9BwjkzP4sw33ZuEd4vXjvIDEb6dj5hI6bue5Deafp+sUmtTkX7a3W0p8FBrrEzV yltQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p2YTwFNc3ICXWv/s85vDqxZ1xSdkq0Hufu5d0bc0A8Y=; b=KH5Whvs4dpfuCpMJWrUpSBB4kitEe0QouKbY14Qugc72qjAEkQAb7n0hGSM8zx0uOz 8X1FlI7dwbpshep6sjl7BCb1Q1IvwMUtdOVwJhpwdyL/cdUimFPyybGblZTo1pAgvFTt r7crpL1UhBzFt9mS9cnAFoLMTJSwHcAH1YtxBphJUB+Zg+/eN9bh2tYUP4OQaxyFdVSi 1QKbOZgqKtlbSDMos7siX0XkiEZe/rB9nY76UX/zyVc0dVKhs1xJA4M78donOXQx07GS +TTK+VSgcR0jeXODYPZHNYnw+i3q0Ra9lGIpCb7zLzMo5PRYCc3Wcg0VgzMZoHK5NJzC FLiQ== X-Gm-Message-State: AOAM532qhrXPc36PVqLE39OTKtU0Tc9RL7NiRbFBQtUVDhBeS8g6al5w g/QB8jNgip49iImJOGgt1vBEXg== X-Google-Smtp-Source: ABdhPJyfFXY8f2acavlDqsG3T3QaNMqhHhohq4+eKFpTxvCuif/UZ/sHPs8HMl5vC/5Yf/qifBqBTg== X-Received: by 2002:aca:1a17:0:b0:2bc:a78c:7ba2 with SMTP id a23-20020aca1a17000000b002bca78c7ba2mr1414813oia.120.1645041880944; Wed, 16 Feb 2022 12:04:40 -0800 (PST) Received: from yoga (rrcs-97-77-166-58.sw.biz.rr.com. [97.77.166.58]) by smtp.gmail.com with ESMTPSA id w7sm15506869oou.13.2022.02.16.12.04.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 12:04:40 -0800 (PST) Date: Wed, 16 Feb 2022 14:04:37 -0600 From: Bjorn Andersson To: Puranjay Mohan Subject: Re: [PATCH v5 1/2] remoteproc: Introduce sysfs_read_only flag Message-ID: References: <20220216081224.9956-1-p-mohan@ti.com> <20220216081224.9956-2-p-mohan@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220216081224.9956-2-p-mohan@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_120443_919479_49FB19AF X-CRM114-Status: GOOD ( 33.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, mathieu.poirier@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 16 Feb 02:12 CST 2022, Puranjay Mohan wrote: > The remoteproc framework provides sysfs interfaces for changing > the firmware name and for starting/stopping a remote processor > through the sysfs files 'state' and 'firmware'. The 'coredump' > file is used to set the coredump configuration. The 'recovery' > sysfs file can also be used similarly to control the error recovery > state machine of a remoteproc. These interfaces are currently > allowed irrespective of how the remoteprocs were booted (like > remoteproc self auto-boot, remoteproc client-driven boot etc). > These interfaces can adversely affect a remoteproc and its clients > especially when a remoteproc is being controlled by a remoteproc > client driver(s). Also, not all remoteproc drivers may want to > support the sysfs interfaces by default. > > Add support to make the remoteproc sysfs files read only by > introducing a state flag 'sysfs_read_only' that the individual > remoteproc drivers can set based on their usage needs. The default > behavior is to allow the sysfs operations as before. > > Implement attribute_group->is_visible() to make the sysfs > entries read only when 'sysfs_read_only' flag is set. > > Signed-off-by: Puranjay Mohan > Reviewed-by: Mathieu Poirier > --- > Changes in v4->v5: > Rename deny_sysfs_ops to sysfs_read_only. > Make coredump readonly with other files. > > Changes in v3->v4: > Use mode = 0444 in rproc_is_visible() to make the sysfs entries > read-only when the deny_sysfs_ops flag is set. > --- > drivers/remoteproc/remoteproc_sysfs.c | 19 ++++++++++++++++++- > include/linux/remoteproc.h | 2 ++ > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c > index ea8b89f97d7b..abf0cd05d5e1 100644 > --- a/drivers/remoteproc/remoteproc_sysfs.c > +++ b/drivers/remoteproc/remoteproc_sysfs.c > @@ -230,6 +230,22 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr, > } > static DEVICE_ATTR_RO(name); > > +static umode_t rproc_is_visible(struct kobject *kobj, struct attribute *attr, > + int n) > +{ > + struct device *dev = kobj_to_dev(kobj); > + struct rproc *rproc = to_rproc(dev); > + umode_t mode = attr->mode; > + > + if (rproc->sysfs_read_only && (attr == &dev_attr_recovery.attr || > + attr == &dev_attr_firmware.attr || > + attr == &dev_attr_state.attr || > + attr == &dev_attr_coredump.attr)) > + mode = 0444; Change looks good now, but just to make sure, you actually care about the content of these files for the Wakup M3? Read-only vs hiding them... regards, Bjorn > + > + return mode; > +} > + > static struct attribute *rproc_attrs[] = { > &dev_attr_coredump.attr, > &dev_attr_recovery.attr, > @@ -240,7 +256,8 @@ static struct attribute *rproc_attrs[] = { > }; > > static const struct attribute_group rproc_devgroup = { > - .attrs = rproc_attrs > + .attrs = rproc_attrs, > + .is_visible = rproc_is_visible, > }; > > static const struct attribute_group *rproc_devgroups[] = { > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h > index e0600e1e5c17..93a1d0050fbc 100644 > --- a/include/linux/remoteproc.h > +++ b/include/linux/remoteproc.h > @@ -523,6 +523,7 @@ struct rproc_dump_segment { > * @table_sz: size of @cached_table > * @has_iommu: flag to indicate if remote processor is behind an MMU > * @auto_boot: flag to indicate if remote processor should be auto-started > + * @sysfs_read_only: flag to make remoteproc sysfs files read only > * @dump_segments: list of segments in the firmware > * @nb_vdev: number of vdev currently handled by rproc > * @elf_class: firmware ELF class > @@ -562,6 +563,7 @@ struct rproc { > size_t table_sz; > bool has_iommu; > bool auto_boot; > + bool sysfs_read_only; > struct list_head dump_segments; > int nb_vdev; > u8 elf_class; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel