From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79E6BC433F5 for ; Tue, 8 Feb 2022 16:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R0Mdy5zYg/9CMD5TXlkBFdQv2Q5SAwfgINZJ/Ph8Xl0=; b=JcPVB/Us25/hQq l3qyWXcyrIvYp9p7hN4G2KC+N7u0xX5IubNTF2UlrrmF9k008e5WfOHCsf2v/xbzYwjE6XBrPkENL 32mkpv4KTbAk+FkM44UH4IpCW4siKEEa0jKvN4wuBeh4L+IS8JXNhGD3sft12eVIIFJ0t3HfnCg03 2p4WQx8L6ooHzU2JfAeSD5WWn49RWyENAlS4S+tXjskBH5GuYm2xoVX/dMuy/75rKcLR4IXebBRXf EOO8Ebm5E+ELj0eq+LLUVHVirRFBV6PtfuV7UdqqkKV1NcclP+eAWCoZB7YkChw/fZ/Gs7FZLHp4b Gru85GhfBBUbLLX37BPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHT6P-00Emat-Uc; Tue, 08 Feb 2022 16:12:28 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHSzU-00EjV1-Un; Tue, 08 Feb 2022 16:05:19 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B0C45A04; Tue, 8 Feb 2022 17:05:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644336314; bh=hYlIvvM93lCc9l231DKm9wPmfJPGBh1jXIbdK7qXkgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SShJje1m2YMxOzxRu6/GA+1Z+52ZhOQHCDkUkfdWackYMfuADsmD65wsXs1yhbcdO UPGf9moBW0oAit8xPQIMhEcrFIpjAzRhVm9BVOmA3vGrtRe9dTVswizhjjdQU+jWno WZzwguZMwMA622+i7lgKuOmEtc2dzqCHF329ZJ4Q= Date: Tue, 8 Feb 2022 18:05:12 +0200 From: Laurent Pinchart To: Jean-Michel Hautbois Cc: dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, kernel-list@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, lukasz@jany.st, mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org, tomi.valkeinen@ideasonboard.com, bcm-kernel-feedback-list@broadcom.com, stefan.wahren@i2se.com Subject: Re: [PATCH v5 08/11] media: imx219: Switch from open to init_cfg Message-ID: References: <20220208155027.891055-1-jeanmichel.hautbois@ideasonboard.com> <20220208155027.891055-9-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_080517_205155_DB83AE15 X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 08, 2022 at 06:02:50PM +0200, Laurent Pinchart wrote: > Hi Jean-Michel, > > Thank you for the patch. > > On Tue, Feb 08, 2022 at 04:50:24PM +0100, Jean-Michel Hautbois wrote: > > Use the init_cfg pad level operation instead of the internal subdev > > open operation to set default formats on the pads. > > While at it, make the imx219_pad_ops more easier to read. > > It could have been useful to explain here why there's a separate > imx219_init_formats() function, as reviewers could wonder. It's clear > when reviewing the next patches though. > > > Signed-off-by: Jean-Michel Hautbois > > --- > > drivers/media/i2c/imx219.c | 63 +++++++++++++++----------------------- > > 1 file changed, 25 insertions(+), 38 deletions(-) > > > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > > index 74dba5e61201..abcaee15c4a0 100644 > > --- a/drivers/media/i2c/imx219.c > > +++ b/drivers/media/i2c/imx219.c > > @@ -685,34 +685,6 @@ static void imx219_set_default_format(struct imx219 *imx219) > > fmt->field = V4L2_FIELD_NONE; > > } > > > > -static int imx219_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > -{ > > - struct imx219 *imx219 = to_imx219(sd); > > - struct v4l2_mbus_framefmt *try_fmt = > > - v4l2_subdev_get_try_format(sd, fh->state, 0); > > - struct v4l2_rect *try_crop; > > - > > - mutex_lock(&imx219->mutex); > > - > > - /* Initialize try_fmt */ > > - try_fmt->width = supported_modes[0].width; > > - try_fmt->height = supported_modes[0].height; > > - try_fmt->code = imx219_get_format_code(imx219, > > - MEDIA_BUS_FMT_SRGGB10_1X10); > > - try_fmt->field = V4L2_FIELD_NONE; > > - > > - /* Initialize try_crop rectangle. */ > > - try_crop = v4l2_subdev_get_try_crop(sd, fh->state, 0); > > - try_crop->top = IMX219_PIXEL_ARRAY_TOP; > > - try_crop->left = IMX219_PIXEL_ARRAY_LEFT; > > - try_crop->width = IMX219_PIXEL_ARRAY_WIDTH; > > - try_crop->height = IMX219_PIXEL_ARRAY_HEIGHT; > > The crop rectangle initialization is removed here, but not added below. > > > - > > - mutex_unlock(&imx219->mutex); > > - > > - return 0; > > -} > > - > > static int imx219_set_ctrl(struct v4l2_ctrl *ctrl) > > { > > struct imx219 *imx219 = > > @@ -802,6 +774,25 @@ static const struct v4l2_ctrl_ops imx219_ctrl_ops = { > > .s_ctrl = imx219_set_ctrl, > > }; > > > > +static void imx219_init_formats(struct v4l2_subdev_state *state) > > +{ > > + struct v4l2_mbus_framefmt *format; > > + > > + format = v4l2_state_get_stream_format(state, 0, 0); Also, this won't work until you create routes. The function will return NULL and you'll crash. This is fixed in subsequent patches, but it breaks bisection. > > + format->code = imx219_mbus_formats[0]; > > + format->width = supported_modes[0].width; > > + format->height = supported_modes[0].height; > > + format->field = V4L2_FIELD_NONE; > > + format->colorspace = V4L2_COLORSPACE_RAW; > > +} > > + > > +static int imx219_init_cfg(struct v4l2_subdev *sd, > > + struct v4l2_subdev_state *state) > > +{ > > + imx219_init_formats(state); > > + return 0; > > +} > > + > > static int imx219_enum_mbus_code(struct v4l2_subdev *sd, > > struct v4l2_subdev_state *sd_state, > > struct v4l2_subdev_mbus_code_enum *code) > > @@ -1255,11 +1246,12 @@ static const struct v4l2_subdev_video_ops imx219_video_ops = { > > }; > > > > static const struct v4l2_subdev_pad_ops imx219_pad_ops = { > > - .enum_mbus_code = imx219_enum_mbus_code, > > - .get_fmt = imx219_get_pad_format, > > - .set_fmt = imx219_set_pad_format, > > - .get_selection = imx219_get_selection, > > - .enum_frame_size = imx219_enum_frame_size, > > + .init_cfg = imx219_init_cfg, > > + .enum_mbus_code = imx219_enum_mbus_code, > > + .get_fmt = imx219_get_pad_format, > > + .set_fmt = imx219_set_pad_format, > > + .get_selection = imx219_get_selection, > > + .enum_frame_size = imx219_enum_frame_size, > > }; > > > > static const struct v4l2_subdev_ops imx219_subdev_ops = { > > @@ -1268,10 +1260,6 @@ static const struct v4l2_subdev_ops imx219_subdev_ops = { > > .pad = &imx219_pad_ops, > > }; > > > > -static const struct v4l2_subdev_internal_ops imx219_internal_ops = { > > - .open = imx219_open, > > -}; > > - > > /* Initialize control handlers */ > > static int imx219_init_controls(struct imx219 *imx219) > > { > > @@ -1520,7 +1508,6 @@ static int imx219_probe(struct i2c_client *client) > > goto error_power_off; > > > > /* Initialize subdev */ > > - imx219->sd.internal_ops = &imx219_internal_ops; > > imx219->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | > > V4L2_SUBDEV_FL_HAS_EVENTS; > > imx219->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR; > > -- > Regards, > > Laurent Pinchart -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel