From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6369CC433EF for ; Wed, 9 Feb 2022 13:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rb8J6fVInSQK94RMq6OZcHpltfYwJQPt4urFL7Vj764=; b=pcl5V4KlJq66JI es9V10cNzUCuarlQUlBa2M/wt4XljKi5u/t61wn4/DUQFkievcZtdxUSJe5RHqwmdIWoFbUCQLpJZ H+szTP0J9DgihTKBvgPsOnAj3cdGIQ0O1ZLy+70kXCRGA6DnmBNtg03f+s9umH70GGvklQEGPOF1i eICSwbcJANDRij9frW0vpjSkiHgKr29elze0IqHwY/814H1YoIffKRmvsD5eoVi+QPuA4hFEfQnIQ C9iqT5VNXyJDMWFuqIEEqGbnzHCNw2Y50mJxkINFwu8K35IXw1B6dOMCeYE4jnevRZnwNHH6UXwbw IjBGZDRJBuEnBHzMPDhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHmiK-0007gA-LM; Wed, 09 Feb 2022 13:08:52 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHmiH-0007ZQ-OE; Wed, 09 Feb 2022 13:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=upC8s56EuBQezUfHCbf6Sex/+GOA674B29PJ8A+uuZs=; b=jEde0e7/5XB5RNBY5P0Vm0oUK/ QNk0l0BR42QvBLJDWE23pmjEGFOKS25qjupBZFdyIZJJwMZtNP3X0WrjOua7p+6GABojoNDdZogGF qZM7TXQ+M6I80Mr3OfH2PGqACrQmHLPZo1U3VakRfdmDxMF1d8KHvphtcYkqa/9gUJYzc0hentYbu r5XLzDHUAP3TfdLJkNoKwXlqyT+0K6ukhwendyAGkad1ABuLhgeUDZlsfVBPQsPVZbJNbLMO0ezrf CJHIn6753z7Q+vcarDxi1uevRXBbnKEBwPjzPyuC83n0RHFIVlvu1S4yMspH0V8c8pmrew68mDaBL r9KChxpQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57168) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nHmg8-0004XV-9o; Wed, 09 Feb 2022 13:06:36 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nHmg4-0001Xq-PC; Wed, 09 Feb 2022 13:06:32 +0000 Date: Wed, 9 Feb 2022 13:06:32 +0000 From: "Russell King (Oracle)" To: DENG Qingfang , Landen Chao , Sean Wang Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next 0/7] net: dsa: mt7530: updates for phylink changes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_050849_811363_B26F3A99 X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 03, 2022 at 05:30:31PM +0000, Russell King (Oracle) wrote: > Hi, > > This series is a partial conversion of the mt7530 DSA driver to the > modern phylink infrastructure. This driver has some exceptional cases > which prevent - at the moment - its full conversion (particularly with > the Autoneg bit) to using phylink_generic_validate(). > > What stands in the way is this if() condition in > mt753x_phylink_validate(): > > if (state->interface != PHY_INTERFACE_MODE_TRGMII || > !phy_interface_mode_is_8023z(state->interface)) { > > reduces to being always true. I highlight this here for the attention > of the driver maintainers. I'm intending to submit this series later today, preserving the above behaviour, as I like to keep drivers bug-for-bug compatible, with the assumption that they've been tested as working, even if the code looks wrong. However, it would be good if this point could be addressed. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel