Re: [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml

Corentin Labbe
2022-02-09T13:44:39Z

Le Wed, Feb 09, 2022 at 01:52:45PM +0100, Heiko Stübner a écrit :
> Am Mittwoch, 9. Februar 2022, 13:47:25 CET schrieb Corentin Labbe:
> > Convert rockchip-crypto to yaml.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > .../bindings/crypto/rockchip-crypto.txt | 28 --------
> > .../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++
> > 2 files changed, 64 insertions(+), 28 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> > deleted file mode 100644
> > index 5e2ba385b8c9..000000000000
> > --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> > +++ /dev/null
> > @@ -1,28 +0,0 @@
> > -Rockchip Electronics And Security Accelerator
> > -
> > -Required properties:
> > -- compatible: Should be "rockchip,rk3288-crypto"
> > -- reg: Base physical address of the engine and length of memory mapped
> > - region
> > -- interrupts: Interrupt number
> > -- clocks: Reference to the clocks about crypto
> > -- clock-names: "aclk" used to clock data
> > - "hclk" used to clock data
> > - "sclk" used to clock crypto accelerator
> > - "apb_pclk" used to clock dma
> > -- resets: Must contain an entry for each entry in reset-names.
> > - See ../reset/reset.txt for details.
> > -- reset-names: Must include the name "crypto-rst".
> > -
> > -Examples:
> > -
> > - crypto: cypto-controller@ff8a0000 {
> > - compatible = "rockchip,rk3288-crypto";
> > - reg = <0xff8a0000 0x4000>;
> > - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> > - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> > - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> > - resets = <&cru SRST_CRYPTO>;
> > - reset-names = "crypto-rst";
> > - };
> > diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> > new file mode 100644
> > index 000000000000..392d89055398
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/crypto/rockchip-crypto.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Rockchip Electronics And Security Accelerator
> > +
> > +maintainers:
> > + - Heiko Stuebner <heiko@sntech.de>
> > +
> > +properties:
> > + compatible:
> > + const: rockchip,rk3288-crypto
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: clock data
> > + - description: clock data
> > + - description: clock crypto accelerator
> > + - description: clock dma
> > +
> > + clock-names:
> > + items:
> > + - const: aclk
> > + - const: hclk
> > + - const: sclk
> > + - const: apb_pclk
> > +
> > + resets:
> > + minItems: 1
> > +
> > + reset-names:
> > + const: crypto-rst
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - resets
> > + - reset-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
>
> Binding itself looks good.
>
> But the constants below will probably trigger a compiler-error and
> therefore Rob's bot.
>
> You will need something like
>
> #include <dt-bindings/clock/rk3399-cru.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> here.
>
> A "make ..... dt_binding_check" should show the issue and also
> it going away with the right includes ;-)
>
> Heiko
>

Right, I forgot to add this file in my "dt to check" via dt_binding_check, but the following make dtbs_check made me believe it was tested.

I will send a v2 soon.

Regards