From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BF0BC433EF for ; Thu, 10 Feb 2022 00:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NGCkWwhVfeLg0TCCX3I7+M9s/SCcmYOvWn1clRby6gA=; b=NrMIih7jSvFHoR LMvTmqDKcQrxaUoXwS/9NoFloAy2JDEMNoqFpul46PK3acDAZZfuqESsg2efPDm5nQO8kigce9f1g D13j7WgcR2xKW5haEHI7QoiMxVyBq6NfaTnE98njrvpaJkZkv2VwmbPWaISYxkt09bJdUj8ullbPD UMmeC/22QVHFYtdlbijGr1HtuIhRANCaJpw2xoqkwQz2g5iCfc0c1CmMViAeY+OvPgP72oe58kCpH DitCiq8tkdWqpdnsYxKCcaOya6eqQEu3jJUnlsZgxhgjMHp8QjDIKDVq9jTVM3MqV3gg4TBYcpsPE avNol1F+rwbWF2RUk8yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHxNJ-0027cC-M6; Thu, 10 Feb 2022 00:31:53 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHxNF-0027bQ-NP; Thu, 10 Feb 2022 00:31:51 +0000 Received: by mail-oi1-f174.google.com with SMTP id m10so4367219oie.2; Wed, 09 Feb 2022 16:31:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H+aB7MEEh65erIWPmlmykpbHBq+zpDiRSwvKXtfqf4Y=; b=h3heG+HPoz34bZTwrfR7zBXjLTK6JVpYM/e/jdOkn3o6j15+XFUxKCuOjfasQqf1Q6 S5vye8XT8dYdDM1C6GXlxl3ckD7CuClFQ1QOiKTka7MpYRPXbUyXMN/1H+bsJ6wotJGP i3TJ1Q3WQUgA5Si2hzExM3x7lJ/KnQb4bUg9BF6UINGc/9D5mzti8bVVaLDGOMHW/plM yTwpYYvTIokjrgWuPUAryKQ6remOye0qBt4CJbPdI42HzI2EGOrXdIeqotIk6k/cLqJE wyt9QEMUHSQKUM8bkGBdxpUCY9YpYBexCo5zGrjIIWtn6TupQuWGjbWp2YPTiis5rl4K vcgw== X-Gm-Message-State: AOAM530a39e1UNnxmBvN1La+L+2zN7EtjNa4v3sksBTtJ0P/4duxM3h2 gcxY0rVuYmXCmVxux4UeeQ== X-Google-Smtp-Source: ABdhPJyEseR1JkYMfiGodATxo9VXU0oluRqUhwbN59lnCsGWCuMw6s3B1TsytqnRqXVGNm5eIiUTnw== X-Received: by 2002:a05:6808:168b:: with SMTP id bb11mr2221766oib.184.1644453108777; Wed, 09 Feb 2022 16:31:48 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id s3sm7743074ois.19.2022.02.09.16.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 16:31:47 -0800 (PST) Received: (nullmailer pid 1260233 invoked by uid 1000); Thu, 10 Feb 2022 00:31:47 -0000 Date: Wed, 9 Feb 2022 18:31:47 -0600 From: Rob Herring To: Chen-Yu Tsai Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Guodong Liu , Matthias Brugger , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , linux-mediatek@lists.infradead.org, Linus Walleij , Tinghan Shen Subject: Re: [PATCH] dt-bindings: pinctrl: mt8195: fix bias-pull-{up,down} checks Message-ID: References: <20220202153528.707185-1-wenst@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220202153528.707185-1-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_163149_780567_4C8014A8 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 02 Feb 2022 23:35:28 +0800, Chen-Yu Tsai wrote: > When the constraints and description for bias-pull-{up,down} were added, > the constraints were not indented correctly, resulting in them being > parsed as part of the description. This effectively nullified their > purpose. > > Move the constraints out of the description block, make each description > part of the same associative array as the enum its describing, and > reindent them correctly so they take effect. > > Also add "type: boolean" to the list of valid values. This corresponds > to having bias-pull-{up,down} without any arguments. > > Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description") > Signed-off-by: Chen-Yu Tsai > --- > .../bindings/pinctrl/pinctrl-mt8195.yaml | 30 ++++++++++--------- > 1 file changed, 16 insertions(+), 14 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel