From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB597C433F5 for ; Thu, 10 Feb 2022 10:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kCSGtHD4d0nAxJ6Plrm7PrM8NUceDXj13/bY0T+UV3M=; b=GOh9sHn1POSpv2 Y8iIiYO2A7GoJaJy1EWUwyLGtdM6V+B87gskVYn2dBrhuLwSaaB1cPNeS25HcV9s1wwh0g3DtB4Zj kwDH/iJsqtvs9hqFxTBMSg4cVBj+bv5NsboulkwdKUB8HLleOR7bVQFXpgHsUPR49BHdQpGqBThDk RgN71v4utZJGb/rtYAuuyuxzKnggc+sEhSkj+/TOa7XWDlYoZXqspdakx+XOAw4UVPKb/6jFaAY2A 5ETV9p2ufGWaBrFRvXYzNZ0nlSRNmhfZvZAgG0WREohDO3GhhJl8R/oh2f4dMSfEjnh8lCnZNnrFI BD6WQR3B1oCBCkAAvJVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI6gD-003RCI-4t; Thu, 10 Feb 2022 10:28:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI6g8-003RB9-OI for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 10:27:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D96DED1; Thu, 10 Feb 2022 02:27:54 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.87.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 157DA3F718; Thu, 10 Feb 2022 02:27:51 -0800 (PST) Date: Thu, 10 Feb 2022 10:27:39 +0000 From: Mark Rutland To: Frederic Weisbecker Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys Message-ID: References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-6-mark.rutland@arm.com> <20220209174801.GA547263@lothringen> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220209174801.GA547263@lothringen> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_022756_876109_54BF0ADC X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 06:48:01PM +0100, Frederic Weisbecker wrote: > On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote: > > +config HAVE_PREEMPT_DYNAMIC_KEY > > + bool > > + depends on JUMP_LABEL > > This should probably be: > > depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO > select JUMP_LABEL > > Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n. I'll make that: config HAVE_PREEMPT_DYNAMIC_KEY bool depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO ... ... and config PREEMPT_DYNAMIC bool "Preemption behaviour defined on boot" depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY ... So that we don't force JUMP_LABEL on even when people aren't using it. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel