From: Rob Herring <robh@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Eugen.Hristev@microchip.com, clement.leger@bootlin.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: remove mandatory interrupts property
Date: Fri, 11 Feb 2022 08:21:48 -0600 [thread overview]
Message-ID: <YgZw/IB1V7NTRUJQ@robh.at.kernel.org> (raw)
In-Reply-To: <Yf0Bkh4pXKORmNkG@piout.net>
On Fri, Feb 04, 2022 at 11:36:02AM +0100, Alexandre Belloni wrote:
> On 04/02/2022 10:28:43+0000, Eugen.Hristev@microchip.com wrote:
> > On 2/4/22 11:46 AM, Alexandre Belloni wrote:
> > > On 04/02/2022 10:14:46+0200, Eugen Hristev wrote:
> > >> The timer block can be used only to be read and to measure time in a polling
> > >> fashion. This can be used by Linux like this for example, or it can be used
> > >> by different projects which do not have interrupt controllers, or do not
> > >> wish to enable them (e.g. U-boot).
> > >> As DT is ABI, the binding should relate to all possible use cases and describe
> > >> the hardware and the requirements.
> > >> The interrupt is not a hard requirement for the timer to function in a
> > >> specific way.
> > >> Thus, choose to remove the interrupts property from the mandatory list of
> > >> properties.
> > >>
> > >
> > > The correct hardware description is that the interrupt is present on the
> > > IP. Having software behave differently depending on the presence of that
> > > property is configuration, not hardware description.
> >
> > I agree. The interrupt is present on the IP, thus the property exists
> > and it's described.
> > However, the interrupt is not mandatory for IP operations. Thus it
> > should not be in the list of mandatory properties.
> >
>
> If the interrupt is always present, it is mandatory, it doesn't matter
> whether is is used or necessary to get the IP to work.
Agreed.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-02-11 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 8:14 [PATCH] dt-bindings: microchip: atmel, at91rm9200-tcb: remove mandatory interrupts property Eugen Hristev
2022-02-04 9:46 ` [PATCH] dt-bindings: microchip: atmel,at91rm9200-tcb: " Alexandre Belloni
2022-02-04 10:28 ` Eugen.Hristev
2022-02-04 10:36 ` Alexandre Belloni
2022-02-11 14:21 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgZw/IB1V7NTRUJQ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Eugen.Hristev@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox