From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8D98C433F5 for ; Fri, 11 Feb 2022 15:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FleglOXPQNPbZMpMb39150xPZQ0ybadCGCHrf9q/pRc=; b=JnQBY6avIZY5ot ciccKCQBNNPjNLOl32K/c11wrzkXNfD0YGdtfD7ieAUQl6zZhQCVqjou2kzodxTgnfQake3qHAJY+ thBQWGNRPgV8IyGhXKtLy7ToOeq4QtbmLn3qaFte/7hfuM9e+l7UwNbdmNK02nbX/znUI4hxtGSG2 aFuLYaoMvr/KcNlhMIrU9F9Y+uY4gMLm4sQVRtw6YOz0oL2dt/6NC0ljP9gE/rqAh4kefPkPGU3Jd QDaagnWwlMCXl1XRNde2sNTgMcximYTDkG+hjLse5x4sXHSakEJwgeQTIKlFuINu/xTHygKVg5/Al KdiF7jOaLW06dEK0qAQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIYAz-007rRb-Uk; Fri, 11 Feb 2022 15:49:38 +0000 Received: from mail-oi1-f178.google.com ([209.85.167.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIYAv-007rPe-Ao for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 15:49:35 +0000 Received: by mail-oi1-f178.google.com with SMTP id q8so9969919oiw.7 for ; Fri, 11 Feb 2022 07:49:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gWKYE2d0LpVfiDQEqlRd5JWJe4nWkpS2f1rG0JFNYfg=; b=RgVcrQzdVZvxtvEtYo76ExYtkMDYqWuC+PehJyABdxgxXASLZpUy0GNAGtW+KcIS0p ZqRt4Xhe/+Kd5oyo4ve84Cjz2QmCtd3keWQ3IDSzAhHytB/bsNxGyZHlqS3pc9SxRJi0 kniCzDPpxQdSWvv8bfG85OilqRpWsapD/TNAbW93d9Pzq0yBIvy+sMF4iH2z6DCaMslu Wq99F8LYK8VTJ+mOvvX9FsWkIe6RFEDB2QssFiUjR4BguJvMRizj23XVZKK5hSoi3C3R 6xlP9qadcaAFX89FdM8hWz1HXYCfwJ+UxyXYiL+ymNIqBr5CWe679iarN4Q4jQlC2cJY vPdw== X-Gm-Message-State: AOAM530S4TpVWdvPgJOEzSwACA/jlh5mmw9T2WliRe01nx+xXAaiH7oa Dj0jeAt7SwV9j/q3VvUm6Q== X-Google-Smtp-Source: ABdhPJxoP4zIIRj7it+mF16gB50xGdR/J7wpMEl6fEvCZKZC+lc5Es0k1OoC2wRfJCacn5nRg4UQ1w== X-Received: by 2002:a05:6808:11c6:: with SMTP id p6mr460883oiv.50.1644594571778; Fri, 11 Feb 2022 07:49:31 -0800 (PST) Received: from robh.at.kernel.org ([2607:fb90:5fee:dfce:b6df:c3e1:b1e5:d6d8]) by smtp.gmail.com with ESMTPSA id bh7sm6124885oib.6.2022.02.11.07.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 07:49:30 -0800 (PST) Received: (nullmailer pid 409607 invoked by uid 1000); Fri, 11 Feb 2022 15:46:27 -0000 Date: Fri, 11 Feb 2022 09:46:27 -0600 From: Rob Herring To: Andreas Kemnade Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alistair@alistair23.me, samuel@sholland.org, josua.mayer@jm0.eu, letux-kernel@openphoenux.org Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Message-ID: References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220206080016.796556-2-andreas@kemnade.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_074933_405436_2B1A9B73 X-CRM114-Status: GOOD ( 25.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > Add a binding for the Electrophoretic Display Controller found at least > in the i.MX6. The first version was in i.MX50 (I helped design the register interface). Is that version compatible? > The timing subnode is directly here to avoid having display parameters > spread all over the plate. > > Supplies are organized the same way as in the fbdev driver in the > NXP/Freescale kernel forks. The regulators used for that purpose, > like the TPS65185, the SY7636A and MAX17135 have typically a single bit to > start a bunch of regulators of higher or negative voltage with a > well-defined timing. VCOM can be handled separately, but can also be > incorporated into that single bit. > > Signed-off-by: Andreas Kemnade > --- > .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ > 1 file changed, 159 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > new file mode 100644 > index 000000000000..7e0795cc3f70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > @@ -0,0 +1,159 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,mxc-epdc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 EPDC > + > +maintainers: > + - Andreas Kemnade > + > +description: | > + The EPDC is a controller for handling electronic paper displays found in > + i.MX6 SoCs. > + > +properties: > + compatible: > + enum: > + - fsl,imx6sl-epdc > + - fsl,imx6sll-epdc Not compatible with each other? > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Bus clock > + - description: Pixel clock > + > + clock-names: > + items: > + - const: axi > + - const: pix > + > + interrupts: > + maxItems: 1 > + > + vscan-holdoff: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + sdoed-width: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + sdoed-delay: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + sdoez-width: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + sdoez-delay: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + gdclk-hp-offs: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + gdsp-offs: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + gdoe-offs: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + gdclk-offs: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + num-ce: > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 All these need a vendor prefix and descriptions. > + > + timing: > + $ref: /display/panel/panel-timing.yaml# > + > + DISPLAY-supply: > + description: > + A couple of +/- voltages automatically powered on in a defintive order > + > + VCOM-supply: > + description: compensation voltage > + > + V3P3-supply: > + description: V3P3 supply > + > + epd-thermal-zone: > + description: > + Zone to get temperature of the EPD from, practically ambient temperature. > + > + > + 1 blank line. > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - vscan-holdoff > + - sdoed-width > + - sdoed-delay > + - sdoez-width > + - sdoez-delay > + - gdclk-hp-offs > + - gdsp-offs > + - gdoe-offs > + - gdclk-offs > + - num-ce > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + epdc: epdc@20f4000 { > + compatible = "fsl,imx6sl-epdc"; > + reg = <0x020f4000 0x4000>; > + interrupts = <0 97 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6SL_CLK_EPDC_AXI>, <&clks IMX6SL_CLK_EPDC_PIX>; > + clock-names = "axi", "pix"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_epdc0>; > + V3P3-supply = <&V3P3_reg>; > + VCOM-supply = <&VCOM_reg>; > + DISPLAY-supply = <&DISPLAY_reg>; > + epd-thermal-zone = "epd-thermal"; > + > + vscan-holdoff = <4>; > + sdoed-width = <10>; > + sdoed-delay = <20>; > + sdoez-width = <10>; > + sdoez-delay = <20>; > + gdclk-hp-offs = <562>; > + gdsp-offs = <662>; > + gdoe-offs = <0>; > + gdclk-offs = <225>; > + num-ce = <3>; > + status = "okay"; Don't need status in examples. > + > + timing { > + clock-frequency = <80000000>; > + hactive = <1448>; > + hback-porch = <16>; > + hfront-porch = <102>; > + hsync-len = <28>; > + vactive = <1072>; > + vback-porch = <4>; > + vfront-porch = <4>; > + vsync-len = <2>; > + }; > + }; > +... > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel