From: Patrick Williams <patrick@stwcx.xyz>
To: Potin Lai <potin.lai@quantatw.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node
Date: Fri, 11 Feb 2022 16:19:36 -0600 [thread overview]
Message-ID: <Ygbg+KYK9qT90O2N@heinlein> (raw)
In-Reply-To: <20220211014347.24841-11-potin.lai@quantatw.com>
[-- Attachment #1.1: Type: text/plain, Size: 1264 bytes --]
On Fri, Feb 11, 2022 at 09:43:47AM +0800, Potin Lai wrote:
> Remove redundant i2c1 node.
> Disable in-chip rtc, use external rtc (pcf85263) instead.
A bit of "why" on the RTC change might be useful. I suspect it has to do
with where battery-backing is for the RTC in hardware.
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index 946107bd8bc7..fb62a67cfeed 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -205,10 +205,6 @@
> };
> };
>
> -&rtc {
> - status = "okay";
> -};
> -
> &fmc {
> status = "okay";
> flash@0 {
> @@ -387,10 +383,6 @@
> };
> };
>
> -&i2c1 {
> - status = "okay";
> -};
> -
> &i2c2 {
> status = "okay";
> ina230@45 {
> @@ -680,6 +672,7 @@
> };
>
> rtc@51 {
> + /* in-chip rtc disabled, use this external rtc instead */
> compatible = "nxp,pcf85263";
> reg = <0x51>;
> };
> --
> 2.17.1
>
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-11 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220211014347.24841-1-potin.lai@quantatw.com>
[not found] ` <20220211014347.24841-4-potin.lai@quantatw.com>
2022-02-11 22:16 ` [PATCH 03/10] arch: arm: dts: bletchley: update gpio-line-names Patrick Williams
[not found] ` <20220211014347.24841-11-potin.lai@quantatw.com>
2022-02-11 22:19 ` Patrick Williams [this message]
2022-02-11 22:20 ` [PATCH 00/10] arch: arm: dts: update Facebook Bletchley BMC Patrick Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygbg+KYK9qT90O2N@heinlein \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).