* Re: [PATCH 03/10] arch: arm: dts: bletchley: update gpio-line-names
[not found] ` <20220211014347.24841-4-potin.lai@quantatw.com>
@ 2022-02-11 22:16 ` Patrick Williams
0 siblings, 0 replies; 3+ messages in thread
From: Patrick Williams @ 2022-02-11 22:16 UTC (permalink / raw)
To: Potin Lai
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 4279 bytes --]
On Fri, Feb 11, 2022 at 09:43:40AM +0800, Potin Lai wrote:
> update gpio-line-names for gpio0 and all io expander
It would be good to describe what kind of update(s) you are doing. I see mostly
pins being added. Maybe a bullet-point of what ones you are adding?
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
> .../dts/aspeed-bmc-facebook-bletchley.dts | 26 ++++++++++---------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index ebd2430a3bdd..fc0690ccdb0a 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -270,7 +270,7 @@
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "led-sled1-amber","led-sled1-blue","SLED1_RST_IOEXP","",
> + "led-sled1-amber","led-sled1-blue","SLED1_RST_IOEXP","SLED1_MD_REF_PWM",
> "","","","",
> "","","","",
> "","","","";
> @@ -333,7 +333,7 @@
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "led-sled2-amber","led-sled2-blue","SLED2_RST_IOEXP","",
> + "led-sled2-amber","led-sled2-blue","SLED2_RST_IOEXP","SLED2_MD_REF_PWM",
> "","","","",
> "","","","",
> "","","","";
> @@ -400,7 +400,7 @@
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "led-sled3-amber","led-sled3-blue","SLED3_RST_IOEXP","",
> + "led-sled3-amber","led-sled3-blue","SLED3_RST_IOEXP","SLED3_MD_REF_PWM",
> "","","","",
> "","","","",
> "","","","";
> @@ -463,7 +463,7 @@
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "led-sled4-amber","led-sled4-blue","SLED4_RST_IOEXP","",
> + "led-sled4-amber","led-sled4-blue","SLED4_RST_IOEXP","SLED4_MD_REF_PWM",
> "","","","",
> "","","","",
> "","","","";
> @@ -526,7 +526,7 @@
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "led-sled5-amber","led-sled5-blue","SLED5_RST_IOEXP","",
> + "led-sled5-amber","led-sled5-blue","SLED5_RST_IOEXP","SLED5_MD_REF_PWM",
> "","","","",
> "","","","",
> "","","","";
> @@ -589,7 +589,7 @@
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "led-sled6-amber","led-sled6-blue","SLED6_RST_IOEXP","",
> + "led-sled6-amber","led-sled6-blue","SLED6_RST_IOEXP","SLED6_MD_REF_PWM",
> "","","","",
> "","","","",
> "","","","";
> @@ -727,16 +727,17 @@
> /*D0-D7*/ "","","","","","","","",
> /*E0-E7*/ "","","","","","","","",
> /*F0-F7*/ "","","","","","","","",
> - /*G0-G7*/ "","SWITCH_FRU_MUX","","","","","","",
> + /*G0-G7*/ "BSM_FRU_WP","SWITCH_FRU_MUX","","",
> + "PWRGD_P1V05_VDDCORE","PWRGD_P1V5_VDD","","",
> /*H0-H7*/ "presence-riser1","presence-riser2",
> "presence-sled1","presence-sled2",
> "presence-sled3","presence-sled4",
> "presence-sled5","presence-sled6",
> /*I0-I7*/ "REV_ID0","","REV_ID1","REV_ID2",
> - "","","","",
> + "","BSM_FLASH_WP_STATUS","BMC_TPM_PRES","",
> /*J0-J7*/ "","","","","","","","",
> /*K0-K7*/ "","","","","","","","",
> - /*L0-L7*/ "","","","","","","","",
> + /*L0-L7*/ "","","","","","BMC_RTC_INT","","",
> /*M0-M7*/ "ALERT_SLED1","ALERT_SLED2",
> "ALERT_SLED3","ALERT_SLED4",
> "ALERT_SLED5","ALERT_SLED6",
> @@ -744,19 +745,20 @@
> /*N0-N7*/ "","","","","","","","",
> /*O0-O7*/ "","","","",
> "","BOARD_ID0","BOARD_ID1","BOARD_ID2",
> - /*P0-P7*/ "","","","","","","","",
> + /*P0-P7*/ "","","","","","","","BMC_HEARTBEAT",
> /*Q0-Q7*/ "","","","","","","","",
> /*R0-R7*/ "","","","","","","","",
> /*S0-S7*/ "","","","BAT_DETECT",
> "BMC_BT_WP0","BMC_BT_WP1","","",
> /*T0-T7*/ "","","","","","","","",
> /*U0-U7*/ "","","","","","","","",
> - /*V0-V7*/ "","RST_BMC_MVL","","",
> + /*V0-V7*/ "PWRGD_CNS_PSU","RST_BMC_MVL","","PSU_PRSNT",
> "USB2_SEL0_A","USB2_SEL1_A",
> "USB2_SEL0_B","USB2_SEL1_B",
> /*W0-W7*/ "RST_FRONT_IOEXP","","","","","","","",
> /*X0-X7*/ "","","","","","","","",
> - /*Y0-Y7*/ "","","BSM_FLASH_LATCH","","","","","",
> + /*Y0-Y7*/ "BMC_SELF_HW_RST","BSM_PRSNT","BSM_FLASH_LATCH","",
> + "","","","",
> /*Z0-Z7*/ "","","","","","","","";
> };
>
> --
> 2.17.1
>
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node
[not found] ` <20220211014347.24841-11-potin.lai@quantatw.com>
@ 2022-02-11 22:19 ` Patrick Williams
0 siblings, 0 replies; 3+ messages in thread
From: Patrick Williams @ 2022-02-11 22:19 UTC (permalink / raw)
To: Potin Lai
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1264 bytes --]
On Fri, Feb 11, 2022 at 09:43:47AM +0800, Potin Lai wrote:
> Remove redundant i2c1 node.
> Disable in-chip rtc, use external rtc (pcf85263) instead.
A bit of "why" on the RTC change might be useful. I suspect it has to do
with where battery-backing is for the RTC in hardware.
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index 946107bd8bc7..fb62a67cfeed 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -205,10 +205,6 @@
> };
> };
>
> -&rtc {
> - status = "okay";
> -};
> -
> &fmc {
> status = "okay";
> flash@0 {
> @@ -387,10 +383,6 @@
> };
> };
>
> -&i2c1 {
> - status = "okay";
> -};
> -
> &i2c2 {
> status = "okay";
> ina230@45 {
> @@ -680,6 +672,7 @@
> };
>
> rtc@51 {
> + /* in-chip rtc disabled, use this external rtc instead */
> compatible = "nxp,pcf85263";
> reg = <0x51>;
> };
> --
> 2.17.1
>
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 00/10] arch: arm: dts: update Facebook Bletchley BMC
[not found] <20220211014347.24841-1-potin.lai@quantatw.com>
[not found] ` <20220211014347.24841-4-potin.lai@quantatw.com>
[not found] ` <20220211014347.24841-11-potin.lai@quantatw.com>
@ 2022-02-11 22:20 ` Patrick Williams
2 siblings, 0 replies; 3+ messages in thread
From: Patrick Williams @ 2022-02-11 22:20 UTC (permalink / raw)
To: Potin Lai
Cc: Rob Herring, Joel Stanley, Andrew Jeffery, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1300 bytes --]
On Fri, Feb 11, 2022 at 09:43:37AM +0800, Potin Lai wrote:
> Update Facebook Bletchley BMC devicetree base on EVT HW design and
> rebase sled numbering to 1-based for OpenBMC multi-host
>
> This patch series are modified from
> LINK: https://lore.kernel.org/all/20220209100413.23714-1-potin.lai@quantatw.com/
>
> Potin Lai (10):
> arch: arm: dts: bletchley: switch sled numbering to 1-based
> arch: arm: dts: bletchley: separate leds into multiple groups
> arch: arm: dts: bletchley: update gpio-line-names
> arch: arm: dts: bletchley: update fmc configurations
> arch: arm: dts: bletchley: switch to spi-gpio for spi2
> arch: arm: dts: bletchley: add interrupt support for sled io expander
> arch: arm: dts: bletchley: add shunt-resistor for ADM1278
> arch: arm: dts: bletchley: add INA230 sensor on each sled
> arch: arm: dts: bletchley: enable mdio3 bus
> arch: arm: dts: bletchley: cleanup redundant node
>
> .../dts/aspeed-bmc-facebook-bletchley.dts | 303 +++++++++++-------
> 1 file changed, 194 insertions(+), 109 deletions(-)
>
> --
> 2.17.1
>
Left a few minor comments on potential improvements to the commit messages, but
otherwise whole series is:
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-11 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220211014347.24841-1-potin.lai@quantatw.com>
[not found] ` <20220211014347.24841-4-potin.lai@quantatw.com>
2022-02-11 22:16 ` [PATCH 03/10] arch: arm: dts: bletchley: update gpio-line-names Patrick Williams
[not found] ` <20220211014347.24841-11-potin.lai@quantatw.com>
2022-02-11 22:19 ` [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node Patrick Williams
2022-02-11 22:20 ` [PATCH 00/10] arch: arm: dts: update Facebook Bletchley BMC Patrick Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).