From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B00DEC433FE for ; Mon, 14 Feb 2022 14:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iYLlXk4ReyLNMemH7ooOIw7M4aMVVFCeUuy0UbqS5XA=; b=THASVoTYFvguWM sntrhfM1E0GZp/I2dyKYNPw2K+wF5+L5C+J+eWgGSCBuVtiYNyy/7jTjkpVaJPaDOcemod9iMEoLJ XBooyb7ASAzntWm5dsaWUckKl0o2F0dLtcPUWWzbaOrlCsnPDJ8Y2VUUs3C+IuZhrYNNBoDmUAUHl dfRILR41z57qReHW4C4/ASUTLIM8NQutVoztP0Tk7P3CgkwkC8WIAL4o38KIC09xvdW7/WlWvTivT CcwAhv3/mWcsQeamZfoGIRnvwljuR6P0wbqZraDti206D9xmEnj6HNQG76vA6RtSJlfRQ5pHQq/4B YdZuTVEb22jETpi46yaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJcT2-00FgTa-A9; Mon, 14 Feb 2022 14:36:40 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJcSy-00FgSs-AG; Mon, 14 Feb 2022 14:36:37 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: alyssa) with ESMTPSA id A7D7D1F43ABE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644849393; bh=wf2zalaLWrqugtdnfYQlVBuLQAqyoGaCbOOlATCb0jo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SlZrULvrjsLlfdwVpA7hx9V7Rx7uDIEctf8kIovI/mrTeCkhQpi3v3M0r7xPiIf88 Rx9MNAhdCyTF7hvvryM3MTBXzbC/2s1KnXlHc6i2K38hVEjgRVGocwuTuM2UYf8Djt dysTtfPYtvMyGcCQzUKrWTn/dMY61QNjj9UVIfr43DirOTrfh5WNUdK9teFwdN5CSG 86Go8Ge6NMIuuCpVfUPP4FLSaDc5iuT+JLtmWum1Hwlt1dkIOOAwR7gWQiNCAm3y6x 0zH3GsJqYcaWGGcUXI5koAtagt7c41iofN01svFYyRkwzoVH5Gd8uUzD0eMkZ1ZDBs /PVdQTHEBpi1g== Date: Mon, 14 Feb 2022 09:36:26 -0500 From: Alyssa Rosenzweig To: AngeloGioacchino Del Regno Cc: matthias.bgg@gmail.com, yongqiang.niu@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] soc: mediatek: mt8192-mmsys: Fix dither to dsi0 path's input sel Message-ID: References: <20220128142056.359900-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128142056.359900-1-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_063636_534948_CAAD4877 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > In commit d687e056a18f ("soc: mediatek: mmsys: Add mt8192 mmsys routing table"), > the mmsys routing table for mt8192 was introduced but the input selector > for DITHER->DSI0 has no value assigned to it. > > This means that we are clearing bit 0 instead of setting it, blocking > communication between these two blocks; due to that, any display that > is connected to DSI0 will not work, as no data will go through. > The effect of that issue is that, during bootup, the DRM will block for > some time, while atomically waiting for a vblank that never happens; > later, the situation doesn't get better, leaving the display in a > non-functional state. > > To fix this issue, fix the route entry in the table by assigning the > dither input selector to MT8192_DISP_DSI0_SEL_IN. > > Fixes: d687e056a18f ("soc: mediatek: mmsys: Add mt8192 mmsys routing table") > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/soc/mediatek/mt8192-mmsys.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mt8192-mmsys.h b/drivers/soc/mediatek/mt8192-mmsys.h > index 6f0a57044a7b..6aae0b12b6ff 100644 > --- a/drivers/soc/mediatek/mt8192-mmsys.h > +++ b/drivers/soc/mediatek/mt8192-mmsys.h > @@ -53,7 +53,8 @@ static const struct mtk_mmsys_routes mmsys_mt8192_routing_table[] = { > MT8192_AAL0_SEL_IN_CCORR0 > }, { > DDP_COMPONENT_DITHER, DDP_COMPONENT_DSI0, > - MT8192_DISP_DSI0_SEL_IN, MT8192_DSI0_SEL_IN_DITHER0 > + MT8192_DISP_DSI0_SEL_IN, MT8192_DSI0_SEL_IN_DITHER0, > + MT8192_DSI0_SEL_IN_DITHER0 > }, { > DDP_COMPONENT_RDMA0, DDP_COMPONENT_COLOR0, > MT8192_DISP_RDMA0_SOUT_SEL, MT8192_RDMA0_SOUT_COLOR0, Tested-by: Alyssa Rosenzweig _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel