From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ACE8C433EF for ; Tue, 15 Feb 2022 05:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f3uzVnb1n8AeD8VQTKGHO3WWGCH8TlYWBuybYEggytc=; b=J5+ab9m08d1xRs 2ZmUp47aVa9ezk3jgjjY6edcXNUa3hp+RRFy6JxusiBvnETx8DRXDw7ITjjcrYhd6dAYwxtcJPD3a Wo15uwSTZrCnZZuuPrM+ctOUmndxw/QDYLUgrOd4MMOuhYrH63O6qAJXHu8YP5kYFxHD3W5sx/WYY y4edOYvwzk9hpNOuB5NhSFmAJIIjL0rt5njqNjmHuWNXMNlkFbCCf4YIf1U73UcfU2jve2p9wr3eR iNuaGq0H6ifxxo1Pi6I/FEKpUDqABvDE6w3+4+7WKPLlhXHwZC1yxk4Fp2ZQVvcrKk1OQMI1bb9Di Ok6+YnZNpeCsyMWDYjaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJqM6-000GIh-PK; Tue, 15 Feb 2022 05:26:26 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJqM2-000GI3-Sm for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 05:26:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D4123B8164B; Tue, 15 Feb 2022 05:26:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC3A4C340EC; Tue, 15 Feb 2022 05:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644902779; bh=Mrc5n5STDODQ2jMunDINBcbrAtfkEKJpZ3JG+krR1YI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gKKOwZ+N0eV8TuLw7amp5W2ll3X9mcTKYxwjuV56J/QgDGf0mIIB0sL8DdxUB4MpS EtKIad7aFRfev1rcjOSBZIKqVpt3X/Fuk93NHyg6VvDfEqkhGX4cZZZQ/r2jbzFb1H 77qSInjQVSuJ3EH1msLWQTZp7oSQPs/UTFIBSApVj5wSVm0uCgTChYTVp0FmPR2x9d ZbO2Vp2IKPGKUZs2/kuhrskTU7dheXHfrgzKO37Ez38lwZUP33sYya80eTiSfOta+T WS8tYx4PJYnzubrWtbN4MGrD/lLupS8/Hx7YXT/49iMF4nLsdcB8MoYsuLfOOzDTQT cjefr0G+0ncWQ== Date: Tue, 15 Feb 2022 10:56:15 +0530 From: Vinod Koul To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ludovic.desroches@microchip.com, tudor.ambarus@microchip.com Subject: Re: [PATCH -next] dmaengine: at_xdmac: Fix missing unlock in at_xdmac_tasklet() Message-ID: References: <20220107024047.1051915-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220107024047.1051915-1-yangyingliang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_212623_123221_8AA4D054 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07-01-22, 10:40, Yang Yingliang wrote: > Add the missing unlock before return from at_xdmac_tasklet(). Applied, thanks > > Fixes: e77e561925df ("dmaengine: at_xdmac: Fix race over irq_status") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/dma/at_xdmac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index a1da2b4b6d73..1476156af74b 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -1681,8 +1681,10 @@ static void at_xdmac_tasklet(struct tasklet_struct *t) > __func__, atchan->irq_status); > > if (!(atchan->irq_status & AT_XDMAC_CIS_LIS) && > - !(atchan->irq_status & error_mask)) > + !(atchan->irq_status & error_mask)) { > + spin_unlock_irq(&atchan->lock); > return; > + } > > if (atchan->irq_status & error_mask) > at_xdmac_handle_error(atchan); > -- > 2.25.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel