From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3DC1C433F5 for ; Tue, 15 Feb 2022 07:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUKu7Fr+zjQti60MhkHFJwmP6sK+Ml4MzVW90vb/uO8=; b=SLuJPqwNlFLFQZ qTf98kwx7pXBr9809HkSSmsJEixwl9iT6Y5FchOWsZd0kqCwVtxna+N7ncGpEzBsy8nD1c6vjo4oR BZacxTlol39dIcSbgMVxzzCybSDBdJaxR/fIPXmHU/MsvBhKTVEGe9UficLXhyKfimWMFPVafrX13 Zi+CHv0l5llHJspYTp7Mta6a28XbP3y9gavZoU5TuP91qaDokpcXm7BJjGJ9Q0UXu+uldZChEFUdz xZ9uKltKalFV0XcMbxvcAuNAm8RzSyADvhpaHezKVbwh25am/Ctf+AxSlFo5e/Waj7vbhqFtBL7Y5 FBSsOWn9ez2TOMyC6NmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJsiX-001QW2-IF; Tue, 15 Feb 2022 07:57:45 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJsiT-001QTI-CB for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 07:57:43 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B8255315; Tue, 15 Feb 2022 08:57:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644911860; bh=M9ucpBbW77iBzO+bROGqdVFmWgUTEjE6u+Yad8gmBFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VBvH9nWqyZS82mjoadB1pYAFLHHio7BFcHg296IMKuPWU4UQJCZk7GBX4iDtXZ+o2 Jqx96trKq5H96YSg8zPMW5kBHJKB1w2sScWr9BtypQ2jRJ9aDpu3pCUh3z5dttjurk 5rLGmp7hArP+pisKXKyrUBxi+tTkWTpM2I3ML6xQ= Date: Tue, 15 Feb 2022 09:57:33 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Dorota Czaplejewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/9] media: imx: imx7_mipi_csis: store colorspace in set_fmt as well Message-ID: References: <20220211142752.779952-1-alexander.stein@ew.tq-group.com> <20220211142752.779952-6-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220211142752.779952-6-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_235741_599250_B59ADC7B X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Fri, Feb 11, 2022 at 03:27:48PM +0100, Alexander Stein wrote: > Without this the default (SMPTE 170M) from init_cfg stays unchanged. > Even after configuring 'srgb' colorspace (or 'raw') > $ media-ctl -V "'csis-32e30000.mipi-csi':0 [colorspace:srgb]" > the colorspace does not change at all: > $ media-ctl --get-v4l2 "'csis-32e30000.mipi-csi':0" > [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:smpte170m xfer:709 > ycbcr:601 quantization:lim-range] > > Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart As this change is independent from the previous patches in the series, I'll take it in my tree and will send a pull request for v5.18. > --- > Changes in v2: > * Store other colorspace-related fields as well > > drivers/staging/media/imx/imx7-mipi-csis.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index a22d0e6b3d44..388cfd012212 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -1062,6 +1062,10 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd, > fmt->code = csis_fmt->code; > fmt->width = sdformat->format.width; > fmt->height = sdformat->format.height; > + fmt->colorspace = sdformat->format.colorspace; > + fmt->quantization = sdformat->format.quantization; > + fmt->xfer_func = sdformat->format.xfer_func; > + fmt->ycbcr_enc = sdformat->format.ycbcr_enc; > > sdformat->format = *fmt; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel