From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43305C433F5 for ; Tue, 15 Feb 2022 13:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jh++MGlaV8069hS0tmEl/8J4dhL2RKcsxYT3cUKvhAw=; b=Ck8nHSFzBK8yDW U45kDBDcApCeZTgrzaA2jBRBPpBbwsZCp+Mmt89TwLDwlVN6T/VMjV1qhoDSJPYDYQ8mUITlxtyWp tUw6WyykaOnup+t6p2+3Rr2SqbDfnXrV14UnENr+lLAqTbDrSlgxmQ6mpwdKVvAxHvTlyusJu6Sl9 GF3IcaoajgndWOT8bAGW80MfB0jFiaBNOAYUqjEJO4DNU4428xwWydNG8kHpst1EFZ14OcsnLJjru rlkYkld0QUplKhd2LGZPMr+atqJfMcwEuEYWIQ+M/N8MsCcEMYqkNotN4VsEJWWws2GaE6vXavj+Y PjCXUj+2meRHbCEoZazQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJy3j-002sNl-Sq; Tue, 15 Feb 2022 13:39:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJy3g-002sMz-4s for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 13:39:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E569C1480; Tue, 15 Feb 2022 05:39:54 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.89.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 186353F718; Tue, 15 Feb 2022 05:39:52 -0800 (PST) Date: Tue, 15 Feb 2022 13:39:48 +0000 From: Mark Rutland To: madvenka@linux.microsoft.com Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() Message-ID: References: <95691cae4f4504f33d0fc9075541b1e7deefe96f> <20220117145608.6781-1-madvenka@linux.microsoft.com> <20220117145608.6781-7-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220117145608.6781-7-madvenka@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_053956_263159_839AFA3F X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: > From: "Madhavan T. Venkataraman" > > Rename the arguments to unwind() for better consistency. Also, use the > typedef stack_trace_consume_fn for the consume_entry function as it is > already defined in linux/stacktrace.h. > > Signed-off-by: Madhavan T. Venkataraman How about: | arm64: align with common stracktrace naming | | For historical reasons, the naming of parameters and their types in the arm64 | stacktrace code differs from that used in generic code and other | architectures, even though the types are equivalent. | | For consistency and clarity, use the generic names. Either way: Reviewed-by: Mark Rutland Mark. > --- > arch/arm64/kernel/stacktrace.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > index 1b32e55735aa..f772dac78b11 100644 > --- a/arch/arm64/kernel/stacktrace.c > +++ b/arch/arm64/kernel/stacktrace.c > @@ -181,12 +181,12 @@ static int notrace unwind_next(struct unwind_state *state) > NOKPROBE_SYMBOL(unwind_next); > > static void notrace unwind(struct unwind_state *state, > - bool (*fn)(void *, unsigned long), void *data) > + stack_trace_consume_fn consume_entry, void *cookie) > { > while (1) { > int ret; > > - if (!fn(data, state->pc)) > + if (!consume_entry(cookie, state->pc)) > break; > ret = unwind_next(state); > if (ret < 0) > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel