From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50A0CC433F5 for ; Tue, 15 Feb 2022 22:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lu2A4QEehWH3/6qKxXPEAcBeJOLeCz92h2ZUcG7RJ+c=; b=2uZ6EmeOqYLbne Kq199SrrNnRLuMseZEEVe8sGzMs0zGmoRs2Z+JGjZafVl6JeYTe29FZuwhs/m0fMpFnflzh7ASOrj iYfV09Mf8EMueP3+IK4AnVmMXPyoH9dzm+4VZ5f8KSZTNI/aCzPGXEakL7MiBpCVC5k9cwmeRViGn ua+78kRdhBz/7YRGS9Twl0NlCE18FjuEmu8ctJjzxNJ6brWJg50sw9ih3MBwQZchZhYZFulbYx58B eMG/wb8fUlI++EuW905af4ZoTEnEHIZl0MgQ18KluNzDm8ezNrdN5SQYyW7zlezy64/jo/4VhTbu+ MbVEX2hlNGauMVn0Orkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK67s-004mCq-BR; Tue, 15 Feb 2022 22:16:48 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK67o-004mCC-43 for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 22:16:46 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1D0BC240002; Tue, 15 Feb 2022 22:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1644963401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fdlEzyM6wV1U+RwGyQK9WmkMI5mhDJdmK2glPQLND8k=; b=PZbPwJgwrtf0MbAXbKC/ZGhSkjZPn+1Ph7P9YrP6UByMDHYK9Ox9Ed3riiim95aPtCzUvg OsR1svKQug1ksFzzDa8wIezWiBEj4Qj0zzEAsPUFVUYmL2/E5ptK/KQbpmvm6ntNvpV8NM 5ySJrTfxnnCy01hO1vnbrB0lhkHL9wfinR0WvEGG3Rw2sTz3hTvp8MIjjhtwN1k/ZJrg4w 43QqcKrBMyRXTXqiSxdWPFUa7MSiL50Q2M/3KpaownXvw0MrC5IHL7sEvlup7EFslkNFAT tQpBEcoGIq6h8MnT5X5Nrjs7rK4DWjlGKjljq0wX109XIAM7nVdLDufvSDXK1g== Date: Tue, 15 Feb 2022 23:16:39 +0100 From: Alexandre Belloni To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-sunxi@lists.linux.dev, Alessandro Zummo , Michael Turquette , linux-arm-kernel@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH v3 0/6] clk: sunxi-ng: Add a RTC CCU driver Message-ID: References: <20220203021736.13434-1-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220203021736.13434-1-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_141644_463911_F847B75C X-CRM114-Status: GOOD ( 31.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 02/02/2022 20:17:30-0600, Samuel Holland wrote: > This patch series adds a CCU driver for the RTC in the H616, R329 and > D1. The extra patch at the end of this series shows how it would be > explanded to additional hardware variants. > > The driver is intended to support the existing binding used for the H6, > but also an updated binding which includes all RTC input clocks. > > A future patch series could add functionality to the driver to manage > IOSC calibration at boot and during suspend/resume. > > It may be possible to support all of these hardware variants without > adding this new driver, by adding them to the existing RTC clock > provider, but I'm concerned about the complexity there, without any of > the CCU abstraction. > > Changes in v3: > - Add/fix several maxItems attributes for clocks and clock-items > - Drop the SUNXI_CCU_MUX_HW_WITH_KEY macro, since it is no longer used. > - Also drop the patch adding the SUNXI_CCU_MUX_DATA_WITH_GATE macro. > - Rebase on v5.17-rc2 (CCU module support series was merged). > - Move IOSC calibration control to prepare/unprepare operations. > - Declare several `struct clk_init_data`s as static variables (instead > of as anonymous) so they can be modified from the probe function > without casting away const. > - Instead of creating two copies of clocks which may or may not have > muxes, change the number of parents to 1 in the non-mux case. > - Use a single CCU description for all variants. > - Use IS_REACHABLE to guard the call to sun6i_rtc_ccu_probe. > - Allow the driver to be built on !ARM64 (i.e. RISCV). > - Rebase example on top of driver changes, and drop the second example. > > Changes in v2: > - Combine "const"s to "enum" in the DT binding compatible property. > - Properly update the DT binding clocks and clock-names properties. > - Rebase on v2 of the CCU module support series. > - Load the CCU driver from the RTC driver, not as an OF provider. > > Samuel Holland (6): > dt-bindings: rtc: sun6i: Clean up repetition > dt-bindings: rtc: sun6i: Add H616, R329, and D1 support > rtc: sun6i: Enable the bus clock when provided I've now applied 1-3/6, thanks! > clk: sunxi-ng: mux: Allow muxes to have keys > clk: sunxi-ng: Add support for the sun6i RTC clocks > [DO NOT MERGE] clk: sunxi-ng: sun6i-rtc: Add support for H6 > > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 84 +++- > drivers/clk/sunxi-ng/Kconfig | 5 + > drivers/clk/sunxi-ng/Makefile | 2 + > drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 393 ++++++++++++++++++ > drivers/clk/sunxi-ng/ccu-sun6i-rtc.h | 15 + > drivers/clk/sunxi-ng/ccu_common.h | 1 + > drivers/clk/sunxi-ng/ccu_mux.c | 7 + > drivers/rtc/rtc-sun6i.c | 48 ++- > include/dt-bindings/clock/sun6i-rtc.h | 10 + > include/linux/clk/sunxi-ng.h | 2 + > 10 files changed, 538 insertions(+), 29 deletions(-) > create mode 100644 drivers/clk/sunxi-ng/ccu-sun6i-rtc.c > create mode 100644 drivers/clk/sunxi-ng/ccu-sun6i-rtc.h > create mode 100644 include/dt-bindings/clock/sun6i-rtc.h > > -- > 2.33.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel