From: Wolfram Sang <wsa@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: qii.wang@mediatek.com, matthias.bgg@gmail.com,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH] i2c: busses: i2c-mt65xx: Simplify with clk-bulk
Date: Tue, 1 Mar 2022 22:45:01 +0100 [thread overview]
Message-ID: <Yh6T3RSfvcXCi4sb@ninjato> (raw)
In-Reply-To: <8725a111-0ee2-8935-86b5-01c61774a628@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 998 bytes --]
On Mon, Feb 14, 2022 at 12:26:30PM +0100, AngeloGioacchino Del Regno wrote:
> Il 18/01/22 14:33, AngeloGioacchino Del Regno ha scritto:
> > Since depending on the SoC or specific bus functionality some clocks
> > may be optional, we cannot get the benefit of using devm_clk_bulk_get()
> > but, by migrating to clk-bulk, we are able to remove the custom functions
> > mtk_i2c_clock_enable() and mtk_i2c_clock_disable(), increasing common
> > APIs usage, hence (lightly) decreasing kernel footprint.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> > drivers/i2c/busses/i2c-mt65xx.c | 127 +++++++++++++-------------------
> > 1 file changed, 51 insertions(+), 76 deletions(-)
> >
>
> Hello,
> this is a friendly ping to request review on this patch as to avoid forgetting it.
>
> Adding context, I have tested this patch on multiple (older/newer) MediaTek
> platforms.
Qii Wang, what do you think about this patch?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-01 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 13:33 [PATCH] i2c: busses: i2c-mt65xx: Simplify with clk-bulk AngeloGioacchino Del Regno
2022-02-14 11:26 ` AngeloGioacchino Del Regno
2022-03-01 21:45 ` Wolfram Sang [this message]
2022-03-02 11:36 ` Qii Wang
2022-03-02 21:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh6T3RSfvcXCi4sb@ninjato \
--to=wsa@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox