* [PATCH] misc: atmel-ssc: Handle error for clk_prepare_enable
@ 2022-03-02 8:43 Jiasheng Jiang
2022-03-02 9:48 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2022-03-02 8:43 UTC (permalink / raw)
To: codrin.ciubotariu, arnd, gregkh, nicolas.ferre, alexandre.belloni,
claudiu.beznea
Cc: linux-arm-kernel, linux-kernel, Jiasheng Jiang
As the potential failure of the clk_prepare_enable(),
it should be better to check it and return error if fails.
Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/misc/atmel-ssc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index d6cd5537126c..c76ca234af4b 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -192,6 +192,7 @@ static int ssc_probe(struct platform_device *pdev)
struct resource *regs;
struct ssc_device *ssc;
const struct atmel_ssc_platform_data *plat_dat;
+ int ret;
ssc = devm_kzalloc(&pdev->dev, sizeof(struct ssc_device), GFP_KERNEL);
if (!ssc) {
@@ -226,7 +227,10 @@ static int ssc_probe(struct platform_device *pdev)
}
/* disable all interrupts */
- clk_prepare_enable(ssc->clk);
+ ret = clk_prepare_enable(ssc->clk);
+ if (ret)
+ return ret;
+
ssc_writel(ssc->regs, IDR, -1);
ssc_readl(ssc->regs, SR);
clk_disable_unprepare(ssc->clk);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: atmel-ssc: Handle error for clk_prepare_enable
2022-03-02 8:43 [PATCH] misc: atmel-ssc: Handle error for clk_prepare_enable Jiasheng Jiang
@ 2022-03-02 9:48 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2022-03-02 9:48 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: arnd, gregkh, linux-kernel, codrin.ciubotariu, claudiu.beznea,
linux-arm-kernel
On 02/03/2022 16:43:19+0800, Jiasheng Jiang wrote:
> As the potential failure of the clk_prepare_enable(),
> it should be better to check it and return error if fails.
>
this will never ever fail, this patch doesn't fix any actual issue
> Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/misc/atmel-ssc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index d6cd5537126c..c76ca234af4b 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -192,6 +192,7 @@ static int ssc_probe(struct platform_device *pdev)
> struct resource *regs;
> struct ssc_device *ssc;
> const struct atmel_ssc_platform_data *plat_dat;
> + int ret;
>
> ssc = devm_kzalloc(&pdev->dev, sizeof(struct ssc_device), GFP_KERNEL);
> if (!ssc) {
> @@ -226,7 +227,10 @@ static int ssc_probe(struct platform_device *pdev)
> }
>
> /* disable all interrupts */
> - clk_prepare_enable(ssc->clk);
> + ret = clk_prepare_enable(ssc->clk);
> + if (ret)
> + return ret;
> +
> ssc_writel(ssc->regs, IDR, -1);
> ssc_readl(ssc->regs, SR);
> clk_disable_unprepare(ssc->clk);
> --
> 2.25.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-02 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-02 8:43 [PATCH] misc: atmel-ssc: Handle error for clk_prepare_enable Jiasheng Jiang
2022-03-02 9:48 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).