From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BF3CC433F5 for ; Mon, 21 Feb 2022 06:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o6IMaUHtQZRH+pD5oqnZzFKJ6dS67fPcCSRQQJga3zY=; b=N2SOvSmCsgsjCZ YehsQi6wgw4hAKZMpMAw4Pwstwa31pDbjVjJcq4o6hViRqs9qjp3xGETDR7nujHnDf/GtpLP1W+XE ZLjha5pvinTKfykxbH6GfEmLLAfZOAQC52etBfooHV4DT+3EWR+4FWa8ojZIKwCxZuFD2Q6fbKBfj DmeADEEMwahb74cFZLgytt8D/SE+lYuOp+fkXC7koGVTiKQHOD99C4397JRdUBcZCbpTF//X1x0Yv DPwB5dZPZyCTJSL0ODpQPA27TmOurR8OT0s07HB+aiZr+ZeRX+sf2jsVElRc6xZweTfpfOgXbLLfK O4DWESZAqtBPiifbJzUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM2Er-003hw0-Cs; Mon, 21 Feb 2022 06:32:02 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM2Ca-003h6p-4z for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 06:29:42 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F213E482; Mon, 21 Feb 2022 07:29:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645424974; bh=hgNxG+FXreRZFAxVoZBmRSlabgNqhgtMOFOBhANIiK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxS9G4NXMQ9c9aj02YYSYFz4t4dBy8nOGPSxZ5fsHDzfsYnkdXt6kJ4o+SyyxYgOX 1VRNKPPbxsY8Df5uO5dlwnmVXlfI1SSAmLe4AL68zYW+XVog6uppFmT4Z5XgI91QFe /qVLmbFsSzCZQtw7L0ooRzShjb2wMOT9kpp3oSy8= Date: Mon, 21 Feb 2022 08:29:24 +0200 From: Laurent Pinchart To: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org, Lucas Stach , Pengutronix Kernel Team , Sascha Hauer , Fabio Estevam , NXP Linux Team , Peng Fan , Marek Vasut Subject: Re: [PATCH] soc: imx: gpcv2: Fix clock disabling imbalance in error path Message-ID: References: <20220218215720.26241-1-laurent.pinchart@ideasonboard.com> <20220221055929.GM2249@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220221055929.GM2249@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220220_222940_430996_623EB82E X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, On Mon, Feb 21, 2022 at 01:59:29PM +0800, Shawn Guo wrote: > On Fri, Feb 18, 2022 at 11:57:20PM +0200, Laurent Pinchart wrote: > > The imx_pgc_power_down() starts by enabling the domain clocks, and thus > > disables them in the error path. Commit 18c98573a4cf ("soc: imx: gpcv2: > > add domain option to keep domain clocks enabled") made the clock enable > > conditional, but forgot to add the same condition to the error path. > > This can result in a clock enable/disable imbalance. Fix it. > > > > Fixes: 18c98573a4cf ("soc: imx: gpcv2: add domain option to keep domain clocks enabled") > > Signed-off-by: Laurent Pinchart > > Applied, thanks! Thank you. I've noticed that Lucas' reviewed-by tag didn't end up in the commit in your imx/fixes branch. Depending on your rebase policy with that branch, you may want to ammend the commit. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel