From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13641C433F5 for ; Mon, 21 Feb 2022 13:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kPYQP1CItB2lcggAfhVAXTND+kQyXQ99xEt0ZZzaS0g=; b=XN29xlOoCAWTRm MAHXVyeZtebPh8iHh6I/p2SERpqOQhzJOJ2MkhVa42S/jQWr8rtsZCfpnAHFgfTLUPp1YPZDJzDhh Tuc5fsTc1834+WOfN/VSo855FTCRp0qvT2SUXBAdShyNiutlOLxOQ6Ni6b8ajY63zmZ+tnToQvyUG Fp9B1Vz8RP0BHnCMDYezJyCfqW6UMQMNedjr+XsU5ynPlc3/dCZ0X1YNOzmv0dT0Aox7ARAhlmj1h +1C7Znr3jYH5QU7eGns7CM3BLi2oAOpmicz99TpYtfkzslO4k3uCcnVnCin8hduTDE9htwal2pSpw 6T30wjMDWn05PHcS7ucQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8pK-005wJg-Ho; Mon, 21 Feb 2022 13:34:07 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8BA-005kFj-PS; Mon, 21 Feb 2022 12:52:38 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BA63482; Mon, 21 Feb 2022 13:52:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645447953; bh=wZf75ab33ig0Wo1mulG1VIJgjrkjwCuvAbAR2SNt/W8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DiC0TC3VeFgDJrbzHx1FIa8os2YjyBOAXeDB/TuAbHrYiZ87b0iRuVOrqe6KnT5zW vGXeE2jPWJkW0P6YWWW2BXkaL4FW140SkKxODDW3X6zj27QTOnG/9I4gGPhUaoGZ1j yxxrR/VjC/DuefJ7Ca0AusZ7ol4NmHoC4Yd546e4= Date: Mon, 21 Feb 2022 14:52:23 +0200 From: Laurent Pinchart To: Stefan Wahren Cc: Maxime Ripard , Jean-Michel Hautbois , dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, kernel-list@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, lukasz@jany.st, mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org, tomi.valkeinen@ideasonboard.com, bcm-kernel-feedback-list@broadcom.com, Florian Fainelli Subject: Re: [PATCH v5 03/11] dt-bindings: media: Add bindings for bcm2835-unicam Message-ID: References: <20220208155027.891055-1-jeanmichel.hautbois@ideasonboard.com> <20220208155027.891055-4-jeanmichel.hautbois@ideasonboard.com> <20220214093954.5y4jbqcddmwhgxr5@houat> <7ba0d8e7-72b9-d139-f29f-45a803ca2fdb@i2se.com> <4f809de2-24ee-dd9f-6354-2ce770a3ff4d@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4f809de2-24ee-dd9f-6354-2ce770a3ff4d@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_045237_032877_1AE39FA7 X-CRM114-Status: GOOD ( 45.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On Mon, Feb 21, 2022 at 01:45:10PM +0100, Stefan Wahren wrote: > Am 21.02.22 um 08:10 schrieb Laurent Pinchart: > > On Mon, Feb 14, 2022 at 12:32:59PM +0100, Stefan Wahren wrote: > >> Am 14.02.22 um 10:54 schrieb Laurent Pinchart: > >>> On Mon, Feb 14, 2022 at 10:39:54AM +0100, Maxime Ripard wrote: > >>>> On Sun, Feb 13, 2022 at 04:48:45PM +0100, Stefan Wahren wrote: > >>>>> as someone with a little more insight to the clocks, i like to know your > >>>>> opinion about the bcm2835-unicam binding. > >>>>> > >>>>> Am 08.02.22 um 16:50 schrieb Jean-Michel Hautbois: > >>>>>> Introduce the dt-bindings documentation for bcm2835 CCP2/CSI2 Unicam > >>>>>> camera interface. > >>>>>> > >>>>>> Signed-off-by: Dave Stevenson > >>>>>> Signed-off-by: Naushir Patuck > >>>>>> Signed-off-by: Jean-Michel Hautbois > >>>>>> Reviewed-by: Laurent Pinchart > >>>>>> > >>>>>> --- > >>>>>> v4: > >>>>>> - make MAINTAINERS its own patch > >>>>>> - describe the reg and clocks correctly > >>>>>> - use a vendor entry for the number of data lanes > >>>>>> --- > >>>>>> .../bindings/media/brcm,bcm2835-unicam.yaml | 117 ++++++++++++++++++ > >>>>>> 1 file changed, 117 insertions(+) > >>>>>> create mode 100644 Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >>>>>> > >>>>>> diff --git a/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml b/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >>>>>> new file mode 100644 > >>>>>> index 000000000000..1938ace23b3d > >>>>>> --- /dev/null > >>>>>> +++ b/Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > >>>>>> @@ -0,0 +1,117 @@ > >>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>>>> +%YAML 1.2 > >>>>>> +--- > >>>>>> +$id: http://devicetree.org/schemas/media/brcm,bcm2835-unicam.yaml# > >>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>>> + > >>>>>> +title: Broadcom BCM283x Camera Interface (Unicam) > >>>>>> + > >>>>>> +maintainers: > >>>>>> + - Raspberry Pi Kernel Maintenance > >>>>>> + > >>>>>> +description: |- > >>>>>> + The Unicam block on BCM283x SoCs is the receiver for either > >>>>>> + CSI-2 or CCP2 data from image sensors or similar devices. > >>>>>> + > >>>>>> + The main platform using this SoC is the Raspberry Pi family of boards. On > >>>>>> + the Pi the VideoCore firmware can also control this hardware block, and > >>>>>> + driving it from two different processors will cause issues. To avoid this, > >>>>>> + the firmware checks the device tree configuration during boot. If it finds > >>>>>> + device tree nodes whose name starts with 'csi' then it will stop the firmware > >>>>>> + accessing the block, and it can then safely be used via the device tree > >>>>>> + binding. > >>>>>> + > >>>>>> +properties: > >>>>>> + compatible: > >>>>>> + const: brcm,bcm2835-unicam > >>>>>> + > >>>>>> + reg: > >>>>>> + items: > >>>>>> + - description: Unicam block. > >>>>>> + - description: Clock Manager Image (CMI) block. > >>>>>> + > >>>>>> + reg-names: > >>>>>> + items: > >>>>>> + - const: unicam > >>>>>> + - const: cmi > >>>>>> + > >>>>>> + interrupts: > >>>>>> + maxItems: 1 > >>>>>> + > >>>>>> + clocks: > >>>>>> + items: > >>>>>> + - description: Clock to drive the LP state machine of Unicam. > >>>>>> + - description: Clock for the VPU (core clock). > >>>>>> + > >>>>>> + clock-names: > >>>>>> + items: > >>>>>> + - const: lp > >>>>>> + - const: vpu > >>>>>> + > >>>>> > >>>>> according to this patch [1], the unicam driver only needs the VPU clock > >>>>> reference just to enforce a minimum of 250 MHz. The firmware clock > >>>>> binding and its driver is specific to the bcm2711, but the Unicam IP > >>>>> exists since bcm2835. > >>>>> > >>>>> So do you think the clock part is correct or should be the VPU clock > >>>>> optional? > >>>> > >>>> I think we should keep it mandatory. Indeed, that clock is shared with > >>>> the HVS that will change its rate on a regular basis, so even just > >>>> enforcing that 250MHz while it's on without a clock handle will be > >>>> fairly hard. > >>>> > >>>> Also, those are the constraints we have now, but having the clock handle > >>>> all the time will allow us to add any constraint we might need in the > >>>> future. > >>>> > >>>> And BCM2711 or not, the clock has probably always been there. > >>> > >>> Furthermore, regardless of what the driver needs, Unicam operates with > >>> the VPU clock, so I think it makes sense to reference it in the device > >>> tree. > >> > >> okay, as a result we need a DTS patch for bcm2835-rpi.dtsi to enable the > >> firmware clocks and its driver in this series. > > > > Can't we do that on top, enabling Unicam support for bcm2711 only first > > ? I have no idea how to deal with firmware clocks on bcm2825, and I'm > > not sure Jean-Michel even has a hardware platform to test it. > > sorry as being a bcm2835 maintainer so long, i'm not always aware of the > ambiguous meaning of bcm2835. The bcm2835-rpi.dtsi is used by all > Raspberry Pi generations. So it's sufficient to test it with a Raspberry > Pi 4, but we would gain support for all generations. > > So my request is to move the changes from bcm2711 specific dtsi to the > general dtsi. There is no need to touch any driver, please have a look > at this patch [1] to see what i had in my mind. Just compile tested. > > I hope you understand, i want to have it for all generations in one step. > > [1] - > https://github.com/lategoodbye/rpi-zero/commit/67897cc22c03204e6464d00ff4ddac6bf5dc65dc Got it. I thought changes would be needed in the firmware clocks driver, if it's just about moving the node to a different file, it's pretty easy. Thank you for taking the time to cook up a patch to educate me :-) > > If you want to send a patch series to enable firmware clocks on bcm2835, > > we'll be happy to rebase on top. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel