From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 105EDC433F5 for ; Mon, 21 Feb 2022 18:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R5S8HiAQ564Fh17+iksA4BfJDKAjZGseSdXQL/RCZ4w=; b=UMpAkpPuhoHmSO jXAYWOdnF5zZW1d1AJhVs6kN1suXNN+yF75z/ZTwUwK/OG+UIY7x8/jDz/QjeKjAnI7aysVHkmXOB EsRPkbjMelPaaNQ2bRN++fiXsm/W3tLqlFy3iAiIw/2VoRSd7hawmWoJOpw6Zyuqs4B027yeWPVio JC06KgF2EHbcZQruos1+DdA4BlMuvsoC49jBonj11wt+GR+Ur9/DrMCOZGh6AbnGvI4fAgo0zUTIC n2IDUJcSeLntG+gwMv4UAB2I1PdpMj1i8KGtJ2ZZcGGE0+3LSb8gs86u8PttRkJ9uJx3z5A36AKVN fERTpu4+7mnnWOaB/vOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMD1u-006tal-Ki; Mon, 21 Feb 2022 18:03:22 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMD1r-006tZr-By for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 18:03:20 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D830482; Mon, 21 Feb 2022 19:03:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645466596; bh=yCcS4wWSq99lF0daf+3VA5h3LDWo3aOAnkYHST/N7Zk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FVgJttf9fht3mBQ36CjeeB5CCfj9SNDFFRmipkuJahEum1KonaE1QXqK1oolmOrAF 3A5z6dXH92BGBFAS5pOnjbJ1/Wp+8v0W1E/xrxj+W+KOvDjZpfg0uNDmxdPT+9mlh+ AP3rrClM+AhMv6QoSCAvpgeGXdHm3n4Wn0+iySk4= Date: Mon, 21 Feb 2022 20:03:07 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: aford173@gmail.com, slongerbeam@gmail.com, p.zabel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, martin.kepplinger@puri.sm, rmfrfs@gmail.com, xavier.roumegue@oss.nxp.com, alexander.stein@ew.tq-group.com, dorota.czaplejewicz@puri.sm, kernel@pengutronix.de, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] media: imx: imx8mq-mipi-csi2: Remove YUV422 2X8 Message-ID: References: <20220221174903.320466-1-jacopo@jmondi.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220221174903.320466-1-jacopo@jmondi.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_100319_584386_635862F4 X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jacopo, Thank you for the patch. On Mon, Feb 21, 2022 at 06:49:03PM +0100, Jacopo Mondi wrote: > The 2X8 variants of MEDIA_BUS_FMT_YUYV8_2X8 does not apply to serial > busses. > > Drop it and while at it also add the canonical UYVY wire format for > packed YUV422 when transmitted on the CSI-2 serial bus. > > Also beautify a little the formats declaration list by putting the > opening curly brace after the comment. > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > > v1->v2: > - Fix subject (s/mp/mq) as reported by Adam > - Add UYVY_1X16 as suggested by Laurent > > drivers/staging/media/imx/imx8mq-mipi-csi2.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c > index 56ef3b3b2906..7d03cb340ed4 100644 > --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c > +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c > @@ -200,14 +200,16 @@ static const struct csi2_pix_format imx8mq_mipi_csi_formats[] = { > }, { > .code = MEDIA_BUS_FMT_SRGGB14_1X14, > .width = 14, > - }, { > + }, > /* YUV formats */ > - .code = MEDIA_BUS_FMT_YUYV8_2X8, > - .width = 16, > - }, { > + { > .code = MEDIA_BUS_FMT_YUYV8_1X16, > .width = 16, > } > + { > + .code = MEDIA_BUS_FMT_UYVY8_1X16, > + .width = 16, > + } > }; > > static const struct csi2_pix_format *find_csi2_format(u32 code) -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel