From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 653E0C433F5 for ; Tue, 22 Feb 2022 09:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=og6mooHE74+waGfiEp6JboWqippDuQGcjHEYj6nttVY=; b=nDja9P/08Nqg0q Uon/aBWDAlguQIAZ9pAWeschTKwaIQa43YhNacg18revIEgcOqUVhZDmURw3cxrrHKeXoVejhVgac Eg++N4pvuIhhbrq8E2au6u5q6YvNpVo8z3CfVjrh81du9Y1xznfvzeLAsBQbTsZxz+btxiXYlVvlH PvnFZhUCGkaVrUNUtMePZ3m/LO6joXhEY7sCiY+llsUbYNkOfW65LQIbwaB9Bq9PS+5iXbrevH7w4 t2efky4B3Y3+3F4M0rW8el+W5O2dWBHWLtCo1uYOAus6nrdyYApvKA1ZFAdDI0KYZMVYrZFFkNh1R sCZYKL2F6lcjJu14iuqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMRlI-008oaO-8B; Tue, 22 Feb 2022 09:47:12 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMRlE-008oYi-Hl for linux-arm-kernel@lists.infradead.org; Tue, 22 Feb 2022 09:47:10 +0000 Received: by mail-wr1-x431.google.com with SMTP id d3so16329917wrf.1 for ; Tue, 22 Feb 2022 01:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BmCM771/H8fMGA2TM9vIMuFjbF0aY9kc+ryD8RCZwDs=; b=idzQPKZoLATAZxfyuZGOcDY/2sUODvMOnd/QV1CEQCDccF+PWPrqBdSJUbkutKn6uq Lzp/jKHgQ6uQXsauKGJ2KAztiFzZ8Fj6mQ8lwRKK/oRT5BpMwabXVRzhKN1dxscDWNNw 6R7+qhb78rincI66EA87GH3lUlbKWdm/gddbv385b+2n8uXNbk0ZBRWf89UqfwMJJbAD cH13YFUDCxt9gYdAvmiR5cJgEeQjPwoYsEDSHA4SdHGigQShR5b4qHOhGrR+fMVDkbFN F9W1M/atDfXtUuu4X5VwAJiKOe8nd0SXdTiMZmlpuj5n9fT4Y7O7kYqlLIrLEuIyez3f Y2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BmCM771/H8fMGA2TM9vIMuFjbF0aY9kc+ryD8RCZwDs=; b=G0y27v8K0yd+XxzjGdFiiBjBcU/5JQrvWKzuNMkUquKMwuSj0NarD6Jt0qbAk6Tqb/ y/1NyEjtEgTwjiU8CR29qRjJKKQA9fBhxEMMCYjksTqenLw+AgGVC5Xh5yhsdmf3lksw 7uneOWfPgGiYshmJZPaEqLzr3iraLO3TEJbu47E0PQ4BjVWPA+o9HOgD6lOKjVMjWs2e 9VlaRPyUpLrOaF/lzVf6pdXkIjdKvQJGW/LaRewYsZqSQzPGmGHTo14HnT4ld5fbcBaY p3Acz3t6/bsdBfvZNWnc2jNscUifPyYHVgtglhU8ImbrgUR0suihDwr17R/uWS8j2Wjc RwXQ== X-Gm-Message-State: AOAM530+LVxLC0gm1SWXsuZgBXL5e++RxGUoW4UU/zp1GUPG1YPG+Yih dM5HRdCSi2qqwc62V9/Ug9U= X-Google-Smtp-Source: ABdhPJxK24rkLm2wkZV8z8R7xDAF5lTZl8sNGmPovb/9HW2VOQ3JIudeOlcRuv9J+GZ49zKqu/oa4A== X-Received: by 2002:a5d:5888:0:b0:1ea:118f:4a82 with SMTP id n8-20020a5d5888000000b001ea118f4a82mr8365095wrf.502.1645523226065; Tue, 22 Feb 2022 01:47:06 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id x17sm43745672wrv.107.2022.02.22.01.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 01:47:05 -0800 (PST) Date: Tue, 22 Feb 2022 10:47:03 +0100 From: Corentin Labbe To: Harsha Harsha Cc: "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Simek , Sarat Chand Savitala , Harsh Jain , git Subject: Re: [PATCH V2 2/4] firmware: xilinx: Add ZynqMP SHA API for SHA3 functionality Message-ID: References: <1645125264-11033-1-git-send-email-harsha.harsha@xilinx.com> <1645125264-11033-3-git-send-email-harsha.harsha@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_014708_615874_2F4A43A0 X-CRM114-Status: GOOD ( 25.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Mon, Feb 21, 2022 at 12:17:02PM +0000, Harsha Harsha a =E9crit : > = > = > > -----Original Message----- > > From: Corentin Labbe > > Sent: Friday, February 18, 2022 3:13 PM > > To: Harsha Harsha > > Cc: herbert@gondor.apana.org.au; davem@davemloft.net; linux-crypto@vger= .kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; Michal Simek ; Sarat Ch= and Savitala ; Harsh Jain > > ; git > > Subject: Re: [PATCH V2 2/4] firmware: xilinx: Add ZynqMP SHA API for SH= A3 functionality > > = > > Le Fri, Feb 18, 2022 at 12:44:22AM +0530, Harsha a =E9crit : > > > This patch adds zynqmp_pm_sha_hash API in the ZynqMP firmware to comp= ute > > > SHA3 hash of given data. > > > > > > Signed-off-by: Harsha > > > Acked-by: Michal Simek > > > --- > > = > > Hello > > = > > Your signed-off should contain your real name. > = > My complete name is Harsha which I have mentioned in the signed-off secti= on. I am sorry, I believed it was your pseudo. If it is your real name, no chan= ge are needed. > = > > Furthermore why did you drop copyright from previous poster ? > > See https://patchwork.kernel.org/project/linux-crypto/cover/1556793282-= 17346-1-git-send-email-kalyani.akula@xilinx.com/ for > > reference. > = > I did not understand the comment. Do you want me to add Kalyani's name al= so in the Signed of section? > = > > = > > Furthermore, the previous poster didnt answered my questions about para= llel processing and tests. > = > Since SHA3 HW engine in ZynqMPSoC does not support parallel processing of= 2 hash requests, so we have changed our approach. = > Now to support parallel processing of 2 hash requests, software fallback= is being used for init, update, final, export and import in the ZynqMP SHA= driver. > For digest, the calculation of SHA3 hash is done by the hardened SHA3 acc= elerator in Xilinx ZynqMP SoC. > = I asked for parallel processing since I didnt see any locking or way to pre= vent hardware to be used in the same time. But the final work is done by a firmware call, so my knowledge stop here. > Following tests have been done for the driver: > - Enabled kernel self tests and extra run-time crypto self tests > - Tested SHA hash computation for different sizes of data using userspace= application > - Tested SHA hash computation using multiple updates of data using usersp= ace application > - Tested parallel hash computation > - Tested using the tcrypt module > = This should be in the cover letter. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel