From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B385C433FE for ; Tue, 22 Feb 2022 16:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LUeccCNIRc11Yf5EwZva+dPXDWtN+/OKJbfOoapdlJA=; b=BL8DmkCx0fLyw9 cQ9fnn0SzzymLj16N0EZxg6HPZPPodHUYLHcIr0TQzajCPp3noHogNaqFmCSgTUSh0Hx0USA6rI2N M/Zt92SMJBisrvyMimCVTe+/A6arKmJHY/+Dmy7P3Cdod/aKBaIaA3GmQBELEI+7+IdQHz1uN0vmM TgKfNucUESCFjw1fIhmnzX8BXXwb3srHycq4f2rZ8VEl/0dTRs0Spi035Dc9GG7Tg8Ag3w2CToVYu j2QlzISBc+5M/9TTZVsJQyfiqnazUkf2WNdJPYsBc5n9htDKaYtBSSmE24nQX+sVNpIsVwG07WuaK sFSDm8W5WztNFWD0J5Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMXxT-00AcJz-QR; Tue, 22 Feb 2022 16:24:11 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMXxR-00AcJa-Rg; Tue, 22 Feb 2022 16:24:09 +0000 Date: Tue, 22 Feb 2022 08:24:09 -0800 From: Christoph Hellwig To: Mikko Perttunen Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org, robh+dt@kernel.org, robin.murphy@arm.com, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/9] gpu: host1x: Add context device management code Message-ID: References: <20220218113952.3077606-1-mperttunen@nvidia.com> <20220218113952.3077606-4-mperttunen@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220218113952.3077606-4-mperttunen@nvidia.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 18, 2022 at 01:39:46PM +0200, Mikko Perttunen wrote: > + > +/* > + * Due to an issue with T194 NVENC, only 38 bits can be used. > + * Anyway, 256GiB of IOVA ought to be enough for anyone. > + */ > +static dma_addr_t context_device_dma_mask = DMA_BIT_MASK(38); You need a mask per device. Please don't share the same variable for multiple masks. > +EXPORT_SYMBOL(host1x_context_alloc); All this low-level code really should be EXPORT_SYMBOL_GPL. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel