From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 169CCC433EF for ; Tue, 22 Feb 2022 22:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ul1bCqQhL6VnLA7iFVrK0Cto3MoJCBvpy5egYE2hkc4=; b=KOsdmrAvNYk0GD e0CC70v8hO2R8ayHIgXbDRVM4eg4im522pFYeoIyGgJVnD6WGrK6JpeuVdA/+6PmhZYpnBmSGCCvP DjR0uAoUiIbvg1cQU14sRbXLC6YYSt+tQSoV8mfPT2YfkjsOA+ecBr+uiLA9Ip+FMG9A1Td8mvYKb W+x3FghZObNLJB4gfj7w5fNWStUQl7LPllpWl8sx+wXGzMlBvw0S7TSXBzQispoDJMfZeNnc+xMeD Rseyc3TQIlHktKm1jKD+k3YigtFkXVp50gUqTUk6cMdJJRy3zv3uPym60QHdpwHuN8w/TDGVy8+4k 1LeDDOmf9p8TN8Ah27zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMdPk-00BlpE-JA; Tue, 22 Feb 2022 22:13:44 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMdPh-00BlnK-0L for linux-arm-kernel@lists.infradead.org; Tue, 22 Feb 2022 22:13:42 +0000 Received: by mail-ot1-x329.google.com with SMTP id j9-20020a9d7d89000000b005ad5525ba09so8344963otn.10 for ; Tue, 22 Feb 2022 14:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vA6jdhrt0X5IzFiRmRz30sCpDU0XpG4s8KI3tUMUnJU=; b=s9/S8l/ekkSc7aYsa1hv+0mOfM69bjvwKarNIOTjKrMlj/PTbV29mSEEcJIrnxOKAp WS8KVJOSY+v0I576R0yB7Hkl29e7E736IljU7HEUIbqu0MS595AksNseW1Dyv/xzHLvM owGbHsctUjewlSnx7c0cZYrFYFIzI3BguZw8erypsgjwvdzbNS2rPwHsha/RYspfJKc9 5iDaeV7jdzpR24u347O9Qg7hytlSj30/b2kueAuGl+//ZZxqYbU8DOzq7ppkCv4W5jm8 FrioZy2sIJzcNtCYEyIxWtmI2QSSdlqo2O6SCWI6y8P7Gdwt3MfxFpXFV6F5sgynLgoz xUsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vA6jdhrt0X5IzFiRmRz30sCpDU0XpG4s8KI3tUMUnJU=; b=fohCqwkvdjqMB0yb/u7mFoy/kcPGOBwBfbnpCOSnNmJzha9QcRRvTPPup9lDYbBfoG 2cdgRmPgF9UX9vkanhZUt2sIhcrRT0Rv5y09RrDRJFGlTzDvIrUiBQFf8yFXUDXua+UN /ZBAxGMaxsOA2StcJ6r3bMBYmWOMr4bBAaSQeFBFACxygd47bfvyCBXlF7HDlHHVfrQ/ X+GZX0aDdg+bHm7dGTQv3fyaAiQwbovWL0bJ7zBLnTMT3WEAsOtofobjoPkzwbE2P0c4 fe96e7lbR647SuV7fOrYV4aS8VAE2GVrjinxoqMPUa15E2KA+tcDqi6miAaKBh6+c1YT U8Ng== X-Gm-Message-State: AOAM5317U8zq6PUnN/IL9H/rjImpC1Lo114IocyLj3d//gCQS2eOqiw+ cz9DfBttprGoileRKlEpZlGH6g== X-Google-Smtp-Source: ABdhPJwo1jDiJk0G/kZFHuz7BVeOgw1uVfA8ZN23LdrEl4HjabtSCEXFmArIKbpm3EVQgnAD7vetQw== X-Received: by 2002:a05:6830:1d5c:b0:5ad:132f:31ae with SMTP id p28-20020a0568301d5c00b005ad132f31aemr9019412oth.71.1645568020009; Tue, 22 Feb 2022 14:13:40 -0800 (PST) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id l38sm7974149otl.45.2022.02.22.14.13.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 14:13:39 -0800 (PST) Date: Tue, 22 Feb 2022 14:15:40 -0800 From: Bjorn Andersson To: Nishanth Menon Cc: Rahul T R , catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, krzk@kernel.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, biju.das.jz@bp.renesas.com, vkoul@kernel.org, enric.balletbo@collabora.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e Message-ID: References: <20220222180703.30401-1-r-ravikumar@ti.com> <20220222193930.sbc5xlsofhg3amgk@overrun> <20220222212642.vwtw7xiz7cck63ea@zombie> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220222212642.vwtw7xiz7cck63ea@zombie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_141341_077034_33ACAD8F X-CRM114-Status: GOOD ( 27.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 22 Feb 13:26 PST 2022, Nishanth Menon wrote: > On 12:40-20220222, Bjorn Andersson wrote: > > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote: > > > > > On 23:37-20220222, Rahul T R wrote: > > > > Enable DRM and PHY configs required for supporting > > > > DisplayPort on J721e > > > > > > > > Signed-off-by: Rahul T R > > > > --- > > > > arch/arm64/configs/defconfig | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > > index 9f23d7ec1232..b0cb894a392e 100644 > > > > --- a/arch/arm64/configs/defconfig > > > > +++ b/arch/arm64/configs/defconfig > > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y > > > > CONFIG_DRM_EXYNOS_HDMI=y > > > > CONFIG_DRM_EXYNOS_MIC=y > > > > CONFIG_DRM_ROCKCHIP=m > > > > +CONFIG_DRM_TIDSS=m > > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m > > > > +CONFIG_DRM_CDNS_MHDP8546=m > > > > > > Please use savedefconfig to place the changes in the correct location > > > > > > > Just to clarify the request, use "make savedefconfig" to generate a > > defconfig, then based on that put _only_ the relevant changes in the > > commit. > > Yup, thanks for clarifying. > > > > > Also indicate changes if any in vmlinux in commit message. > > > > > > > Nishanth, what are you asking for here? Just a mentioning if this has > > any impact to vmlinux (or is isolated to the modules selected), or are > > you asking for anything specific? > > In this case, just ensure to state that vmlinux size has'nt > changed, in case where we see a =y, we should indicate via > ./scripts/bloat-o-meter change that is introduced and if yes, we > should explain why this is fundamental to system boot. > > Why is this necessary? This is to prevent product specific > configurations (such as early display banner, chime etc) from creeping > and increasing vmlinux size which has an impact for all ARM SoCs. > Sounds very reasonable, I'll make sure to ask for such motivations in the defconfig changes that I pick up through the Qualcomm tree as well. Regards, Bjorn > > [...] > > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel