* Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e [not found] <20220222180703.30401-1-r-ravikumar@ti.com> @ 2022-02-22 19:39 ` Nishanth Menon 2022-02-22 20:40 ` Bjorn Andersson 0 siblings, 1 reply; 4+ messages in thread From: Nishanth Menon @ 2022-02-22 19:39 UTC (permalink / raw) To: Rahul T R Cc: catalin.marinas, will, shawnguo, bjorn.andersson, krzk, geert+renesas, marcel.ziswiler, biju.das.jz, vkoul, enric.balletbo, linux-arm-kernel, linux-kernel, tomi.valkeinen, laurent.pinchart On 23:37-20220222, Rahul T R wrote: > Enable DRM and PHY configs required for supporting > DisplayPort on J721e > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > --- > arch/arm64/configs/defconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 9f23d7ec1232..b0cb894a392e 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y > CONFIG_DRM_EXYNOS_HDMI=y > CONFIG_DRM_EXYNOS_MIC=y > CONFIG_DRM_ROCKCHIP=m > +CONFIG_DRM_TIDSS=m > +CONFIG_DRM_DISPLAY_CONNECTOR=m > +CONFIG_DRM_CDNS_MHDP8546=m Please use savedefconfig to place the changes in the correct location Also indicate changes if any in vmlinux in commit message. A bootlog indicating functionality in diffstat is also additional good thing to do. > CONFIG_ROCKCHIP_ANALOGIX_DP=y > CONFIG_ROCKCHIP_CDN_DP=y > CONFIG_ROCKCHIP_DW_HDMI=y > @@ -1175,6 +1178,8 @@ CONFIG_PHY_SAMSUNG_UFS=y > CONFIG_PHY_UNIPHIER_USB2=y > CONFIG_PHY_UNIPHIER_USB3=y > CONFIG_PHY_TEGRA_XUSB=y > +CONFIG_PHY_J721E_WIZ=m > +CONFIG_PHY_CADENCE_TORRENT=m > CONFIG_ARM_SMMU_V3_PMU=m > CONFIG_FSL_IMX8_DDR_PMU=m > CONFIG_QCOM_L2_PMU=y > -- > 2.17.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e 2022-02-22 19:39 ` [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e Nishanth Menon @ 2022-02-22 20:40 ` Bjorn Andersson 2022-02-22 21:26 ` Nishanth Menon 0 siblings, 1 reply; 4+ messages in thread From: Bjorn Andersson @ 2022-02-22 20:40 UTC (permalink / raw) To: Nishanth Menon Cc: Rahul T R, catalin.marinas, will, shawnguo, krzk, geert+renesas, marcel.ziswiler, biju.das.jz, vkoul, enric.balletbo, linux-arm-kernel, linux-kernel, tomi.valkeinen, laurent.pinchart On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote: > On 23:37-20220222, Rahul T R wrote: > > Enable DRM and PHY configs required for supporting > > DisplayPort on J721e > > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > > --- > > arch/arm64/configs/defconfig | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 9f23d7ec1232..b0cb894a392e 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y > > CONFIG_DRM_EXYNOS_HDMI=y > > CONFIG_DRM_EXYNOS_MIC=y > > CONFIG_DRM_ROCKCHIP=m > > +CONFIG_DRM_TIDSS=m > > +CONFIG_DRM_DISPLAY_CONNECTOR=m > > +CONFIG_DRM_CDNS_MHDP8546=m > > Please use savedefconfig to place the changes in the correct location > Just to clarify the request, use "make savedefconfig" to generate a defconfig, then based on that put _only_ the relevant changes in the commit. > Also indicate changes if any in vmlinux in commit message. > Nishanth, what are you asking for here? Just a mentioning if this has any impact to vmlinux (or is isolated to the modules selected), or are you asking for anything specific? Regards, Bjorn > A bootlog indicating functionality in diffstat is also additional good > thing to do. > > > CONFIG_ROCKCHIP_ANALOGIX_DP=y > > CONFIG_ROCKCHIP_CDN_DP=y > > CONFIG_ROCKCHIP_DW_HDMI=y > > @@ -1175,6 +1178,8 @@ CONFIG_PHY_SAMSUNG_UFS=y > > CONFIG_PHY_UNIPHIER_USB2=y > > CONFIG_PHY_UNIPHIER_USB3=y > > CONFIG_PHY_TEGRA_XUSB=y > > +CONFIG_PHY_J721E_WIZ=m > > +CONFIG_PHY_CADENCE_TORRENT=m > > CONFIG_ARM_SMMU_V3_PMU=m > > CONFIG_FSL_IMX8_DDR_PMU=m > > CONFIG_QCOM_L2_PMU=y > > -- > > 2.17.1 > > > > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e 2022-02-22 20:40 ` Bjorn Andersson @ 2022-02-22 21:26 ` Nishanth Menon 2022-02-22 22:15 ` Bjorn Andersson 0 siblings, 1 reply; 4+ messages in thread From: Nishanth Menon @ 2022-02-22 21:26 UTC (permalink / raw) To: Bjorn Andersson Cc: Rahul T R, catalin.marinas, will, shawnguo, krzk, geert+renesas, marcel.ziswiler, biju.das.jz, vkoul, enric.balletbo, linux-arm-kernel, linux-kernel, tomi.valkeinen, laurent.pinchart On 12:40-20220222, Bjorn Andersson wrote: > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote: > > > On 23:37-20220222, Rahul T R wrote: > > > Enable DRM and PHY configs required for supporting > > > DisplayPort on J721e > > > > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > > > --- > > > arch/arm64/configs/defconfig | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index 9f23d7ec1232..b0cb894a392e 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y > > > CONFIG_DRM_EXYNOS_HDMI=y > > > CONFIG_DRM_EXYNOS_MIC=y > > > CONFIG_DRM_ROCKCHIP=m > > > +CONFIG_DRM_TIDSS=m > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m > > > +CONFIG_DRM_CDNS_MHDP8546=m > > > > Please use savedefconfig to place the changes in the correct location > > > > Just to clarify the request, use "make savedefconfig" to generate a > defconfig, then based on that put _only_ the relevant changes in the > commit. Yup, thanks for clarifying. > > > Also indicate changes if any in vmlinux in commit message. > > > > Nishanth, what are you asking for here? Just a mentioning if this has > any impact to vmlinux (or is isolated to the modules selected), or are > you asking for anything specific? In this case, just ensure to state that vmlinux size has'nt changed, in case where we see a =y, we should indicate via ./scripts/bloat-o-meter change that is introduced and if yes, we should explain why this is fundamental to system boot. Why is this necessary? This is to prevent product specific configurations (such as early display banner, chime etc) from creeping and increasing vmlinux size which has an impact for all ARM SoCs. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e 2022-02-22 21:26 ` Nishanth Menon @ 2022-02-22 22:15 ` Bjorn Andersson 0 siblings, 0 replies; 4+ messages in thread From: Bjorn Andersson @ 2022-02-22 22:15 UTC (permalink / raw) To: Nishanth Menon Cc: Rahul T R, catalin.marinas, will, shawnguo, krzk, geert+renesas, marcel.ziswiler, biju.das.jz, vkoul, enric.balletbo, linux-arm-kernel, linux-kernel, tomi.valkeinen, laurent.pinchart On Tue 22 Feb 13:26 PST 2022, Nishanth Menon wrote: > On 12:40-20220222, Bjorn Andersson wrote: > > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote: > > > > > On 23:37-20220222, Rahul T R wrote: > > > > Enable DRM and PHY configs required for supporting > > > > DisplayPort on J721e > > > > > > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > > > > --- > > > > arch/arm64/configs/defconfig | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > > index 9f23d7ec1232..b0cb894a392e 100644 > > > > --- a/arch/arm64/configs/defconfig > > > > +++ b/arch/arm64/configs/defconfig > > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y > > > > CONFIG_DRM_EXYNOS_HDMI=y > > > > CONFIG_DRM_EXYNOS_MIC=y > > > > CONFIG_DRM_ROCKCHIP=m > > > > +CONFIG_DRM_TIDSS=m > > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m > > > > +CONFIG_DRM_CDNS_MHDP8546=m > > > > > > Please use savedefconfig to place the changes in the correct location > > > > > > > Just to clarify the request, use "make savedefconfig" to generate a > > defconfig, then based on that put _only_ the relevant changes in the > > commit. > > Yup, thanks for clarifying. > > > > > Also indicate changes if any in vmlinux in commit message. > > > > > > > Nishanth, what are you asking for here? Just a mentioning if this has > > any impact to vmlinux (or is isolated to the modules selected), or are > > you asking for anything specific? > > In this case, just ensure to state that vmlinux size has'nt > changed, in case where we see a =y, we should indicate via > ./scripts/bloat-o-meter change that is introduced and if yes, we > should explain why this is fundamental to system boot. > > Why is this necessary? This is to prevent product specific > configurations (such as early display banner, chime etc) from creeping > and increasing vmlinux size which has an impact for all ARM SoCs. > Sounds very reasonable, I'll make sure to ask for such motivations in the defconfig changes that I pick up through the Qualcomm tree as well. Regards, Bjorn > > [...] > > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-22 22:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220222180703.30401-1-r-ravikumar@ti.com>
2022-02-22 19:39 ` [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e Nishanth Menon
2022-02-22 20:40 ` Bjorn Andersson
2022-02-22 21:26 ` Nishanth Menon
2022-02-22 22:15 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox