From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A081EC433F5 for ; Wed, 23 Feb 2022 10:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NQbpm6ZmeAqvxfytR6fHZTOQMDnfw5D4CD9QIgs1kqA=; b=ZWamy0bg3+jOat 0mykJbZyYTHBfvwBn2YZDUrHM892vnietkMEx3yjKw0VhUIEfSL+tAcC5A8DwRmyjwSHiDxPgy/lk rs+21kfsLVayjQE1VBxH5FrDHFbAhAs9+EMWG2q2eSW1xkr6tvvkjRCtMfuWL0e4rswpJX1nh0Jvp Ygi5ThpSx8p1YsFlJ9MnNPzOU/7i9uq2/uY4tUDMc/KoKX+P2RMCTxuxtc1H/BaxvLtOwF9m98Emv mdk2ywVIubAORz9pr9hm94JwSISlqTrYohyhiDVY2Jn/duIPKGBjLQ5yCQlQQHE9Zid7eqqwgW3Ug 3CUw+45M5XOGWbrXTJzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMoTw-00DauL-5Y; Wed, 23 Feb 2022 10:02:48 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMoTu-00Datt-LD for linux-arm-kernel@bombadil.infradead.org; Wed, 23 Feb 2022 10:02:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=950owLcb9IA7ME/3RJ6CEvfn2Ym+HykinA3cgRt1l/I=; b=nWW76hogKS/qfA/kicNa8+My46 moURa476Kj68UJNOzCnzPLV6r0m6SbDAVbr4Hy+uYakRSmuADE99l3bcqFHRJ5tn7B+Rlasm6ioXe YNJYSe1Kog4V6Tem2NT4jRHodyYh1WQ1CsvvSluYsdLzHQplrJ2Ve2Kw63KFriQztxTrD0XZZRQGZ QHSbSB5sMmMPyZj5xXneYTMN782ewucxdj6+JCPw2Q/DAaGUl8gFazH+hC8zag56Iu2SeWlcl9rNQ cCkKtoh0wGe3ZVxn75lM4LRc5nYKafrFSs5bSjMZNfkFPF76lCm+318EjNGBgLisqnekkftm9CVgN 2LRoBq+g==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMoTt-003e5b-4a for linux-arm-kernel@lists.infradead.org; Wed, 23 Feb 2022 10:02:45 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E2C0B400FE; Wed, 23 Feb 2022 07:02:40 -0300 (-03) Date: Wed, 23 Feb 2022 07:02:40 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: German Gomez , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] perf arm-spe: Use advertised caps/min_interval as default sample_period Message-ID: References: <20220221171042.58460-1-german.gomez@arm.com> <20220223011436.GA414932@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220223011436.GA414932@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Feb 23, 2022 at 09:14:36AM +0800, Leo Yan escreveu: > On Mon, Feb 21, 2022 at 05:10:42PM +0000, German Gomez wrote: > > When recording SPE traces, the default sample_period is currently being > > set to 1 in the perf_event_attr fields, instead of the value advertised > > in '/sys/devices/arm_spe_0/caps/min_interval': > > > > Before: > > > > $ perf record -e arm_spe// -vv -- sleep 1 > > [...] > > { sample_period, sample_freq } 1 > > [...] > > > > Use the value from the above sysfs location as a more sensible default > > (it was already being read, but the value not being used) > > > > After: > > > > $ perf record -e arm_spe// -vv -- sleep 1 > > [...] > > { sample_period, sample_freq } 1024 > > [...] > > > > Signed-off-by: German Gomez > > The change looks good to me: > > Reviewed-by: Leo Yan Thanks, applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel