From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 787BFC433FE for ; Wed, 23 Feb 2022 15:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d9VpOCUkLSOw177feGQl5HwBmG9hwzxzvHjBE1z+DfQ=; b=kSmKFLzgHt/E/W +UEBh4dczPbUmL9F5JM90x1EtKWialMl2iz35qdS+lEp2nRPy8MX5za/zW8KmJy+DJ21TNrtZhCkk YGQiOIKIChneBsKOxGEy9YeZUk0+Kt6AiHWI90/GYEo/AhmIZuux6Ii9YjMZnaVB+DwjsTdLA5en9 GmEcIowJip7qqctFKhQRAfrh9/uh7jwhd6sDwSCdgxBvXFztNP6/33N8Uuyvq0rbX8NNFVbSXFSSd pQTsURHHUu4hRiiKmcYLJ1LNZIQtqTAPa9PeCjwuF1s5bWIKyfFuvV3vxDiprW0ItS3TmqAeYtXhh o4bOY2eToTPwkrPXaEfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMtNz-00EyL0-K0; Wed, 23 Feb 2022 15:16:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMtNv-00EyJX-OA for linux-arm-kernel@lists.infradead.org; Wed, 23 Feb 2022 15:16:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 92FCB61720; Wed, 23 Feb 2022 15:16:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E53D4C340EB; Wed, 23 Feb 2022 15:16:50 +0000 (UTC) Date: Wed, 23 Feb 2022 15:16:46 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v11 20/40] arm64/sme: Implement streaming SVE signal handling Message-ID: References: <20220207152109.197566-1-broonie@kernel.org> <20220207152109.197566-21-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220207152109.197566-21-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220223_071655_875772_63AFBC9D X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 07, 2022 at 03:20:49PM +0000, Mark Brown wrote: > When in streaming mode we have the same set of SVE registers as we do in > regular SVE mode with the exception of FFR and the use of the SME vector > length. Provide signal handling for these registers by taking one of the > reserved words in the SVE signal context as a flags field and defining a > flag with a flag which is set for streaming mode. When the flag is set the Too many "flag" words. > @@ -593,11 +613,16 @@ static int setup_sigframe_layout(struct rt_sigframe_user_layout *user, > if (system_supports_sve()) { > unsigned int vq = 0; > > - if (add_all || test_thread_flag(TIF_SVE)) { > - int vl = sve_max_vl(); > + if (add_all || test_thread_flag(TIF_SVE) || > + thread_sm_enabled(¤t->thread)) { > + int vl = max(sve_max_vl(), sme_max_vl()); > > - if (!add_all) > - vl = task_get_sve_vl(current); > + if (!add_all) { > + if (thread_sm_enabled(¤t->thread)) > + vl = task_get_sme_vl(current); > + else > + vl = task_get_sve_vl(current); > + } > > vq = sve_vq_from_vl(vl); Nitpick: this looks a bit too complicated, maybe split it in three separate if/else blocks. Either way, Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel