From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DA2AC433F5 for ; Wed, 23 Feb 2022 15:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1M7ufxT9RM4UkuV57PCnj0zkh03PqvFSxnh1vZGFpAA=; b=T4BxRnt8hMGN9M y5uc1oP9M/EX170JnjByOW7nI3Q6g7MnQ0JXuso/E/8wDUoHtV+J+i9dhU5fPDY4JneTabni3wBfQ DzLihTWXdOvuuiqHz8xLFvkP6wyV8/iGVkeDp9tXszm1InTV13/GJXOnctWIDvPH8WuJ0ttJQu7hS T6Jv3mRTLzicfmy4DQ2R++sFOrztDEnxvDVWgI61FdKV7frm7PNpllKMe7kiDB1rLJtLgIKT4Kpsa T9BykrVe6plBp68ovFeWKTm76w1AMC+/ywRzt+BjFPyoc5R95XvQMh7e/1hDM1yCVgVZA20bxUQs4 bhyJFdwsPzdPiZkwFBJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMtTg-00EzvX-7p; Wed, 23 Feb 2022 15:22:52 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMtTd-00Ezuf-BZ for linux-arm-kernel@lists.infradead.org; Wed, 23 Feb 2022 15:22:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E49CFB82079; Wed, 23 Feb 2022 15:22:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC8B7C340E7; Wed, 23 Feb 2022 15:22:43 +0000 (UTC) Date: Wed, 23 Feb 2022 15:22:40 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v11 22/40] arm64/sme: Implement ptrace support for streaming mode SVE registers Message-ID: References: <20220207152109.197566-1-broonie@kernel.org> <20220207152109.197566-23-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220207152109.197566-23-broonie@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220223_072249_585619_BE89574C X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 07, 2022 at 03:20:51PM +0000, Mark Brown wrote: > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index 2242c14a5a05..8b111b7f2006 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -645,14 +645,19 @@ static void __fpsimd_to_sve(void *sst, struct user_fpsimd_state const *fst, > */ > static void fpsimd_to_sve(struct task_struct *task) > { > - unsigned int vq; > + unsigned int vq, vl; > void *sst = task->thread.sve_state; > struct user_fpsimd_state const *fst = &task->thread.uw.fpsimd_state; > > if (!system_supports_sve()) > return; > > - vq = sve_vq_from_vl(task_get_sve_vl(task)); > + if (thread_sm_enabled(&task->thread)) > + vl = task_get_sme_vl(task); > + else > + vl = task_get_sve_vl(task); I saw this construct in the signal patches as well. Can we have a function/macro that checks the SM enabled and returns the proper vl? Otherwise, Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel