From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AEB7C433EF for ; Thu, 24 Feb 2022 19:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DlmRDmgPTz7fICD0eaaEvmb5wIyuGPdGHglBxr6gQAM=; b=aeoGfxnsEKFGTw GPMivfWpt3XYRDHIEUlwu3Lu1BMdSpY9LuS8GYslh9msDgWnK3ipbeXJZg5wDJZqjK/8yTDg1FOAj mrwR/pl24AIEtMLickZmUfZ3KQ2pO9heSH1w2hfcNwYHHcqGeTTPUsewsgYfcbmlH8SfmYgFL7KwC eaqYC/oBd9XknqCWkxEXDRgIN2n8vDeF/te5yjNRmbzhgh8n6D1H4dTXNNNZ+ERIrwV8vud7CHXHx mpI+F3zt+qzsVHJSCKHaiQPq63RucpmDai3JCgmdlV4eGQBX/K5onnzHTEPDQsJe1iBIdQcdLEjgO pRcieO7kyosGjjKPGg0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNJhm-0027Wf-GF; Thu, 24 Feb 2022 19:23:10 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNJhj-0027Vp-4M for linux-arm-kernel@lists.infradead.org; Thu, 24 Feb 2022 19:23:08 +0000 Received: by mail-oi1-f180.google.com with SMTP id i5so4420587oih.1 for ; Thu, 24 Feb 2022 11:23:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9vXsvKJlW7AxtBGaO+YUrlsDVwA2t7tuHb+ZPnQHnEo=; b=sF9DJNVAdipkVlmaToVNQv22gRqYip3YWa7t/XOFm2Hbi7RID7mKBDP3KDACbXMDhk pHJxuRjQgZ6CCKhWrn9sxgy5me1MtvaIohQ4li2xYL+5aoYPHwuJzknCFFX+OIHg2f2i aZS0RbLQsuiQzZpypQGOROtXCxhjWO6v6Mw3EVRrgfRqkbcPQq1M/Rr+9xXpm7b8pcJU 15PBLhi6yn9d2G+vHB/X0CmKVi+lEfmYTZoXVeWWgB5GYq9T0zA3QuqWHolOelwn6EXs HwZlYJCNxRBp8DJCFbwXpgbDQnqbOAQlWkCT5EVerIV3sZj1mTyK5EydNmpB+AwEoZxP GpKw== X-Gm-Message-State: AOAM531iE1OQLe2ZbhasiFuUfR/87sRkNq49WZ8PB963VzoTwkzght0F 6Olc22jSvpkoruE7qCTer7JxE/fRDA== X-Google-Smtp-Source: ABdhPJyT5jyQjcrWS/WBfCkV0FKO13pGnYEJLcEIEnOQ4brqwyu8lTKgq6ivu/QQZeN+nm909DyY2A== X-Received: by 2002:a05:6870:1b0f:b0:b4:10eb:c070 with SMTP id hl15-20020a0568701b0f00b000b410ebc070mr1908975oab.161.1645730584925; Thu, 24 Feb 2022 11:23:04 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id bc24-20020a056808171800b002d722aead50sm176027oib.27.2022.02.24.11.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:23:03 -0800 (PST) Received: (nullmailer pid 3438427 invoked by uid 1000); Thu, 24 Feb 2022 19:23:02 -0000 Date: Thu, 24 Feb 2022 13:23:02 -0600 From: Rob Herring To: "Peng Fan (OSS)" Cc: jassisinghbrar@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski@canonical.com, daniel.baluta@nxp.com, Peng Fan Subject: Re: [PATCH V4 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support Message-ID: References: <20220223023157.3478540-1-peng.fan@oss.nxp.com> <20220223023157.3478540-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220223023157.3478540-3-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_112307_197697_C5DFA8BC X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 23, 2022 at 10:31:54AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication > between Sentinel and Cortex-A cores from hardware design, it could not be > reused for other purpose. > > However i.MX93 S4 MU use separate tx/rx interrupt, so update > interrupts and add interrupt-names property. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/mailbox/fsl,mu.yaml | 27 ++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > index 6d056d5e16bf..f5f9d501845d 100644 > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml > @@ -29,6 +29,7 @@ properties: > - const: fsl,imx8ulp-mu > - const: fsl,imx8-mu-scu > - const: fsl,imx8-mu-seco > + - const: fsl,imx93-mu-s4 > - const: fsl,imx8ulp-mu-s4 > - items: > - const: fsl,imx93-mu > @@ -55,7 +56,13 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 I still don't think you tested this with 2 items. You need minItems and maxItems. > + > + interrupt-names: > + minItems: 1 > + items: > + - const: tx > + - const: rx > > "#mbox-cells": > description: | > @@ -90,6 +97,24 @@ required: > - interrupts > - "#mbox-cells" > > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx93-mu-s4 > + then: > + properties: > + interrupt-names: > + minItems: 2 > + interrupts: > + maxItems: 2 s/maxItems/minItems/ > + > + else: > + properties: > + interrupts: > + maxItems: 1 > + > additionalProperties: false > > examples: > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel