From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 869C4C433EF for ; Fri, 25 Feb 2022 19:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pbEU6dJJ1T/JakPoSYnaA2VKis08Z+tG2SQgYhVe/HE=; b=GPMgVGg1XTMw/J 9qXzdY4iDoR5XJXq+2mClpa3Q4lXkCTxGpMjJ3ON9ljNzn95KsMrgcmTd0ZzyiphTk3oDT89o4wb+ y6rjYeX8YzMEuc+n0U/HQ5dF3uIOLJd6YbVbzY4irqC7UUXuqy9mbxZ83xvV3FyiDIVM0tSJ1E2Xw oc4JvrMkVUVhNhIrp6BNo4wi+VIBYdY6Qv8kAH9rlS6a83Y02OFtPU5AD0vWuB3ijhgEtr5sfnwj2 Q7iIdxeDyRPc7w/BhTJ2zS3bbO9BaEozurtUhJJLo2FGAIFQ8pP4dpOiOup/NutvsLMJxQmE/a26T m1z6JCLw9rtoQ0EOchGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNgEU-006n39-54; Fri, 25 Feb 2022 19:26:26 +0000 Received: from mail-oo1-f46.google.com ([209.85.161.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNgEQ-006n2Y-Oi; Fri, 25 Feb 2022 19:26:24 +0000 Received: by mail-oo1-f46.google.com with SMTP id r41-20020a4a966c000000b0031bf85a4124so7743766ooi.0; Fri, 25 Feb 2022 11:26:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8/RhmmvOE3ZBDv39xXLcWsX9wxG1z+5j6Nqh+tUlI0Q=; b=b/70yp0jLQDLV3wM941CCRPeU/4pHpYkiOHr7U8XzeMjx8rxdyF77/ks22JIdLK4A8 vleZMzK7PvdJuPKR8QNd4aCf7UAj+nf6wYdRpVsnljggKrZU9gPMX+UCocLCvVqtIT1I hHmcCCY5IQZ+poVIHjIiRs7P1MROtsoVKnMo7G92jJzamKYlA5prUVIh4XcX2w84laxt ojNqXMAUL3R6FL7ENQgQVhxxsT7JlCWj6xgcwbZFoAQHzBQxvVey2rXo09x7qlE8SmJv eKtNUMZgct7j/4XSPqR2z+WsWlGsVDQ2Elnx+VyUGum2LhmXi1mikEWhHZfn/NlbAlOO hucA== X-Gm-Message-State: AOAM531sQeGZ/LYhImJ1KxU+np1WO1DQ8zb7jfvjxut88xmpIXvik8HA 1smdbQ9qdvaHdtoCUrdsKw== X-Google-Smtp-Source: ABdhPJzWJ5ARcz3klRmenrwFTt1pjcga9WbD7rJl5U41JbD2tVK2JK2Wkw4Lcb5MV4ZtE1fRD8p44Q== X-Received: by 2002:a05:6870:d917:b0:ce:c0c9:650 with SMTP id gq23-20020a056870d91700b000cec0c90650mr2073603oab.162.1645817180555; Fri, 25 Feb 2022 11:26:20 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id x7-20020a4a8687000000b003191a2edc67sm1586401ooh.7.2022.02.25.11.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 11:26:19 -0800 (PST) Received: (nullmailer pid 1288039 invoked by uid 1000); Fri, 25 Feb 2022 19:26:18 -0000 Date: Fri, 25 Feb 2022 13:26:18 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Alim Akhtar , Avri Altman , Andy Gross , Bjorn Andersson , Wei Xu , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , "James E.J. Bottomley" , "Martin K. Petersen" , Jan Kotas , Li Wei , Stanley Chu , Yaniv Gardi , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 01/15] dt-bindings: ufs: add common platform bindings Message-ID: References: <20220222145854.358646-1-krzysztof.kozlowski@canonical.com> <20220222145854.358646-2-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220222145854.358646-2-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_112622_853769_4D1587FC X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 22, 2022 at 03:58:40PM +0100, Krzysztof Kozlowski wrote: > Add bindings for common parts (platform) of Universal Flash Storage > (UFS) Host Controllers in dtschema format. > > The 'freq-table-hz' is not correct in dtschema, because '-hz' suffix > defines uint32 type, not an array. Therefore deprecate 'freq-table-hz' > and use 'freq-table' instead. -hz is an array type. We can extend it to matrix if needed. I do think this property is a bit questionable. Do we really need a minimum in DT and if not, wouldn't assigned-clocks-rate work? Or an OPP table. > Include also the bindings directory in UFS maintainers entry. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 2 +- > .../devicetree/bindings/ufs/ufs-common.yaml | 88 +++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 90 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/ufs/ufs-common.yaml > > diff --git a/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml b/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml > index 4d13e6bc1c50..dc93fe2d3458 100644 > --- a/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml > @@ -80,7 +80,7 @@ examples: > compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0"; > reg = <0x0 0x4000 0x0 0x10000>; > interrupts = ; > - freq-table-hz = <19200000 19200000>; > + freq-table = <19200000 19200000>; > power-domains = <&k3_pds 277>; > clocks = <&k3_clks 277 1>; > assigned-clocks = <&k3_clks 277 1>; > diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > new file mode 100644 > index 000000000000..85c73d2853e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ufs/ufs-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common properties for Universal Flash Storage (UFS) Host Controllers > + > +maintainers: > + - Alim Akhtar > + - Avri Altman > + > +properties: > + clocks: true > + > + clock-names: true > + > + freq-table-hz: > + deprecated: true > + description: > + Use freq-table. > + > + freq-table: > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + items: > + items: > + - description: Minimum frequency for given clock > + - description: Maximum frequency for given clock > + description: | > + Array of operating frequencies in Hz stored in the same order > + as the clocks property. If this property is not defined or a value in the > + array is "0" then it is assumed that the frequency is set by the parent > + clock or a fixed rate clock source. > + > + interrupts: > + maxItems: 1 > + > + lanes-per-direction: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2] > + default: 2 > + description: > + Number of lanes available per direction. Note that it is assume same > + number of lanes is used both directions at once. > + > + vdd-hba-supply: > + description: > + Phandle to UFS host controller supply regulator node. > + > + vcc-supply: > + description: > + Phandle to VCC supply regulator node. > + > + vccq-supply: > + description: > + Phandle to VCCQ supply regulator node. > + > + vccq2-supply: > + description: > + Phandle to VCCQ2 supply regulator node. > + > + vcc-supply-1p8: > + type: boolean > + description: > + For embedded UFS devices, valid VCC range is 1.7-1.95V or 2.7-3.6V. This > + boolean property when set, specifies to use low voltage range of > + 1.7-1.95V. Note for external UFS cards this property is invalid and valid > + VCC range is always 2.7-3.6V. > + > + vcc-max-microamp: > + description: > + Specifies max. load that can be drawn from VCC supply. > + > + vccq-max-microamp: > + description: > + Specifies max. load that can be drawn from VCCQ supply. > + > + vccq2-max-microamp: > + description: > + Specifies max. load that can be drawn from VCCQ2 supply. > + > +dependencies: > + freq-table: [ 'clocks' ] > + > +required: > + - interrupts > + > +additionalProperties: true > diff --git a/MAINTAINERS b/MAINTAINERS > index aa0f6cbb634e..c2cff57d32f8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20015,6 +20015,7 @@ R: Alim Akhtar > R: Avri Altman > L: linux-scsi@vger.kernel.org > S: Supported > +F: Documentation/devicetree/bindings/ufs/ > F: Documentation/scsi/ufs.rst > F: drivers/scsi/ufs/ > > -- > 2.32.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel