From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 007BAC433F5 for ; Mon, 14 Mar 2022 15:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gcuyjXk5cXeAnRUiDzCQPMmZxf7jI65YyCRCxTKy5iQ=; b=SAu0A8mJbKoLp1 ojhSUcolgPGNxpbOVArerkAkLPugfPZ7gjDqELDlA3qQew2aXcCahY17J9DkiQpXhcpiC3jLCiaRL 387RPRed7OOIDnN25omN2W/nb3WaWIxThrOECniWt3ZK+7z4hYHLw8KSJM700y/JzOgvtXps1y2dF UNUdyHhnJyrNJRdSvOoQ/NqSGBs7cP8ugVNNpehTcxCfewvQn8W6HbSgRHqzpLoo/N+V95k00gmXn MLtCxkIGSBv+TNjoP4Qm0OfgUgCTt+2lA0ro4+OBi1rOnq/qiLB7a8458523yzm3dErIck8IAT9fU jICypxCS34rIQqsnOq5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTmGS-005lK1-Bu; Mon, 14 Mar 2022 15:05:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTmGO-005lJ4-BX; Mon, 14 Mar 2022 15:05:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2BA5A6120D; Mon, 14 Mar 2022 15:05:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45671C340E9; Mon, 14 Mar 2022 15:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647270334; bh=vid+gcRgrdHBjbvxXWaS6eC74Yc5hgJyVhx5aF4/+Hw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EZWqg2xyUizyuaW4pkIuktGlFVzm+xlX7sfxZ7/jdiw9JTF/LSb+rQeXeO1QC5dHE lSFeZaOkuhVyOS3hB24Ny7Lx7J7jD0zknbAPm7SPTNHk6jSjZnSkNnOTN0lcD80V2a qkPTmEKHJggKjazz3FqCIVupMgAAtQRqsL2Qx4g8= Date: Mon, 14 Mar 2022 16:05:29 +0100 From: Greg KH To: Gaston Gonzalez Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org, stefan.wahren@i2se.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: vchiq_arm: add prototype of function vchiq_platform_init() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_080536_467533_B77D2EBA X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 02, 2022 at 06:36:38PM -0300, Gaston Gonzalez wrote: > Fix "no previous prototype" W=1 warning by adding the prototype of the > function vchiq_platform_init(). > > Note: vchiq_platform_init() is only called once in vchiq_probe(), so > presumably should be static function. However, making the function > static breaks the build. > > Signed-off-by: Gaston Gonzalez > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h > index 2aa46b119a46..d72edaf7e5e9 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h > @@ -122,6 +122,8 @@ vchiq_instance_get_trace(struct vchiq_instance *instance); > extern void > vchiq_instance_set_trace(struct vchiq_instance *instance, int trace); > > +int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state); > + It is a static function, so don't add a prototype here to say it is not :( thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel