From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7BFEC433F5 for ; Fri, 4 Mar 2022 08:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DdrAIp8GEdAGOpB4jOwrA4oZWIEynaWfiHJlQ8R5yxs=; b=MdBdSz3G4uguR1k09R5lDTzb5X 5mlDjs6Fm7X17vQG0qEKIzuElEYD/5+kszPQOKc07/ubnjm4U+pBWLMuLqE/GfJU4DjWLJsB0z/mh RqEb9jV/vM+cxmZ3dqqxt1W/aytKGR2hSmS3mGLOEhI+LV931a2bZY8SIY8sSXquLm+W6CPccj4Zx QNpAnq9TPCaoAiyZQNmB5Q/fjITbqCrNi31dFfUbdhiCscchmx+DZEwwYFkb/QAEhZnQVTTGoaBWS YGb3IjaTGAr2lJxiUADTM+14JWgWSi6qWj/ZMsXcdTKy94TGMHpUbofjeuQNgFXzb06ToyhHfi2+7 JxEza8gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQ2zM-008wJN-Qw; Fri, 04 Mar 2022 08:08:38 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQ2vm-008umB-OM for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 08:04:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0ECC860748; Fri, 4 Mar 2022 08:04:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28DFBC340E9; Fri, 4 Mar 2022 08:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646381093; bh=Tgs03jOO+tOMUPi4cSw7bkrOng84ePRbUUCWr093Xso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G/a9fYk7Sz8kRE1rBq+1OlGNk3DjOENsuu/a7IGyMAAwTaUIZ5e1zUQF9boXkZSUA zJicuz5qfLidVnYM4LOTPqo5YGRrjOJI8jz2snHQLr8JCVSgOQrtT2HumtDwsIjPFk JnJtbewltNbbez95C5WiKKlFG5h7/oWgjHwyFq1uN5hl58rIN0psdUI99P76JLEJ0l XzWxLHGjvS2qosAGcAg/OYJkdH6RthnVyjJfq0njwJPNWbSALBQn99XHAJbqZu1/JR d/dxGdsV6S6S6CyjkKLC+xKBkFNPPrJi7yRtvS9jNjGQnHGA2v92J7/CPgMbrxD5Dj 906CIa0v5yEEg== Date: Fri, 4 Mar 2022 09:04:50 +0100 From: Wolfram Sang To: Christian =?utf-8?B?S8O2bmln?= Subject: Re: [PATCH] i2c: at91: use dma safe buffers Message-ID: Mail-Followup-To: Wolfram Sang , Christian =?utf-8?B?S8O2bmln?= , Michael Walle , Codrin Ciubotariu , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Sumit Semwal , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, stable@vger.kernel.org References: <20220303161724.3324948-1-michael@walle.cc> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_000454_918561_194A12D5 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Claudiu Beznea , linaro-mm-sig@lists.linaro.org, Michael Walle , linux-i2c@vger.kernel.org, stable@vger.kernel.org, Codrin Ciubotariu , Sumit Semwal , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============8024813199635976198==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8024813199635976198== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q4xj+Sj+I6MT188+" Content-Disposition: inline --q4xj+Sj+I6MT188+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Christian, > Maybe call your variable differently. DMA-buf is an inter driver buffer > sharing frame we use for GPU acceleration and V4L. >=20 > It doesn't cause any technical issues, but the maintainer regex now trigg= ers > on that. So you are CCing people not related to this code in any way. Frankly, I think the 'dma_buf' regex is a bit too generic. 'dma_buf' seems like a reasonable name to me if some subsystem has to deal with different buffers which can be DMA or non-DMA, like I2C. If you git-grep the tree, you will find it in quite some places. We could now think of renaming the variable to 'dmabuf' but this is a strange and kind of arbitrary rule to remember IMO. I wonder if you'd miss a lot of patches if we remove 'dma_buf' from the regex and keep 'dma_fence' and 'dma_resv'? Or extend it to 'dma_buf_' or 'struct dma_buf'? All the best, Wolfram --q4xj+Sj+I6MT188+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmIhyB4ACgkQFA3kzBSg KbZqdRAAk+1zEkJ+HS3V9yeKstHw9UOXqDrYgWXd3rMh8oZLB3UzVrnqkpzd7Orz wlpxLWSd7RGuCNYxCAYvB3NfH4tVG/PSDcZcGTENYiEnRYuCXh03Nz0GNkUEdwVQ LM//a5UketKvg/saVj3LduoK7KgfjsJcGi0XqpFxFHsKuFOvb9aL7MsP8oY1L2GB 41DcnvbtS9lYrseEAHl3qVKcT+TinRFygpxlgVcoS1r01Sji59q7ew2ul6Wp8KDm jIFHwlnLAhWGAJXAvBr3GV0jHGmMxu6Z0jnYwypr1xQX3OCndb92qqmWA0qeCjkB ligfcv7lcJ+gUBFZghoULph6GSpGEgSC81kxBpcaGPWKBA/Lb8N46sCM1e2XVfGg fY8xt7yR45gC2jYAQQRhlzjBSlmmws5PE147DwLzr1rYsGv8vKRYBfdmRD16WZz8 MkV+GdqE71UZSS4ja62vld6WiyPVBWb6ZcYeBZEuVdLiFCVbPj5ZWBf/idMar7Up +iyXvzNPFVUMFIsiEwU3SER5RQGUAHF9l573OY1GdUMAhO2qcy90BB4MOq2f3ayi hhW1k9yWqbij7GjVlKsXMUmHilxJZhGD6DCbumQztP6EHYEO+M4HRa7WEuGh5Q+s ZlOgSXwkubk7bLCa0qXxAv1SIwDj07ew/kbYxiMI7ieDDFdqVVY= =g1ks -----END PGP SIGNATURE----- --q4xj+Sj+I6MT188+-- --===============8024813199635976198== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8024813199635976198==--