From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DDAEC433F5 for ; Fri, 4 Mar 2022 15:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PuVLEwx2c9cOLnu8asKWHmzISKksK9HwQmnMmLUkTx8=; b=AfSQPwT2hrHRzS BrGLWdJtBw79/F4mQwjSod91JaBWU5OVCK2CKe4hD8joxbRA956qjrJGf9jihtiIFACu+mwdxXRyh vPxI8konncXOd/VLl4RcTS/hRtE7GFykZBpFf8fXo39Wc0NEj1wgIzZQXaeFufBHuYDSoefooDp1F 7YtZ5ul+ynNq5j34mwIn9Ku77Hup5Rv5hQuHtlOYGsDRLcjJepopAytgld8VEiu7xXE8eoZFA+eiu jpaZxsHOlcqaV+qylNiSgwyFFseaPRGaFpOX+pJEZH8Ik/C+JDZ6s+dwIBXVY3STa+yfxIBBDWZ0G HQKMBupM7Xgf8J0SlK1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQ9d2-00AgFP-0K; Fri, 04 Mar 2022 15:14:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQ9cx-00AgEM-8W for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 15:13:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98267143D; Fri, 4 Mar 2022 07:13:51 -0800 (PST) Received: from lpieralisi (unknown [10.57.37.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96D4F3F73D; Fri, 4 Mar 2022 07:13:49 -0800 (PST) Date: Fri, 4 Mar 2022 15:13:44 +0000 From: Lorenzo Pieralisi To: Ilkka Koskinen Cc: guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux@armlinux.org.uk, lenb@kernel.org, robert.moore@intel.com, james.morse@arm.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@amperecomputing.com, scott@os.amperecomputing.com, darren@os.amperecomputing.com Subject: Re: [PATCH v5 RESEND 0/2] ACPI: Arm Generic Diagnostic Dump and Reset device Message-ID: References: <20220304054003.152319-1-ilkka@os.amperecomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220304054003.152319-1-ilkka@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_071355_398337_0A6521B8 X-CRM114-Status: GOOD ( 27.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 03, 2022 at 09:40:01PM -0800, Ilkka Koskinen wrote: > Hi Lorenzo, > > Would you prefer this version, which doesn't have platform > device/driver any more? I thought about that and in order to keep consistency it is better to keep the platform device model, so please resend the latest version platform device based and I will ACK it (hopefully it is not too late for v5.18). Please note before resending it that sdei_event_unregister() requires a retry loop since it can return -EINPROGRESS (see sdei_unregister_ghes()). Thanks, Lorenzo > > --Ilkka > > > ---- > > Arm Generic Diagnostic Dump and Reset device enables a maintainer to > request OS to perform a diagnostic dump and reset a system via SDEI > event or an interrupt. This patchset adds support for the SDEI path. > > I do have a patch to enable the interrupt path as well but I'm holding > it back since AGDI table is missing interrupt configuration fields > (trigger type etc.). > > The recently published specification is available at > https://developer.arm.com/documentation/den0093/latest > > The patchset was tested on Ampere Altra/Mt. Jade. > > The patchset applies on top of > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (9db71e8e3027) > > I also tested it works on top of Shuai Xue's new patches in bleeding-edge branch (c6f4ba2d2b9a) > > From v1: > * Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init() > * Changed the ACPICA patch upstreaming order comment in the paragraph above > > From v2: > * The first patch was split. The most of it was merged to ACPICA project > at first and later ported to linux-acpi > (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first > patch. > > From v3: > Fixed: > * Moved header files in alphabetical order and removed unnecessary ones > > From v4: > * Platform device/driver stuff removed > * acpi_agdi_init() call moved from device_initcall to acpi_init() > * Slightly modified Kconfig text to keep checkpatch happy > > Ilkka Koskinen (2): > ACPI: tables: Add AGDI to the list of known table signatures > ACPI: AGDI: Add support for Arm Generic Diagnostic Dump and Reset > device > > drivers/acpi/arm64/Kconfig | 10 +++++++ > drivers/acpi/arm64/Makefile | 1 + > drivers/acpi/arm64/agdi.c | 52 +++++++++++++++++++++++++++++++++++++ > drivers/acpi/bus.c | 2 ++ > drivers/acpi/tables.c | 2 +- > include/linux/acpi_agdi.h | 13 ++++++++++ > 6 files changed, 79 insertions(+), 1 deletion(-) > create mode 100644 drivers/acpi/arm64/agdi.c > create mode 100644 include/linux/acpi_agdi.h > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel