From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2655C433F5 for ; Fri, 4 Mar 2022 15:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UeYzzDk1Z7I34l8Ox86xTiKrkZLBOQIInAKPRTJfFco=; b=ZkoQDo4wCJFyO5 SUZbMChWD3zqcb/YW2C0/bWd/Ikdaa0OF0wiWYdQiK/sQTubZ36s6AYgYo6C/k/JO2Lv40eSp83OT oPGeb1I2UGpWmVKVD4xX1+ldlyUSAz8JCtSqZcaqAymDJNZnZASyvK/RXFspRRE1V5SZfMeD1Mg4/ 8vGvYWj4mnwhM6ukXxYPLHaXEN14YpWXsOXhMNQVkpHwnrJaaOBZ6f14H6NRCPFpqtvW4iiOHcFUc 5tIqSYGeOtMHz/pT9MLiduSIAuTJV2Ul+Itm6SHn/z/ZD8Q0UMYkB/vz6uh+QHUFQ0wA6XejgXanS WGf/hJnzGpvANs66yMEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQA5W-00ApPb-W3; Fri, 04 Mar 2022 15:43:27 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQA5P-00ApLp-Ie for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 15:43:21 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 706891BF203; Fri, 4 Mar 2022 15:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646408597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DuDywd0Iu3hrHJ/1yYYDf0hLNoWpE4Lk1omLHli7PTo=; b=Tx0sM4e0E3YYWrdHr5WHAVMou9sbVVE89x7T8TvtJejAdc3K6t4ECWHIQ59CcaII3TC2uR 8IMR4ewGNjFC8SrZgxcyGCjYB/xatqblpyX4ixBgAtQgpzCycJAO/TlE5k0pTi2C0hlhMp w8j4mIovOQC/CsqVmRvfsVKsppudhWm4zNywgzzitNLvyFKB0536OJhRMJ9YVN2w5L0Q+Y Sjov42xNsFDmCpV48k6W15adLOigXQGsIJQEWBeROcxdqPOnYsau4rGXYkgFFPL9EsW9LG j6u6Suf8tJNrRIi06sfeSDeOTdodqX4b4B68VrVlNS+R+lgFPNc5CVOZRNtO8w== Date: Fri, 4 Mar 2022 16:43:16 +0100 From: Alexandre Belloni To: Sergiu.Moga@microchip.com Subject: Re: [PATCH v3 1/5] ARM: dts: at91: Add the required `atmel,rtt-rtc-time-reg` property Message-ID: References: <20220304142746.121947-1-sergiu.moga@microchip.com> <20220304142746.121947-2-sergiu.moga@microchip.com> <8f5d56ba-1a51-f9ab-43a2-86d7c938fbe2@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f5d56ba-1a51-f9ab-43a2-86d7c938fbe2@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_074319_984731_5D9BAA67 X-CRM114-Status: GOOD ( 25.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, krzysztof.kozlowski@canonical.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2022 15:29:45+0000, Sergiu.Moga@microchip.com wrote: > On 04.03.2022 16:53, Alexandre Belloni wrote: > > On 04/03/2022 16:27:42+0200, Sergiu Moga wrote: > >> Add the required `atmel,rtt-rtc-time-reg` property to the `rtt` nodes > >> of the board files that were missing it. > >> > >> Signed-off-by: Sergiu Moga > >> --- > >> arch/arm/boot/dts/at91sam9261ek.dts | 4 ++++ > >> arch/arm/boot/dts/at91sam9263ek.dts | 8 ++++++++ > >> arch/arm/boot/dts/at91sam9rlek.dts | 4 ++++ > >> 3 files changed, 16 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts > >> index beed819609e8..3c1f40b4a13e 100644 > >> --- a/arch/arm/boot/dts/at91sam9261ek.dts > >> +++ b/arch/arm/boot/dts/at91sam9261ek.dts > >> @@ -178,6 +178,10 @@ dbgu: serial@fffff200 { > >> status = "okay"; > >> }; > >> > >> + rtc@fffffd20 { > >> + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > >> + }; > >> + > >> watchdog@fffffd40 { > >> status = "okay"; > >> }; > >> diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts > >> index 71f60576761a..1208bb580d14 100644 > >> --- a/arch/arm/boot/dts/at91sam9263ek.dts > >> +++ b/arch/arm/boot/dts/at91sam9263ek.dts > >> @@ -102,6 +102,14 @@ mtd_dataflash@0 { > >> }; > >> }; > >> > >> + rtc@fffffd20 { > >> + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > >> + }; > >> + > >> + rtc@fffffd50 { > >> + atmel,rtt-rtc-time-reg = <&gpbr 0x4>; > >> + }; > > Do we really need two RTCs with the exact same features on that board? > > Is there a check failure hen the property is not there and the node is > > disabled? > > > I can understand your point here. No, it is indeed not really needed > since, from what I can see, they are both disabled in the SoC file. The > reason why I added both was that I thought it would have been more > consistent. Do you think I should remove both in this file and keep the > changes in the other 2 files only? > Well, I would keep the first node but not the second so that you have a good example, ready to be enabled. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel