From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ABC8C433F5 for ; Mon, 7 Mar 2022 16:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xNvKbr/fn1J2+W26ePYsVjmFf/8JdEVwqKtS28mStAE=; b=taieA9+Jbr5fjC 4DkxAshzpziMR2m21AcC8SojWEFyQh2hh0zK7uXENAisKRcUj+2O5YrKQffP9WDgZm/kcuEeC/QcL fSG3NlHHbNgCQzn/w7JjTdWWL2OF4miheH+qLmBP+eBxnh4BFebKAgcZCb4Xd/8A7soOE0KWIxCXr jv9UMC7xbHvHtF6c87lE7pf08d2Lnn98PiQ5ZEnAdQY6XY5zy4s0os7VTQ8OXLcGM33756lbmHhjE hjZH7RTpjcTFOnkGh9ao0rutfPAcsDD/YQypNxH5R7mZ2//othW0e88y9aEkRvU5/wOjZ8K30pS++ LuAOA3N+fS48/Zu2eVEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRG9z-000pSg-SR; Mon, 07 Mar 2022 16:24:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRG9w-000pS5-Ni for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 16:24:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CADDA153B; Mon, 7 Mar 2022 08:24:31 -0800 (PST) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA3243FA45; Mon, 7 Mar 2022 08:24:28 -0800 (PST) Date: Mon, 7 Mar 2022 16:24:58 +0000 From: Alexandru Elisei To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , "Russell King (Oracle)" , James Morse , Suzuki K Poulose , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 43/64] KVM: arm64: nv: arch_timer: Support hyp timer emulation Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-44-maz@kernel.org> <503754e615b9bc7605c379dd7f2549a1@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <503754e615b9bc7605c379dd7f2549a1@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_082432_843689_09BBAB5A X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Mar 07, 2022 at 03:44:43PM +0000, Marc Zyngier wrote: > On 2022-03-07 15:23, Alexandru Elisei wrote: > > Hi, > > > > On Fri, Jan 28, 2022 at 12:18:51PM +0000, Marc Zyngier wrote: > > > From: Christoffer Dall > > > > > > Emulating EL2 also means emulating the EL2 timers. To do so, we expand > > > our timer framework to deal with at most 4 timers. At any given time, > > > two timers are using the HW timers, and the two others are purely > > > emulated. > > > > > > The role of deciding which is which at any given time is left to a > > > mapping function which is called every time we need to make such a > > > decision. > > > > > > Signed-off-by: Christoffer Dall > > > [maz: added CNTVOFF support, general reworking for v4.8] > > > Signed-off-by: Marc Zyngier > > > --- > > > arch/arm64/include/asm/kvm_host.h | 4 + > > > arch/arm64/kvm/arch_timer.c | 165 > > > ++++++++++++++++++++++++++++-- > > > arch/arm64/kvm/sys_regs.c | 7 +- > > > arch/arm64/kvm/trace_arm.h | 6 +- > > > arch/arm64/kvm/vgic/vgic.c | 15 +++ > > > include/kvm/arm_arch_timer.h | 8 +- > > > include/kvm/arm_vgic.h | 1 + > > > 7 files changed, 194 insertions(+), 12 deletions(-) > > > > > [..] > > > @@ -1301,6 +1445,7 @@ static void set_timer_irqs(struct kvm *kvm, > > > int vtimer_irq, int ptimer_irq) > > > kvm_for_each_vcpu(i, vcpu, kvm) { > > > vcpu_vtimer(vcpu)->irq.irq = vtimer_irq; > > > vcpu_ptimer(vcpu)->irq.irq = ptimer_irq; > > > + /* TODO: Add support for hv/hp timers */ > > > } > > > } > > > > > > @@ -1311,6 +1456,8 @@ int kvm_arm_timer_set_attr(struct kvm_vcpu > > > *vcpu, struct kvm_device_attr *attr) > > > struct arch_timer_context *ptimer = vcpu_ptimer(vcpu); > > > int irq; > > > > > > + /* TODO: Add support for hv/hp timers */ > > > > Is the patch unfinished? > > Just like the rest of the kernel. That doesn't really answer my question. What I was asking if this is the patch that is intended to be merged or if you still want to add handling of those timers before merging it. Thanks, Alex > > M. > -- > Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel