From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D91E1C433EF for ; Mon, 7 Mar 2022 23:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/RK+6c+USZO5XnU98UjM8Rs/UB5Ig3G1JF4oc/jx8SU=; b=by1uOckNSag+C2 FEaQhMUQilcaIPiIVMBoDX4aCEEsCDkxtpZqOeNP7F0cUsMrk8dk1+2/yLmRwa5y1C5Pu0XjCaTT3 +2Ddb5aN1l8swVi/z7QR7Apuc88pFVrbnzYYfca5pQGgbtjjOyhVB4RMBIeJQORUyRU0BK+UNiHc9 ZlbJzCttPeRKoRX1wOeDzHcjEmuIC8oqQkbOQ+qogpwc7gKERGIfpHJZMKf4d7y3Gs6fIEmsfPkZS RpB5nKKwbQclb777mabKNOE0WDuLSXS8io74duzIzWJ5Mv8v/7PvUoobOg01++z9IAd0JvVxKuxA0 iAnB6IAqSnQ4s8XTDGJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRMfc-001y4V-JK; Mon, 07 Mar 2022 23:21:40 +0000 Received: from mail-oo1-f50.google.com ([209.85.161.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRMfZ-001y3r-79 for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 23:21:38 +0000 Received: by mail-oo1-f50.google.com with SMTP id x26-20020a4a9b9a000000b003211029e80fso3337578ooj.5 for ; Mon, 07 Mar 2022 15:21:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GwqBsAiwDA57OzBbnIQApP2KsOEcfE99XASAzmUckUs=; b=QpGNCR3prF5Pzupp9UEB1m6FEn497eTyGnQvA/nHaHVAKJxEwyGzHT2H6N+H7pWTf0 q8Mor1EoU3Dptr0WIomfAmQd7kwTEBCrGjcLMpnDe4zM8+PZLTkBG8Xk6ZygrwjMQsqo qDfmOFJLSoVNKiipDygLzafPw+SEWpxhHLI67qTya7hGIjoYtbBMZlroNNOfO07iOx/w 4pop4/h3v3gFojFT7Bxv25MEgg8zS/BfkGP1uju/8kQ8pBy4dTDiA9TFHuOA6NgmRyUb b5o5az75LAn3sbQs0Un/BnhwSsl/+s4t21ghS0QlHSsB9iWg5xdBgRIxOp4prOs3fftV LJ9w== X-Gm-Message-State: AOAM531Y76senC/EwUHly1HBzsJLfbf00Piy9lfdvJ168oF/Ws+BX+cn 16uE2kGVIF126lh222rIcg== X-Google-Smtp-Source: ABdhPJw/AE1EhWJP6qxkDyeRTJYp+la3lVDGzD9DakazOBHyOJ9Qw5nCO7bMG8JD6/2WWxv5bamQjg== X-Received: by 2002:a05:6870:d151:b0:da:4cd6:552e with SMTP id f17-20020a056870d15100b000da4cd6552emr788011oac.136.1646695296565; Mon, 07 Mar 2022 15:21:36 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ay44-20020a056808302c00b002d9d2b564absm2177987oib.43.2022.03.07.15.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 15:21:35 -0800 (PST) Received: (nullmailer pid 3453254 invoked by uid 1000); Mon, 07 Mar 2022 23:21:34 -0000 Date: Mon, 7 Mar 2022 17:21:34 -0600 From: Rob Herring To: Paul Kocialkowski , Saravana Kannan Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Frank Rowand , Maxime Ripard , Laurent Pinchart , Thomas Petazzoni Subject: Re: [PATCH RFC v3 1/8] of: Mark interconnects property supplier as optional Message-ID: References: <20220302211100.65264-1-paul.kocialkowski@bootlin.com> <20220302211100.65264-2-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220302211100.65264-2-paul.kocialkowski@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_152137_283092_6195DD79 X-CRM114-Status: GOOD ( 29.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Saravana On Wed, Mar 02, 2022 at 10:10:53PM +0100, Paul Kocialkowski wrote: > In order to set their correct DMA address offset, some devices rely on > the device-tree interconnects property which identifies an > interconnect node that provides a dma-ranges property that can be used > to set said offset. > > Since that logic is all handled by the generic openfirmware and driver > code, the device-tree description could be enough to properly set > the offset. > > However the interconnects property is currently not marked as > optional, which implies that a driver for the corresponding node > must be loaded as a requirement. When no such driver exists, this > results in an endless EPROBE_DEFER which gets propagated to the > calling driver. This ends up in the driver never loading. > > Marking the interconnects property as optional makes it possible > to load the driver in that situation, since the EPROBE_DEFER return > code will no longer be propagated to the driver. > > There might however be undesirable consequences with this change, > which I do not fully grasp at this point. > > Signed-off-by: Paul Kocialkowski > --- > drivers/of/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 8e90071de6ed..ef7c56b510e8 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1365,7 +1365,7 @@ static struct device_node *parse_interrupts(struct device_node *np, > > static const struct supplier_bindings of_supplier_bindings[] = { > { .parse_prop = parse_clocks, }, > - { .parse_prop = parse_interconnects, }, > + { .parse_prop = parse_interconnects, .optional = true,}, > { .parse_prop = parse_iommus, .optional = true, }, > { .parse_prop = parse_iommu_maps, .optional = true, }, > { .parse_prop = parse_mboxes, }, > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel