From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EDDFC433EF for ; Tue, 8 Mar 2022 12:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yszRWFSWI/ZnLTncMqaXnbqFyh9aANC/YaKYBddX2Us=; b=IKjwcrFSCw7d1s 9zClNzpj+/JY2SG8YvSKpFvk9f/nxrNccXaa5r2ANiCtjaNjLoIozC0PCoYUTDn/GUzuz1qEXQwx2 KX5YyFBzypeVdiWml0eqOtV1psinMYtjF3ryvrK7A4iw3+BmJ53jlRlRqBUchTJk8EYjOQQSQthdA k0/S3OAA54Q1SBMorpsfxlFFgxsKW1aKq9V5OtJkQ9LErDN6pUbZuoARy0A3lz0xN8+XbEwHQbeUD s+9xdFgSM3LWxERDtciJq+0wkMlUksbGtwZ6oqLEA2Pt8OB+qIUPMkSiOsbouqjRvvc921820zvqd 5AdQKcBYelyyiR6Gb0sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRYiH-004IBC-3p; Tue, 08 Mar 2022 12:13:13 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRYi0-004I5v-Sr for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 12:12:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=z08ScZS05aMHWMMj7LEdeEqpjcHMe/2Ssi4bpp+ATwY=; b=kuYHCQuNyBAEJwNbAQ+UKbLKpq nYWcw2sKyokDdvtO8gnKkmwIpdPXnZlbNaJ2IYTLb6UBlES2WH8EiFUdXpoWYPrvHTCWYIPygtdaK iLgEbFammUWkvtyL0JzdXdKzS3HQUNWBWo7UiqHJmx5FNiA/h+raxDceXkbKpX4sN/J3s6fsE66cP M3/oLzZfhXIz4wViQRL/5kVDZg8S6Z2sOJKSwiwo5qJvrCGkB1HOSEv4tJ3rr9oqAWgpWEMxbP2Bk 7wfdRKGMMPfdhciE/CT1rsitY2OghSCbrJv9t1WTqWDAoXpzR+oDEQwqze1jA1EjoYNT0lr5twrZP 4qAx19zQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57712) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRYhz-0000HW-26; Tue, 08 Mar 2022 12:12:55 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nRYhy-0006q3-1J; Tue, 08 Mar 2022 12:12:54 +0000 Date: Tue, 8 Mar 2022 12:12:54 +0000 From: "Russell King (Oracle)" To: Giammarco lynx Cc: linux-arm-kernel@lists.infradead.org Subject: Re: Fwd: Question abount VSOL/CarlitoxxPro SFP Patch on Marvell Armada (MCBIN DS) Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_041256_972437_CBDBE432 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 12:54:09PM +0100, Giammarco lynx wrote: > Hi Russell, > > here is the output of devmem without sfp-bus.c quirk: > > root@mcbin:~# devmem 0xf4133e10 > 0x0000600A So yes, bit 14 is set, meaning it's in sync, but negotiation has not completed. I think that probably means my theory that the module is operating in SGMII mode is likely to be correct. I would need to check, but I would guess that u-boot configures eth3 for SGMII at boot (despite it always being connected to a SFP cage which doesn't actually make that much sense) and the SFP module detects that the host is in SGMII mode at boot, and locks itself to that. When the kernel boots, it reconfigures the interface to be in 1000base-X mode, which would be way more sensible for the SFP cage given that SFPs are normally used for fibre, and the GPON module no longer links. If we were to add hacks so that this module caused the mcbin to stay in SGMII mode, this would break existing systems where the host boots in 1000base-X mode, causing the module to lock to 1000base-X. So, there is no solution here for the kernel that will work for everyone. This also means that what mode the module is in will depend on what module was _previously_ inserted in the SFP cage, since that will determine the host configuration at the point when the module is inserted. I guess the module has been designed with the assumption that the host it is plugged into will only be capable of operating with a single protocol. I can't see a clean solution to this one that will work for everyone. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel